Bug#1012786: libcamera: Fails to build from source
On 14/06/2022 15:35, Lisandro Damián Nicanor Pérez Meyer wrote: Hi! On Tue, 14 Jun 2022 at 05:26, Christopher Obbard wrote: Hi! I propose a patch to potentially fix this: https://salsa.debian.org/multimedia-team/libcamera/-/merge_requests/6 The use of the depreciated function could even be fixed in upstream, it could be worth updating the package from upstream? No, upstream is doing the right thing. Their builds ought to fail in this case. We are the ones that should disable this flag, as done. What you really need to do is take this issue to upstream so they use the newer interfaces if possible (ie, avoid the deprecation warning). Right, what I originally meant was: "perhaps upstream have fixed this by using the correct gstreamer function instead of a depreciated one, maybe we should check if upstream have done that". For the record, it turns out that upstream have: https://git.libcamera.org/libcamera/libcamera.git/commit/test/gstreamer/gstreamer_multi_stream_test.cpp?id=4085372c517e1527114dc4098194c3ae3b973ba0 So, if we update to the latest version of libcamera, everything is fine again for future :-). I don't mind doing an update to libcamera HEAD, if Andrew would like some help. Cheers! Chris
Bug#1012786: libcamera: Fails to build from source
Hi! On Tue, 14 Jun 2022 at 05:26, Christopher Obbard wrote: > > > Hi! > > I propose a patch to potentially fix this: > https://salsa.debian.org/multimedia-team/libcamera/-/merge_requests/6 > > The use of the depreciated function could even be fixed in upstream, it > could be worth updating the package from upstream? No, upstream is doing the right thing. Their builds ought to fail in this case. We are the ones that should disable this flag, as done. What you really need to do is take this issue to upstream so they use the newer interfaces if possible (ie, avoid the deprecation warning). -- Lisandro Damián Nicanor Pérez Meyer https://perezmeyer.com.ar/
Bug#1012786: libcamera: Fails to build from source
Hi! I propose a patch to potentially fix this: https://salsa.debian.org/multimedia-team/libcamera/-/merge_requests/6 The use of the depreciated function could even be fixed in upstream, it could be worth updating the package from upstream? @Andrew: can you review the patch above? Also, I can help with updating from upstream if you would like. Chris On 14/06/2022 03:02, Lisandro Damián Nicanor Pérez Meyer wrote: Source: libcamera Version: 0~git20200629+e7aa92a-8 Severity: serious Justification: Fails to build form source X-Debbugs-Cc: lisan...@debian.org Trying to fix a bug in libcamera I found it's currently failing to build from source. Seems it's taking deprecation warnings as errors. Log follows. Kinds regards, Lisandro. ../test/gstreamer/gstreamer_multi_stream_test.cpp: In member function ‘virtual int GstreamerMultiStreamTest::run()’: ../test/gstreamer/gstreamer_multi_stream_test.cpp:90:76: error: ‘GstPad* gst_element_get_request_pad(GstElement*, const gchar*)’ is deprecated: Use 'gst_element_request_pad_simple' instead [-Werror=deprecated-declarations] 90 | g_autoptr(GstPad) request_pad = gst_element_get_request_pad(libcameraSrc_, "src_%u"); | ~~~^ In file included from /usr/include/gstreamer-1.0/gst/gstbin.h:27, from /usr/include/gstreamer-1.0/gst/gst.h:35, from ../test/gstreamer/gstreamer_multi_stream_test.cpp:13: /usr/include/gstreamer-1.0/gst/gstelement.h:1042:25: note: declared here 1042 | GstPad* gst_element_get_request_pad (GstElement *element, const gchar *name); | ^~~ cc1plus: all warnings being treated as errors [246/390] /usr/bin/meson --internal symbolextractor '/<>/obj-x86_64-linux-gnu' src/libcamera/base/libcamera-base.so.0.0.0 src/libcamera/base/libcamera-base.so.0.0.0 src/libcamera/base/libcamera-base.so.0.0.0.p/libcamera-base.so.0.0.0.symbols [247/390] ccache c++ -Itest/stream/stream_formats.p -Itest/stream -I../test/stream -Itest/libtest -I../test/libtest -Iinclude -I../include -Iinclude/libcamera -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++17 -O0 -Wshadow -include config.h -g -O2 '-ffile-prefix-map=/<>=.' -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -MD -MQ test/stream/stream_formats.p/stream_formats.cpp.o -MF test/stream/stream_formats.p/stream_formats.cpp.o.d -o test/stream/stream_formats.p/stream_formats.cpp.o -c ../test/stream/stream_formats.cpp [248/390] ccache c++ -Itest/serialization/control_serialization.p -Itest/serialization -I../test/serialization -Itest/libtest -I../test/libtest -Iinclude -I../include -Iinclude/libcamera/ipa -Iinclude/libcamera -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++17 -O0 -Wshadow -include config.h -g -O2 '-ffile-prefix-map=/<>=.' -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -DLIBCAMERA_BASE_PRIVATE -MD -MQ test/serialization/control_serialization.p/serialization_test.cpp.o -MF test/serialization/control_serialization.p/serialization_test.cpp.o.d -o test/serialization/control_serialization.p/serialization_test.cpp.o -c ../test/serialization/serialization_test.cpp [249/390] ccache c++ -Itest/serialization/ipa_data_serializer_test.p -Itest/serialization -I../test/serialization -Itest/libtest -I../test/libtest -Iinclude -I../include -Iinclude/libcamera/ipa -Iinclude/libcamera -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++17 -O0 -Wshadow -include config.h -g -O2 '-ffile-prefix-map=/<>=.' -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -DLIBCAMERA_BASE_PRIVATE -MD -MQ test/serialization/ipa_data_serializer_test.p/serialization_test.cpp.o -MF test/serialization/ipa_data_serializer_test.p/serialization_test.cpp.o.d -o test/serialization/ipa_data_serializer_test.p/serialization_test.cpp.o -c ../test/serialization/serialization_test.cpp [250/390] ccache c++ -Itest/serialization/control_serialization.p -Itest/serialization -I../test/serialization -Itest/libtest -I../test/libtest -Iinclude -I../include -Iinclude/libcamera/ipa -Iinclude/libcamera -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++17 -O0 -Wshadow -include config.h -g -O2 '-ffile-prefix-map=/<>=.' -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -DLIBCAMERA_BASE_PRIVATE -MD -MQ test/serialization/control_serialization.p/control_serialization.cpp.o -MF test/serialization/control_serialization.p/control_serialization.cpp.o.d -o test/serialization/control_serialization.p/co
Bug#1012786: libcamera: Fails to build from source
Source: libcamera Version: 0~git20200629+e7aa92a-8 Severity: serious Justification: Fails to build form source X-Debbugs-Cc: lisan...@debian.org Trying to fix a bug in libcamera I found it's currently failing to build from source. Seems it's taking deprecation warnings as errors. Log follows. Kinds regards, Lisandro. ../test/gstreamer/gstreamer_multi_stream_test.cpp: In member function ‘virtual int GstreamerMultiStreamTest::run()’: ../test/gstreamer/gstreamer_multi_stream_test.cpp:90:76: error: ‘GstPad* gst_element_get_request_pad(GstElement*, const gchar*)’ is deprecated: Use 'gst_element_request_pad_simple' instead [-Werror=deprecated-declarations] 90 | g_autoptr(GstPad) request_pad = gst_element_get_request_pad(libcameraSrc_, "src_%u"); | ~~~^ In file included from /usr/include/gstreamer-1.0/gst/gstbin.h:27, from /usr/include/gstreamer-1.0/gst/gst.h:35, from ../test/gstreamer/gstreamer_multi_stream_test.cpp:13: /usr/include/gstreamer-1.0/gst/gstelement.h:1042:25: note: declared here 1042 | GstPad* gst_element_get_request_pad (GstElement *element, const gchar *name); | ^~~ cc1plus: all warnings being treated as errors [246/390] /usr/bin/meson --internal symbolextractor '/<>/obj-x86_64-linux-gnu' src/libcamera/base/libcamera-base.so.0.0.0 src/libcamera/base/libcamera-base.so.0.0.0 src/libcamera/base/libcamera-base.so.0.0.0.p/libcamera-base.so.0.0.0.symbols [247/390] ccache c++ -Itest/stream/stream_formats.p -Itest/stream -I../test/stream -Itest/libtest -I../test/libtest -Iinclude -I../include -Iinclude/libcamera -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++17 -O0 -Wshadow -include config.h -g -O2 '-ffile-prefix-map=/<>=.' -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -MD -MQ test/stream/stream_formats.p/stream_formats.cpp.o -MF test/stream/stream_formats.p/stream_formats.cpp.o.d -o test/stream/stream_formats.p/stream_formats.cpp.o -c ../test/stream/stream_formats.cpp [248/390] ccache c++ -Itest/serialization/control_serialization.p -Itest/serialization -I../test/serialization -Itest/libtest -I../test/libtest -Iinclude -I../include -Iinclude/libcamera/ipa -Iinclude/libcamera -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++17 -O0 -Wshadow -include config.h -g -O2 '-ffile-prefix-map=/<>=.' -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -DLIBCAMERA_BASE_PRIVATE -MD -MQ test/serialization/control_serialization.p/serialization_test.cpp.o -MF test/serialization/control_serialization.p/serialization_test.cpp.o.d -o test/serialization/control_serialization.p/serialization_test.cpp.o -c ../test/serialization/serialization_test.cpp [249/390] ccache c++ -Itest/serialization/ipa_data_serializer_test.p -Itest/serialization -I../test/serialization -Itest/libtest -I../test/libtest -Iinclude -I../include -Iinclude/libcamera/ipa -Iinclude/libcamera -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++17 -O0 -Wshadow -include config.h -g -O2 '-ffile-prefix-map=/<>=.' -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -DLIBCAMERA_BASE_PRIVATE -MD -MQ test/serialization/ipa_data_serializer_test.p/serialization_test.cpp.o -MF test/serialization/ipa_data_serializer_test.p/serialization_test.cpp.o.d -o test/serialization/ipa_data_serializer_test.p/serialization_test.cpp.o -c ../test/serialization/serialization_test.cpp [250/390] ccache c++ -Itest/serialization/control_serialization.p -Itest/serialization -I../test/serialization -Itest/libtest -I../test/libtest -Iinclude -I../include -Iinclude/libcamera/ipa -Iinclude/libcamera -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++17 -O0 -Wshadow -include config.h -g -O2 '-ffile-prefix-map=/<>=.' -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -DLIBCAMERA_BASE_PRIVATE -MD -MQ test/serialization/control_serialization.p/control_serialization.cpp.o -MF test/serialization/control_serialization.p/control_serialization.cpp.o.d -o test/serialization/control_serialization.p/control_serialization.cpp.o -c ../test/serialization/control_serialization.cpp [251/390] ccache c++ -Itest/v4l2_subdevice/list_formats.p -Itest/v4l2_subdevice -I../test/v4l2_subdevice -Itest/libtest -I../test/libtest -Iinclude -I../include -Iinclude/libcamera/ipa -Iinclude/libcamera -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++17 -O0 -Wshadow -include confi
