Bug#1012818: inkscape: Please update for Poppler 22.06
On Fri, Sep 30, 2022 at 12:49:29PM +0200, Mattia Rizzolo wrote: > On Thu, Sep 29, 2022 at 08:03:26PM +0200, Miroslav Kratochvil wrote: > > > Oh, inkscape 1.2.1 does build with the latest poppler > > > > Hi all, > > I recently noticed that inkscape (1.1.2-3+b1 from testing) crashes when > > opening any PDF files; quick debug showing that the crash happens in > > poppler. My best-guess reason now is because the binary actually loads 2 > > different versions of poppler. > > I'm about (=> during the day) to upload to unstable 1.2.1+really1.1.2-1, > reverting 1.2.x back to 1.1.x. Or so I thought, but i get other extra test failures now… (both with 1.1.2 and 1.2.1), so I guess this is not happening today :( -- regards, Mattia Rizzolo GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`. More about me: https://mapreri.org : :' : Launchpad user: https://launchpad.net/~mapreri `. `'` Debian QA page: https://qa.debian.org/developer.php?login=mattia `- signature.asc Description: PGP signature
Bug#1012818: inkscape: Please update for Poppler 22.06
On Thu, Sep 29, 2022 at 08:03:26PM +0200, Miroslav Kratochvil wrote: > > Oh, inkscape 1.2.1 does build with the latest poppler > > Hi all, > I recently noticed that inkscape (1.1.2-3+b1 from testing) crashes when > opening any PDF files; quick debug showing that the crash happens in > poppler. My best-guess reason now is because the binary actually loads 2 > different versions of poppler. I'm about (=> during the day) to upload to unstable 1.2.1+really1.1.2-1, reverting 1.2.x back to 1.1.x. That one will be built against poppler 22.06, so please check that version and file a new bug if this crash continues. -- regards, Mattia Rizzolo GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`. More about me: https://mapreri.org : :' : Launchpad user: https://launchpad.net/~mapreri `. `'` Debian QA page: https://qa.debian.org/developer.php?login=mattia `- signature.asc Description: PGP signature
Bug#1012818: inkscape: Please update for Poppler 22.06
> Oh, inkscape 1.2.1 does build with the latest poppler Hi all, I recently noticed that inkscape (1.1.2-3+b1 from testing) crashes when opening any PDF files; quick debug showing that the crash happens in poppler. My best-guess reason now is because the binary actually loads 2 different versions of poppler. `bt` from GDB: #0 NameToCharCode::~NameToCharCode() (this=0x555003c6f4df, __in_chrg=) at ./poppler/NameToCharCode.cc:55 #1 0x7518f25d in GlobalParams::~GlobalParams() (this=0x5693f490, __in_chrg=) at ./poppler/GlobalParams.cc:557 #2 0x72b9bba1 in std::default_delete::operator()(GlobalParams*) const (this=, __ptr=0x5693f490) at /usr/include/c++/12/bits/unique_ptr.h:95 #3 std::default_delete::operator()(GlobalParams*) const (__ptr=0x5693f490, this=) at /usr/include/c++/12/bits/unique_ptr.h:89 #4 std::unique_ptr >::~unique_ptr() (this=, __in_chrg=) at /usr/include/c++/12/bits/unique_ptr.h:396 #5 0x75c404e7 in __cxa_finalize (d=0x72d8c000) at ./stdlib/cxa_finalize.c:83 #6 0x72ae4267 in __do_global_dtors_aux () at /usr/lib/x86_64-linux-gnu/libpoppler.so.123 #7 0x7fffe640 in () #8 0x77fcec86 in _dl_fini () at ./elf/dl-fini.c:143 and the relevant piece of `info dll`: 0x750dd9b0 0x752614ce Yes /usr/bin/../lib/x86_64-linux-gnu/inkscape/../libpoppler.so.118 0x72adfd30 0x72c6d3be Yes /usr/lib/x86_64-linux-gnu/libpoppler.so.123 ...in particular, stack frames #0 and #1 seem to originate from poppler.so.118 while #6 really seems to be from .123, which is not necessarily the reason for the crash but I guess it's sufficiently fishy. Can the crash be related to this bug, or does it seem unrelated and I should open another one? Thanks for any info! -mk
Bug#1012818: inkscape: Please update for Poppler 22.06
Control: severity -1 important Oh, inkscape 1.2.1 does build with the latest poppler. If you do end up reverting to the older inkscape version, you'll need the poppler patches. Thank you, Jeremy Bicha
Bug#1012818: inkscape: Please update for Poppler 22.06
Control: block -1 by 1012496 On Tue, Jun 14, 2022 at 04:03:39PM -0300, Nathan Pratta Teodosio wrote: > Package: inkscape > Severity: normal > Tags: patch > X-Debbugs-Cc: nathan.teodo...@canonical.com > > Dear Maintainer, > > Since Poppler 22.06 is making its way into experimental (currently in NEW[1]), > Inkscape will need the corresponding compatibility changes from upstream to > build. I cherry-picked them in the attached patch and with Sbuilder made sure > it builds against the new Poppler. This is nice (or not really, since it's quite tiresome to have to chase after poppler all the time…), but blocked since the new inkscape doesn't build on all architectures. See https://bugs.debian.org/1012496 and https://gitlab.com/inkscape/inkscape/-/issues/3554 -- regards, Mattia Rizzolo GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`. More about me: https://mapreri.org : :' : Launchpad user: https://launchpad.net/~mapreri `. `'` Debian QA page: https://qa.debian.org/developer.php?login=mattia `- signature.asc Description: PGP signature
Bug#1012818: inkscape: Please update for Poppler 22.06
Package: inkscape
Severity: normal
Tags: patch
X-Debbugs-Cc: nathan.teodo...@canonical.com
Dear Maintainer,
Since Poppler 22.06 is making its way into experimental (currently in NEW[1]),
Inkscape will need the corresponding compatibility changes from upstream to
build. I cherry-picked them in the attached patch and with Sbuilder made sure
it builds against the new Poppler.
[1]: https://ftp-master.debian.org/new.html
-- System Information:
Debian Release: bookworm/sid
APT prefers kinetic
APT policy: (500, 'kinetic')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 5.15.0-33-generic (SMP w/8 CPU threads)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=pt_BR.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages inkscape depends on:
ii lib2geom1.1.0 1.1-3
ii libatkmm-1.6-1v5 2.28.2-1build1
ii libboost-filesystem1.74.0 1.74.0-14ubuntu4
ii libc6 2.35-0ubuntu3
ii libcairo2 1.16.0-5ubuntu2
ii libcairomm-1.0-1v5 1.12.2-4build3
ii libcdr-0.1-1 0.1.6-2build3
ii libdbus-glib-1-2 0.112-2build1
ii libfontconfig1 2.13.1-4.4ubuntu1
ii libfreetype6 2.12.1+dfsg-2
ii libgc1 1:8.0.6-1.1build1
ii libgcc-s1 12.1.0-2ubuntu1
ii libgdk-pixbuf-2.0-02.42.8+dfsg-1
ii libglib2.0-0 2.72.1-1
ii libglibmm-2.4-1v5 2.66.2-2
ii libgomp1 12.1.0-2ubuntu1
ii libgsl27 2.7.1+dfsg-3
ii libgspell-1-2 1.10.0-1
ii libgtk-3-0 3.24.33-2ubuntu1
ii libgtkmm-3.0-1v5 3.24.5-1build1
ii libharfbuzz0b 2.7.4-1ubuntu4
ii libjpeg8 8c-2ubuntu10
ii liblcms2-2 2.12~rc1-2build2
ii libmagick++-6.q16-88:6.9.11.60+dfsg-1.3build2
ii libpango-1.0-0 1.50.7+ds-1
ii libpangocairo-1.0-01.50.7+ds-1
ii libpangoft2-1.0-0 1.50.7+ds-1
ii libpangomm-1.4-1v5 2.46.2-1
ii libpng16-161.6.37-5
ii libpoppler-glib8 22.06.0-1
pn libpoppler118
ii libpotrace01.16-2
ii libreadline8 8.1.2-1.2
ii librevenge-0.0-0 0.0.4-6ubuntu7
ii librsvg2-common2.52.5+dfsg-3
ii libsigc++-2.0-0v5 2.10.4-2ubuntu3
ii libsoup2.4-1 2.74.2-3
ii libstdc++6 12.1.0-2ubuntu1
ii libvisio-0.1-1 0.1.7-1build6
ii libwpg-0.3-3 0.3.3-1build3
ii libx11-6 2:1.7.5-1
ii libxml22.9.14+dfsg-1
ii libxslt1.1 1.1.34-4build2
ii python33.10.4-0ubuntu2
ii zlib1g 1:1.2.11.dfsg-2ubuntu9
Versions of packages inkscape recommends:
ii aspell 0.60.8-4build1
pn fig2dev
ii imagemagick 8:6.9.11.60+dfsg-1.3build2
ii imagemagick-6.q16 [imagemagick] 8:6.9.11.60+dfsg-1.3build2
pn libimage-magick-perl
pn libwmf-bin
ii python3-lxml 4.8.0-1build1
ii python3-numpy1:1.21.5-1build2
ii python3-scour0.38.2-2
Versions of packages inkscape suggests:
pn dia
pn inkscape-tutorials
pn libsvg-perl
ii pstoedit 3.78-1
pn python3-uniconvertor
ii ruby 1:3.0~exp1
diff --git a/src/extension/internal/pdfinput/pdf-parser.cpp
b/src/extension/internal/pdfinput/pdf-parser.cpp
index
feecefa0434d82f131a203311f08b4ee7165492a..d6e2ede4f358e8761436bf68bdf93be306f03cb9
100644
--- a/src/extension/internal/pdfinput/pdf-parser.cpp
+++ b/src/extension/internal/pdfinput/pdf-parser.cpp
@@ -30,6 +30,7 @@
#include "Gfx.h"
#include "pdf-parser.h"
#include "util/units.h"
+#include "poppler-transition-api.h"
#include "glib/poppler-features.h"
#include "goo/gmem.h"
@@ -2158,7 +2159,7 @@ void PdfParser::opSetCharSpacing(Object args[], int
/*numArgs*/)
// TODO not good that numArgs is ignored but args[] is used:
void PdfParser::opSetFont(Object args[], int /*numArgs*/)
{
- GfxFont *font = res->lookupFont(args[0].getName());
+ auto font = res->lookupFont(args[0].getName());
if (!font) {
// unsetting the font (drawing no text) is better than using the
@@ -2179,7 +2180,9 @@ void PdfParser::opSetFont(Object args[], int /*numArgs*/)
fflush(stdout);
}
+#if !POPPLER_CHECK_VERSION(22, 4, 0)
font->incRefCnt();
+#endif
state->setFont(font, args[1].getNum());
fontChanged = gTrue;
}
@@ -2373,7 +2376,6 @@ void PdfParser::doShowText(const GooString *s) {
#else
void PdfParser::doShowText(GooString *s) {
#endif
- GfxFont *font;
int wMode;
double riseX, riseY;
CharCode code;
@@
