Bug#1015782: live-build: Replace a few more values in the splash SVG -> pending
[Roland Clobus] > The git repository now has three variables: LB_ISO_APPLICATION, > LB_ISO_PUBLISHER and LB_LINUX_PACKAGES > See > https://salsa.debian.org/live-team/live-build/-/merge_requests/288 Good to know. I'll eagerly await the new release of live-build, then. :) -- Happy hacking Petter Reinholdtsen
Bug#1015782: live-build: Replace a few more values in the splash SVG -> pending
Control: tags -1 +pending On 22/08/2022 08:23, Petter Reinholdtsen wrote: Do you need a new patch with less variables, or is the patch as sent OK? I believe it is better to make the complete set of variables available for SVG authors, and thus hope the original patch can be accepted. The git repository now has three variables: LB_ISO_APPLICATION, LB_ISO_PUBLISHER and LB_LINUX_PACKAGES See https://salsa.debian.org/live-team/live-build/-/merge_requests/288 I have not added LB_ISO_PREPARER, because xorriso recommends not to change this value. Perhaps it should be removed from the interface of 'lb' at a later moment. I have not added LB_ISO_VOLUME: the default value contains the magic sequence '@ISOVOLUME_TS@' which resolves to a timestamp. This would need additional handling. The timestamp is available in all its parts anyway. With kind regards, Roland Clobus PS: To use the git repo, see https://wiki.debian.org/ReproducibleInstalls/LiveImages You'll need something like 'export LIVE_BUILD=/home/roland/git.nobackup/live-build' OpenPGP_signature Description: OpenPGP digital signature
Bug#1015782: live-build: Replace a few more values in the splash SVG
Control: tags -1 + patch Do you need a new patch with less variables, or is the patch as sent OK? I believe it is better to make the complete set of variables available for SVG authors, and thus hope the original patch can be accepted. -- Happy hacking Petter Reinholdtsen
Bug#1015782: live-build: Replace a few more values in the splash SVG
[Roland Clobus] > Of the 5 additional variables, only 3 are used in your SVG image > (LB_ISO_APPLICATION, LB_ISO_PUBLISHER, LB_LINUX_PACKAGES). > Do you mind if I will add only these three? Any is better than none. :) Is there a reason not to make all 5 variables available for SVG artists? > I've looked a little deeper into the repository. > Perhaps the following questions should be redirected to a mailing list > instead of drifting off-topic from this bug report: > > The file in patches/binary_syslinux is rather different from the version > in git (https://salsa.debian.org/live-team/live-build). Have you tried > using live-build from bookworm (which is currently at 1:20220505 or > better yet, the latest version from git? (By setting LIVE_BUILD, see > https://wiki.debian.org/ReproducibleInstalls/LiveImages) > > Your repository is called https://github.com/LinuxCNC/buster-live-build, > which refers to buster, which is currently oldstable. Will you be aiming > for bookworm? (You could use a single repository live-build-config, with > several branches) > > The image for Grub (used for UEFI boot) is the default image. Is that > intentional? I have similar question regarding the setup, and have no idea what the answer to them are. I recently decided to have a look at the live build to bring it up to bookworm, and discovered one needed patch that I decided to submit to you. I am working on a patch set for bookworm, but it is not yet ready. > PS: In the README.md you could add a first step: > lb config --config https://github.com/LinuxCNC/buster-live-build Ah, thanks. :) -- Happy hacking Petter Reinholdtsen
Bug#1015782: live-build: Replace a few more values in the splash SVG
Hello Petter, On 21/07/2022 08:36, Petter Reinholdtsen wrote: > The LinuxCNC live build provide a splash SVG with a few more strings > that are replaced at build time. ... > It would be great if these strings could be inserted by the official > live-build scripts, so the project did not have to use a patched > binary_syslinux. Of the 5 additional variables, only 3 are used in your SVG image (LB_ISO_APPLICATION, LB_ISO_PUBLISHER, LB_LINUX_PACKAGES). Do you mind if I will add only these three? xorriso does not recommend changing LB_ISO_PREPARER, so I would rather leave that one out. I've looked a little deeper into the repository. Perhaps the following questions should be redirected to a mailing list instead of drifting off-topic from this bug report: The file in patches/binary_syslinux is rather different from the version in git (https://salsa.debian.org/live-team/live-build). Have you tried using live-build from bookworm (which is currently at 1:20220505 or better yet, the latest version from git? (By setting LIVE_BUILD, see https://wiki.debian.org/ReproducibleInstalls/LiveImages) Your repository is called https://github.com/LinuxCNC/buster-live-build, which refers to buster, which is currently oldstable. Will you be aiming for bookworm? (You could use a single repository live-build-config, with several branches) The image for Grub (used for UEFI boot) is the default image. Is that intentional? With kind regards, Roland Clobus PS: In the README.md you could add a first step: lb config --config https://github.com/LinuxCNC/buster-live-build OpenPGP_signature Description: OpenPGP digital signature
Bug#1015782: live-build: Replace a few more values in the splash SVG
Package: live-build
Version: 1:20190311
Severity: wishlist
The LinuxCNC live build provide a splash SVG with a few more strings
that are replaced at build time. The currently used SVG can be found in
https://github.com/LinuxCNC/buster-live-build/blob/master/config/bootloaders/isolinux/splash.svg
>.
It would be great if these strings could be inserted by the official
live-build scripts, so the project did not have to use a patched
binary_syslinux. This is the patch in question. It was created by Andy
Pugh back in 2020.
--- binary_syslinux?inline=false2022-07-21 08:24:47.290238867 +0200
+++ patches/binary_syslinux 2022-07-21 08:02:59.462562152 +0200
@@ -257,6 +257,11 @@
-e "s|@LIVE_BOOT_VERSION@|${_LIVE_BOOT_VERSION}|g" \
-e "s|@LIVE_CONFIG_VERSION@|${_LIVE_CONFIG_VERSION}|g" \
-e "s|@LIVE_TOOLS_VERSION@|${_LIVE_TOOLS_VERSION}|g" \
+ -e "s|@LB_ISO_APPLICATION@|${LB_ISO_APPLICATION}|g" \
+ -e "s|@LB_ISO_PREPARER@|${LB_ISO_PREPARER}|g" \
+ -e "s|@LB_ISO_PUBLISHER@|${LB_ISO_PUBLISHER}|g" \
+ -e "s|@LB_ISO_VOLUME@|${LB_ISO_VOLUME}|g" \
+ -e "s|@LB_LINUX_PACKAGES@|${LB_LINUX_PACKAGES}|g" \
"${_FILE}"
fi
done
--
Happy hacking
Petter Reinholdtsen
