Bug#1016925: Re: Bug#1016925: kodi: Video playback not working in latest version of kodi
Le mercredi 21 septembre 2022 à 16:56 +, Vasyl Gello a écrit : > Dear Alban, > > > Maybe there is no way out of reverting the commit upstream ? > > I got the private message from James on how to fix that issue however > Alwin have not managed to fix it yet. > I have to change hotels because of situation around Ukraine, thus I > have very limited time. > > I can try building the latest Kodi from Debian in the next few days > but I can not 100% guarantee I craft the fix > for the issue in question. This can wait a week or two. Only that Kodi 20 startup was faster so I am eagier to switch for daily use. I watch live tv on this box every day but I can stay with Kodi 19 for a little while. I thought there was no reply as there was no follow up on hte bug report but now that you followed up on my question and regarding your answer it looks that a fix is on its way soon. Thank you. PS: no hurry, but if James told you how to fix the issue on the kodi side, maybe adding James rationale to the bug report will help other project to cope with this issue later on. Either way I have issue with the salsa repo and uscan you might encounter if you want to do a new release, namely that nowadays GitHub releases pages does not work with uscan, switch to GitHub tags page, see https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1019696 . So I cooked a patch for it which I am planning to upload to salsa and cook a PR. But even with that fix gbp import-orig --uscan fails later on :-/ gbp:error: Import of ../kodi_20.0~alpha3+dfsg1.orig.tar.xz failed: No tree for 'repo-resources-embedded' found in 'upstream' to create pristine tar commit from while plain uscan works. I have no clue how to fix this one. All in all I have the "1020452: kodi: 20 Nexus with upstream/Debian libdvdnav4 6.1.1 does not work - call to undefined functions" that keeps me busy :-) Take care of yourself first though, Alban > -- > Vasyl GelloCertified SolidWorks Expert > > Mob.:+380 (98) 465 66 77 > > E-Mail: vasek.ge...@gmail.com호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다
Bug#1016925: Re: Bug#1016925: kodi: Video playback not working in latest version of kodi
Dear Alban, > Maybe there is no way out of reverting the commit upstream ? I got the private message from James on how to fix that issue however Alwin have not managed to fix it yet. I have to change hotels because of situation around Ukraine, thus I have very limited time. I can try building the latest Kodi from Debian in the next few days but I can not 100% guarantee I craft the fix for the issue in question. -- Vasyl Gello == Certified SolidWorks Expert Mob.:+380 (98) 465 66 77 E-Mail: vasek.ge...@gmail.com == 호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다
Bug#1016925: Re: Bug#1016925: kodi: Video playback not working in latest version of kodi
On Fri, 19 Aug 2022 14:50:30 + Vasyl Gello wrote: > Dear James, > > Maybe you can advise how to handle this removal properly in Kodi? > Maybe there is no way out of reverting the commit upstream ? I see no reports about this issue in https://trac.ffmpeg.org/search?q=kodi. Could you forward the issue to the ffmpeg upstream bug tracker ? If you cannot or do not have the time to open an ffmpeg upstream bug report, tell me I will open an upstream bug, but I just do not know yet how to bind such an upstream bug report to Debian BTS. PS: I have a setup that can reproduce the issue (Kodi + NextPVR) so I may be able to test code if that is requested by upstream. Though I do not know Kodi internals. > 15 серпня 2022 р. 21:49:19 UTC, Rogo написав(-ла): > >Hi, > > > >since kodi in Debian is built against ffmpeg 5.1, TV playback is broken. > >More specifically, kodi can no longer play video transport streams. > > > >One can reproduce this by playing a video from a ts file in kodi, e.g.: > >$ ffmpeg -f lavfi -i testsrc -t 10 -c:v h264 test.ts > >$ kodi test.ts > > > >This worked fine with kodi 19.4, which was built against ffmpeg 4.4, > >but no longer shows the video in kodi 20, which is built against ffmpeg 5.1. > > > >The problem is that kodi tries to manually extract transport stream extradata > >using parser->split in CDVDDemuxFFmpeg::ParsePacket [1], but all the split > >functions were removed in ffmpeg 5.0 by [2]: > >commit e5af9203098a889f36b759652615046254d45102 > >Author: Andreas Rheinhardt > >Date: Sun Mar 7 00:28:14 2021 +0100 > > > > avcodec: Move all AVCodecParser.split functions to remove_extradata_bsf > > > > The remove_extradata bsf is the only user of these functions. > > > > Signed-off-by: Andreas Rheinhardt > > Signed-off-by: James Almer > > > >Reverting this commit on top of ffmpeg 5.1 (and including startcode.h in > >files then using avpriv_find_start_code) restores TV playback in kodi. > > > >As the example of kodi shows, these split functions are generally useful > >for API users outside of ffmpeg itself. > >Thus please restore them, e.g. by reverting this commit. > > > >Thanks, > >Rogo > > > >1: https://salsa.debian.org/multimedia-team/kodi-media-center/kodi/-/blob/1690349c890bdf941216218dd6b4f7b9c4204dc0/xbmc/cores/VideoPlayer/DVDDemuxers/DVDDemuxFFmpeg.cpp#L2260 > >2: https://git.ffmpeg.org/gitweb/ffmpeg.git/commitdiff/e5af9203098a889f36b759652615046254d45102 > > The author of the code is Andreas Rheinhardt. Do you want to forward your email to him too ? All in all I believe this material for the ffmpeg bug tracker not personal emails. > -- > Vasyl Gello > == > Certified SolidWorks Expert > > Mob.:+380 (98) 465 66 77 > > E-Mail: vasek.ge...@gmail.com > == > 호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다 Kind regards, Alban
