Bug#1017377: libstb: incomplete clean target

2022-10-06 Thread David Paul
On Tue, 27 Sep 2022 12:39:17 -0400
Boyuan Yang  wrote:

> On Mon, 15 Aug 2022 00:54:23 -0500 "David (Plasma) Paul"
>  wrote:
> > Source: libstb
> > Version: 0.0~git20210910.af1a5bc+ds-1
> > Severity: minor
> > X-Debbugs-CC: davidp...@librem.one
...
> > The 'clean' target for the libstb Makefile is incomplete and leaves
> > behind two files, stb_c_lexer.c and stb_divide.c, generated by the
> > '%.c' target.
> > 
> > I have prepared a patch to correct this. I will submit the patch
> > momentarily once I update the changelog entry with the bug number
> > created by this report.  
> 
> While we will fix this issue in Debian, I am just wondering, have you
> reported this issue (possibly together with the patch) to upstream
> project?

I haven't. Given that my patch is limited to editing a Makefile that is
not in the upstream source and is instead added by the Debian
packaging, I saw little reason to do so. Upstream is, of course,
welcome to incorporate the Makefile into the upstream source tree, but
AFAICT the upstream-recommended way of using libstb is to simply copy
individual header files into a program source tree as-needed.

-- 
Plasma



Bug#1017377: libstb: incomplete clean target

2022-09-27 Thread Boyuan Yang
X-Debbugs-CC: davidp...@librem.one

Hi,

On Mon, 15 Aug 2022 00:54:23 -0500 "David (Plasma) Paul"
 wrote:
> Source: libstb
> Version: 0.0~git20210910.af1a5bc+ds-1
> Severity: minor
> X-Debbugs-CC: davidp...@librem.one
> 
> Dear Maintainer,
> 
> The 'clean' target for the libstb Makefile is incomplete and leaves
> behind two files, stb_c_lexer.c and stb_divide.c, generated by the
> '%.c' target.
> 
> I have prepared a patch to correct this. I will submit the patch
> momentarily once I update the changelog entry with the bug number
> created by this report.

While we will fix this issue in Debian, I am just wondering, have you
reported this issue (possibly together with the patch) to upstream project?

Thanks,
Boyuan Yang


signature.asc
Description: This is a digitally signed message part


Bug#1017377: libstb: incomplete clean target

2022-08-15 Thread David (Plasma) Paul
Source: libstb
Version: 0.0~git20210910.af1a5bc+ds-1
Severity: minor
X-Debbugs-CC: davidp...@librem.one

Dear Maintainer,

The 'clean' target for the libstb Makefile is incomplete and leaves
behind two files, stb_c_lexer.c and stb_divide.c, generated by the
'%.c' target.

I have prepared a patch to correct this. I will submit the patch
momentarily once I update the changelog entry with the bug number
created by this report.

-- 
Plasma