Bug#1018148: RFS: neo-cli/0.6.1-1 [ITP] -- digital rain simulator
I fixed the VCS fields in d/control and amended the extended description. The lintinan info about the manpage was already reported upstream by me. I think it should be good now. Thanks for taking the time to review/sponsor it. --- Matthias Geiger (werdahias)
Bug#1018148: RFS: neo-cli/0.6.1-1 [ITP] -- digital rain simulator
Hi Matthias, On Tue, 2022-09-13 at 06:12 +0200, matthias.geiger1...@tutanota.de wrote: Hi Mathias, thanks for reaching out and taking the time for a review. I fixed > all the improvements you mentioned and uploaded the new (old) > version to mentors. That's looking better. However, the Vcs- fields in d/control are still unreachable. When I try to visit "https://salsa.debian.org/werdahias/neo;, I get a not found error. It looks like the correct URL is "https://salsa.debian.org/werdahias/neo-cli;. You should update those two fields so they are correct. After that's fixed, I'd say the package would be in good shape for an upload. There's still some linitian messages that could be addressed, but they aren't highlighting anything too terrible. (You could probably fix them pretty easily and submit a patch/pull request to the upstream developer.) > Regarding cmatrix: neo supports half-japananese characters/unicode, "appearing" text like in The Matrix and 32 bit color support in addition. Thanks for that explanation. That's a good example of additional information you could put in the package's extended description as potential users would find it useful. Also, it's a good idea to always CC the bug address in your replies, especially when they are ITP/RFS bugs. Doing so allows others who might be watching the bug to stay up to date with any work that's being done on it. Mathias signature.asc Description: This is a digitally signed message part
Bug#1018148: RFS: neo-cli/0.6.1-1 [ITP] -- digital rain simulator
Hi Matthias, As part of my Debian Developer application, I reviewed your package "neo-cli" as posted on mentors.debian.net. I found a few issues that should be addressed before this package could be uploaded. While I'm not yet a DD, if you fix the following issues and no one else sponsors this package for you before I become a DD, I'd consider sponsoring it. Packaging review for neo-cli 0.6.1-1, uploaded 2022-08-25 20:36 to mentors.debian.net: * Did you see that a similar program is already included in Debian (cmatrix)? Is there something that this program does better/different/additional when compared to cmatrix? * In d/control, the section should probably be "games" or "misc", not "admin". * In d/control, the resources pointed to by the Vcs-* fields are not publicly viewable; please fix permissions as needed and/or correct the URLs. * d/copyright has errors that will cause a REJECT by ftpmaster: - You list the license as GPL-3, but the license text is for GPL-2+ - Looking at the source files, the license seems to be GPL-3+, although that conflicts with what's stated in the README.md file. You should ask the upstream developer if README.md should also state "GNU GPL v3+". In either case, make sure d/copyright is updated correctly. - The upstream copyright should be "2021 Stewart Reive" to match what is in the source code. I don't know where the email address that's currently listed (3587451+s...@users.noreply.github.com) came from, as it doesn't appear anywhere in the upstream code. * Running linitian reports some "info" level messages -- have you looked at resolving those before upload? Mathias signature.asc Description: This is a digitally signed message part
