Bug#1019577: hokey lint: "Non-exhaustive patterns in function getSecretKey" when sending a secret key instead of certificate

2022-09-13 Thread Clint Adams
On Tue, Sep 13, 2022 at 03:02:14AM -0400, Daniel Kahn Gillmor wrote:
> I was "hokey lint"ing the attached binary-formatted secret key, which
> was provided by Justus Winter for use with the notmuch test suite:

Looks like parsing of Ed25519 secret keys hasn't been implemented
in hOpenPGP yet and that is the cause of the failure.



Bug#1019577: hokey lint: "Non-exhaustive patterns in function getSecretKey" when sending a secret key instead of certificate

2022-09-13 Thread Daniel Kahn Gillmor
On Mon 2022-09-12 13:52:50 +, Clint Adams wrote:
> On Sun, Sep 11, 2022 at 01:02:33PM -0400, Daniel Kahn Gillmor wrote:
>> I think what it's trying to say is "hokey lint only works on OpenPGP
>> certificates, not secret keys".  But this is a pretty awkward way to say
>> it.
>
> That is not what it is saying.  If you have the hOpenPGP source code handy,
> you should receive reasonable output from something like
>
> hokey lint 
> What is the nature of the input you're providing?

Thanks for the quick response, Clint!

I was "hokey lint"ing the attached binary-formatted secret key, which
was provided by Justus Winter for use with the notmuch test suite:

   
https://nmbug.notmuchmail.org/nmweb/show/20220909161354.715326-1-justus%40sequoia-pgp.org

I'd be happy to try to get more info out of Justus if that would be
useful.

--dkg



openpgp4-secret-key.bin
Description: test OpenPGP secret key


signature.asc
Description: PGP signature


Bug#1019577: hokey lint: "Non-exhaustive patterns in function getSecretKey" when sending a secret key instead of certificate

2022-09-12 Thread Clint Adams
On Sun, Sep 11, 2022 at 01:02:33PM -0400, Daniel Kahn Gillmor wrote:
> I think what it's trying to say is "hokey lint only works on OpenPGP
> certificates, not secret keys".  But this is a pretty awkward way to say
> it.

That is not what it is saying.  If you have the hOpenPGP source code handy,
you should receive reasonable output from something like

hokey lint 

Bug#1019577: hokey lint: "Non-exhaustive patterns in function getSecretKey" when sending a secret key instead of certificate

2022-09-12 Thread Daniel Kahn Gillmor
Package: hopenpgp-tools
Version: 0.23.7-1

When i send an OpenPGP secret key to "hokey lint", i see this warning:

hokey: Codec/Encryption/OpenPGP/Serialize.hs:(986,1)-(1015,77): Non-exhaustive 
patterns in function getSecretKey

I think what it's trying to say is "hokey lint only works on OpenPGP
certificates, not secret keys".  But this is a pretty awkward way to say
it.

Alternately, "hokey lint" could just convert the secret key to a public
key and do the linting anyway.

Thanks for maintaining hopenpgp-tools!

--dkg


signature.asc
Description: PGP signature