Bug#1019688: unace FTCBFS: uses the build architecture compiler

[Guillem Jover]

Hi!

On Sun, 2022-09-11 at 12:29:41 +0200, Helmut Grohne wrote:
> Source: unace
> Version: 1.2b-21
> Tags: patch
> User: debian-cr...@lists.debian.org
> Usertags: ftcbfs

> your -21 upload broke cross building by adding CC=$(CC) without
> initializing $(CC) properly. As far as I understand it, you deliberately
> added it to override the upstream choice (e.g. for supporting clang
> builds). Unfortunately, you failed to add proper initialization.
> Possibly, you thought that buildtools.mk was part of default.mk so that
> was sufficient, but it is not as of today.

Cannot recall what was the train of thought there TBH. :/

> Please either include it or
> change default.mk in dpkg. I'm attaching a patch for the former for your
> convenience.

I'm afraid the builtools.mk was not added to default.mk on purpose, to
avoid breakage. I've now added this commit to the dpkg-build-api
branch and to the spec on the wiki:

  
https://git.hadrons.org/cgit/debian/dpkg/dpkg.git/commit/?h=pu/perl-Dpkg-BuildAPI=cddecf191ed4c50536b625e4e370d733b083bf54

In any case, thanks! I've merged your patch and I'm uploading a fixed
package right away.

[ Would be nice to have cross building status on DDPO or the UDD
  dashboard, as that's the main reason I've missed this. :/ ]

Regards,
Guillem

Bug#1019688: unace FTCBFS: uses the build architecture compiler

[Helmut Grohne]

Source: unace
Version: 1.2b-21
Tags: patch
User: debian-cr...@lists.debian.org
Usertags: ftcbfs

Hi Guillem,

your -21 upload broke cross building by adding CC=$(CC) without
initializing $(CC) properly. As far as I understand it, you deliberately
added it to override the upstream choice (e.g. for supporting clang
builds). Unfortunately, you failed to add proper initialization.
Possibly, you thought that buildtools.mk was part of default.mk so that
was sufficient, but it is not as of today. Please either include it or
change default.mk in dpkg. I'm attaching a patch for the former for your
convenience.

Helmut
diff --minimal -Nru unace-1.2b/debian/changelog unace-1.2b/debian/changelog
--- unace-1.2b/debian/changelog 2022-08-18 11:28:43.0 +0200
+++ unace-1.2b/debian/changelog 2022-09-11 12:22:32.0 +0200
@@ -1,3 +1,10 @@
+unace (1.2b-21.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix FTCBFS: Let dpkg's buildtools.mk initialize CC. (Closes: #-1)
+
+ -- Helmut Grohne   Sun, 11 Sep 2022 12:22:32 +0200
+
 unace (1.2b-21) unstable; urgency=medium
 
   * Fix out of bounds read for .ace header comment. (Closes: #785377)
diff --minimal -Nru unace-1.2b/debian/rules unace-1.2b/debian/rules
--- unace-1.2b/debian/rules 2022-08-18 11:25:31.0 +0200
+++ unace-1.2b/debian/rules 2022-09-11 12:22:31.0 +0200
@@ -8,6 +8,7 @@
 export DEB_CFLAGS_MAINT_APPEND = -Wall
 
 include /usr/share/dpkg/default.mk
+include /usr/share/dpkg/buildtools.mk
 
 ifeq ($(DEB_HOST_ARCH_ENDIAN),little)
 DEB_CPPFLAGS_MAINT_APPEND += -DLO_HI_BYTE_ORDER