Bug#1019790: eviacam: diff for NMU version 2.1.4-2.1
On Sat, Jan 14, 2023 at 12:07:21AM +0100, Bastian Germann wrote: > I have just tested the patch and uploaded it as-is as NMU to DELAYED/10. Thanks for the testing. I'm not super happy that you've uploaded an NMU that appears to have been done by me though: https://ftp-master.debian.org/deferred/eviacam_2.1.4-2.1_source.changes I did provide a candidate patch, but I'm not able to provide follow up support for your NMU because eviacam doesn't even start up with the webcam I have access to. All I can do is forward any follow up I get about it to you, which just seems to be creating an unnecessary job for me. Cheers, Olly
Bug#1019790: eviacam: diff for NMU version 2.1.4-2.1
On Thu, 5 Jan 2023 09:43:48 +1300 Olly Betts wrote: I can't test the patch I attached earlier due to the other bug. If that bug is specific to some webcams/systems I could NMU the patch without testing if you think that's useful (let me know). I'm hesitant to try applying the PR too as I'm not at all familiar with this package, - it seems better for the maintainer to do that. I have just tested the patch and uploaded it as-is as NMU to DELAYED/10.
Bug#1019790: eviacam: diff for NMU version 2.1.4-2.1
On Wed, Nov 09, 2022 at 11:44:29PM +, Olly Betts wrote: > On Wed, Nov 09, 2022 at 04:49:33PM +0100, Cesar Mauri wrote: > > I've just merged a PR that add support for OpenCV 4.6.0 and (hopefully) > > fixes the camera error > > > > https://github.com/cmauri/eviacam/tree/master > > Great. Will there be a new upstream release soon? Just a friendly note to highlight that eviacam needs updating to wxwidgets3.2 to re-enter testing, and the release freeze cut-off for re-entering testing is 2023-02-12: https://release.debian.org/testing/freeze_policy.html#summary I think a package needs to actually *migrate* by that cut-off date, so the upload deadline is really 2/5/10 days earlier depending on whether there are autopkgtests, etc. Best to upload well before that if possible as there can be delays, especially if some other maintainers are frantically uploading to try to get in before the freeze. I can't test the patch I attached earlier due to the other bug. If that bug is specific to some webcams/systems I could NMU the patch without testing if you think that's useful (let me know). I'm hesitant to try applying the PR too as I'm not at all familiar with this package, - it seems better for the maintainer to do that. Cheers, Olly
Bug#1019790: eviacam: diff for NMU version 2.1.4-2.1
On Wed, Nov 09, 2022 at 04:49:33PM +0100, Cesar Mauri wrote: > I've just merged a PR that add support for OpenCV 4.6.0 and (hopefully) > fixes the camera error > > https://github.com/cmauri/eviacam/tree/master Great. Will there be a new upstream release soon? Cheers, Olly
Bug#1019790: eviacam: diff for NMU version 2.1.4-2.1
Hi Olly I've just merged a PR that add support for OpenCV 4.6.0 and (hopefully) fixes the camera error https://github.com/cmauri/eviacam/tree/master Thanks On Tue, Nov 8, 2022 at 10:36 PM Olly Betts wrote: > Control: tags 1019790 + patch > > Dear maintainer, > > I've managed to build eviacam using wxwidgets3.2 with a couple of minor > changes (patch attached). > > However I can't test my patched build because eviacam doesn't start > (I'm guessing it doesn't like my webcam for some reason) - starting it I > get: > > $ eviacam > [ERROR:0@0.016] global ./modules/core/src/persistence.cpp (505) open > Can't open file: '/usr/share/eviacam/haarcascade_frontalface_default.xml' > in read mode > [ERROR:0@0.017] global ./modules/core/src/persistence.cpp (505) open > Can't open file: > '/usr/share/opencv/haarcascades/haarcascade_frontalface_default.xml' in > read mode > [ERROR:0@0.017] global ./modules/core/src/persistence.cpp (505) open > Can't open file: > '/usr/share/OpenCV/haarcascades/haarcascade_frontalface_default.xml' in > read mode > [libwebcam] Invalid V4L2 control type encountered: ctrl_id = 0x00980001, > name = 'User Controls', type = 6 > [libwebcam] Invalid or unsupported V4L2 control encountered: ctrl_id = > 0x00980001, name = 'User Controls' > [libwebcam] Invalid V4L2 control type encountered: ctrl_id = 0x009A0001, > name = 'Camera Controls', type = 6 > [libwebcam] Invalid or unsupported V4L2 control encountered: ctrl_id = > 0x009A0001, name = 'Camera Controls' > > (eviacam:184091): Gtk-CRITICAL **: 10:24:53.628: > gtk_box_gadget_distribute: assertion 'size >= 0' failed in GtkScrollbar > [ WARN:0@3.768] global ./modules/videoio/src/videoio_c.cpp (15) > cvCreateCameraCapture cvCreateCameraCapture doesn't support legacy API > anymore. > $ > > I also get the same error for the version already in unstable. > > Please can you test with my patch, and upload if it works. > > Cheers, > Olly >
Bug#1019790: eviacam: diff for NMU version 2.1.4-2.1
Control: tags 1019790 + patch
Dear maintainer,
I've managed to build eviacam using wxwidgets3.2 with a couple of minor
changes (patch attached).
However I can't test my patched build because eviacam doesn't start
(I'm guessing it doesn't like my webcam for some reason) - starting it I
get:
$ eviacam
[ERROR:0@0.016] global ./modules/core/src/persistence.cpp (505) open Can't open
file: '/usr/share/eviacam/haarcascade_frontalface_default.xml' in read mode
[ERROR:0@0.017] global ./modules/core/src/persistence.cpp (505) open Can't open
file: '/usr/share/opencv/haarcascades/haarcascade_frontalface_default.xml' in
read mode
[ERROR:0@0.017] global ./modules/core/src/persistence.cpp (505) open Can't open
file: '/usr/share/OpenCV/haarcascades/haarcascade_frontalface_default.xml' in
read mode
[libwebcam] Invalid V4L2 control type encountered: ctrl_id = 0x00980001, name =
'User Controls', type = 6
[libwebcam] Invalid or unsupported V4L2 control encountered: ctrl_id =
0x00980001, name = 'User Controls'
[libwebcam] Invalid V4L2 control type encountered: ctrl_id = 0x009A0001, name =
'Camera Controls', type = 6
[libwebcam] Invalid or unsupported V4L2 control encountered: ctrl_id =
0x009A0001, name = 'Camera Controls'
(eviacam:184091): Gtk-CRITICAL **: 10:24:53.628: gtk_box_gadget_distribute:
assertion 'size >= 0' failed in GtkScrollbar
[ WARN:0@3.768] global ./modules/videoio/src/videoio_c.cpp (15)
cvCreateCameraCapture cvCreateCameraCapture doesn't support legacy API anymore.
$
I also get the same error for the version already in unstable.
Please can you test with my patch, and upload if it works.
Cheers,
Olly
diff -Nru eviacam-2.1.4/debian/changelog eviacam-2.1.4/debian/changelog
--- eviacam-2.1.4/debian/changelog 2020-02-12 02:09:11.0 +1300
+++ eviacam-2.1.4/debian/changelog 2022-11-09 10:14:08.0 +1300
@@ -1,3 +1,11 @@
+eviacam (2.1.4-2.1) unstable; urgency=medium
+
+ * Non-maintainer upload.
+ * debian/control: Update to build with wxwidgets-3.2 (new patch
+wx3.2-compat.patch) (Closes: #1019790)
+
+ -- Olly Betts Wed, 09 Nov 2022 10:14:08 +1300
+
eviacam (2.1.4-2) unstable; urgency=medium
* Team upload
diff -Nru eviacam-2.1.4/debian/control eviacam-2.1.4/debian/control
--- eviacam-2.1.4/debian/control 2020-02-12 02:09:11.0 +1300
+++ eviacam-2.1.4/debian/control 2022-11-09 10:05:50.0 +1300
@@ -7,7 +7,7 @@
libopencv-dev (>= 2.0),
libpng-dev,
libv4l-dev,
- libwxgtk3.0-gtk3-dev,
+ libwxgtk3.2-dev,
libgtk-3-dev,
libxext-dev,
libxtst-dev,
diff -Nru eviacam-2.1.4/debian/patches/series eviacam-2.1.4/debian/patches/series
--- eviacam-2.1.4/debian/patches/series 2020-02-12 02:09:11.0 +1300
+++ eviacam-2.1.4/debian/patches/series 2022-11-09 10:14:08.0 +1300
@@ -1 +1,2 @@
new-opencv.patch
+wx3.2-compat.patch
diff -Nru eviacam-2.1.4/debian/patches/wx3.2-compat.patch eviacam-2.1.4/debian/patches/wx3.2-compat.patch
--- eviacam-2.1.4/debian/patches/wx3.2-compat.patch 1970-01-01 12:00:00.0 +1200
+++ eviacam-2.1.4/debian/patches/wx3.2-compat.patch 2022-11-09 10:14:08.0 +1300
@@ -0,0 +1,29 @@
+Description: Fixes for compatibility with wxWidgets 3.2
+Author: Olly Betts
+Bug-Debian: https://bugs.debian.org/1019790
+Forwarded: no
+Last-Update: 2022-11-08
+
+--- a/src/wviacam.cpp
b/src/wviacam.cpp
+@@ -598,7 +598,8 @@
+ case (wxLANGUAGE_SPANISH_GUATEMALA):
+ case (wxLANGUAGE_SPANISH_HONDURAS):
+ case (wxLANGUAGE_SPANISH_MEXICAN):
+- case (wxLANGUAGE_SPANISH_MODERN):
++ // Same value as wxLANGUAGE_SPANISH in wx3.2:
++ // case (wxLANGUAGE_SPANISH_MODERN):
+ case (wxLANGUAGE_SPANISH_NICARAGUA):
+ case (wxLANGUAGE_SPANISH_PANAMA):
+ case (wxLANGUAGE_SPANISH_PARAGUAY):
+--- a/src/viacamcontroller.cpp
b/src/viacamcontroller.cpp
+@@ -230,7 +230,7 @@
+
+ wxSingleChoiceDialog choiceDlg(
+ NULL, _("Choose the camera to use"), _T("Enable Viacam"), strArray,
+-(char**)NULL, wxDEFAULT_DIALOG_STYLE | wxOK | wxCANCEL | wxCENTRE);
++(void**)NULL, wxDEFAULT_DIALOG_STYLE | wxOK | wxCANCEL | wxCENTRE);
+
+ if (choiceDlg.ShowModal ()!= wxID_OK) return NULL;
+
