Bug#1020976: bash launched by fai-abort lacks job-control

2022-09-30 Thread Mike Gabriel

Hi Thomas,

On  Fr 30 Sep 2022 10:44:23 CEST, Thomas Lange wrote:


Hi Mike,

thanks for the patch. I was aware of this bug, but had no idea how to
fix it. It's now applied in 9e18159e6a8340001e03a326c46a74f80d1fca96
and will be part of FAI 6.


Nice! Thanks! Glad I could help with this.

Mike

--

DAS-NETZWERKTEAM
c\o Technik- und Ökologiezentrum Eckernförde
Mike Gabriel, Marienthaler Str. 17, 24340 Eckernförde
mobile: +49 (1520) 1976 148
landline: +49 (4351) 850 8940

GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22  0782 9AF4 6B30 2577 1B31
mail: mike.gabr...@das-netzwerkteam.de, http://das-netzwerkteam.de



pgpX6rsrU5xML.pgp
Description: Digitale PGP-Signatur


Bug#1020976: bash launched by fai-abort lacks job-control

2022-09-30 Thread Thomas Lange
Hi Mike,

thanks for the patch. I was aware of this bug, but had no idea how to
fix it. It's now applied in 9e18159e6a8340001e03a326c46a74f80d1fca96
and will be part of FAI 6.

-- 
regards Thomas



Bug#1020976: bash launched by fai-abort lacks job-control

2022-09-29 Thread Mike Gabriel

Package: fai-nfsroot
Severity: normal
Version: 5.10.3
Tags: patch

When using FAI 5.10.3 in a Debian bullseye nfsroot, I get this output  
when aborting the installation with an "exit 1" somewhere in my  
configspace:


```
[... some service starts ...]
FAI: installation aborted.
reboot with: faireboot
or after a logout
bash: cannot set terminal process group (): Inappropriate ioctl  
for device

bash: no job control in this shell
root@gateway:/#

```

Keyboard input is very delayed in this state, the shell is not usable at all.

With this patch, the bash call results in a working interactive shell:

```
diff --git a/lib/fai-abort b/lib/fai-abort
index 69ed563a..383f6e36 100755
--- a/lib/fai-abort
+++ b/lib/fai-abort
@@ -17,9 +17,10 @@ case "$1" in
 esac

 echo FAI: installation aborted.
+echo "Hit  to obtain a shell"
 echo reboot with: faireboot
 echo or after a logout
-bash
+openvt -c1 -f -w -- /bin/bash
 cd /
 umount -ar
 reboot -dfi
```

Maybe a valid change for upcoming FAI 6.0.0?


Mike





--

DAS-NETZWERKTEAM
c\o Technik- und Ökologiezentrum Eckernförde
Mike Gabriel, Marienthaler Str. 17, 24340 Eckernförde
mobile: +49 (1520) 1976 148
landline: +49 (4351) 850 8940

GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22  0782 9AF4 6B30 2577 1B31
mail: mike.gabr...@das-netzwerkteam.de, http://das-netzwerkteam.de



pgpHtWm3cylt2.pgp
Description: Digitale PGP-Signatur