Bug#1024417: kgpg FTBFS: Did not find GPGME

2022-11-25 Thread Aurélien COUDERC



Le 26 novembre 2022 06:48:56 GMT+01:00, Andreas Metzler  a 
écrit :
>On 2022-11-25 Aurélien COUDERC  wrote:
>[...]
>> I tried applying the patch on top of upstream 22.08.3 and the build still 
>> fails. [0]
>
>> Ideas welcome, I won't have the time to analyse the issue any further.
>
>Good morning,
>
>adding pkg-config to Build-Depends works for me.

Obviously…


Thank you. 



Bug#1024417: kgpg FTBFS: Did not find GPGME

2022-11-25 Thread Andreas Metzler
On 2022-11-25 Aurélien COUDERC  wrote:
[...]
> I tried applying the patch on top of upstream 22.08.3 and the build still 
> fails. [0]

> Ideas welcome, I won't have the time to analyse the issue any further.

Good morning,

adding pkg-config to Build-Depends works for me.

cu Andreas
-- 
`What a good friend you are to him, Dr. Maturin. His other friends are
so grateful to you.'
`I sew his ears on from time to time, sure'



Bug#1024417: kgpg FTBFS: Did not find GPGME

2022-11-25 Thread Aurélien COUDERC



Le 25 novembre 2022 18:36:49 GMT+01:00, Andreas Metzler  a 
écrit :
>On 2022-11-23 Daniel Kahn Gillmor  wrote:
>> On Wed 2022-11-23 16:27:43 +0100, Andreas Metzler wrote:
>>> Unless kgpg maintainers/upstream has a strong opinion against using
>>> pkg-config the obvious choice would be to drop cmake/FindGpgme.cmake
>>> and simply use FindPkgConfig. - Attached patch seems to work for me,
>>> i.e. build including dh_auto_test works.
>
>> Thanks for this, Andreas.
>
>> I've proposed this change upstream as well at
>> https://invent.kde.org/utilities/kgpg/-/merge_requests/18
>
>Great, with a little bit of luck we should be able to work out a fix
>that is acceptable for all/most cmake-cases.

I tried applying the patch on top of upstream 22.08.3 and the build still 
fails. [0]

Ideas welcome, I won't have the time to analyse the issue any further.

[0] https://salsa.debian.org/qt-kde-team/kde/kgpg/-/jobs/3571722


Haply hacking,
--
Aurélien



Bug#1024417: kgpg FTBFS: Did not find GPGME

2022-11-25 Thread Andreas Metzler
On 2022-11-23 Daniel Kahn Gillmor  wrote:
> On Wed 2022-11-23 16:27:43 +0100, Andreas Metzler wrote:
>> Unless kgpg maintainers/upstream has a strong opinion against using
>> pkg-config the obvious choice would be to drop cmake/FindGpgme.cmake
>> and simply use FindPkgConfig. - Attached patch seems to work for me,
>> i.e. build including dh_auto_test works.

> Thanks for this, Andreas.

> I've proposed this change upstream as well at
> https://invent.kde.org/utilities/kgpg/-/merge_requests/18

Great, with a little bit of luck we should be able to work out a fix
that is acceptable for all/most cmake-cases.

cu Andreas
-- 
`What a good friend you are to him, Dr. Maturin. His other friends are
so grateful to you.'
`I sew his ears on from time to time, sure'



Bug#1024417: [pkg-gnupg-maint] Bug#1024417: kgpg FTBFS: Did not find GPGME

2022-11-24 Thread Sune Stolborg Vuorela
On Wed, 23 Nov 2022 15:42:31 -0500 Daniel Kahn Gillmor 
 wrote:

> On Wed 2022-11-23 16:27:43 +0100, Andreas Metzler wrote:
> > Unless kgpg maintainers/upstream has a strong opinion against using
> > pkg-config the obvious choice would be to drop cmake/FindGpgme.cmake
> > and simply use FindPkgConfig. - Attached patch seems to work for me,
> > i.e. build including dh_auto_test works.
>
> Thanks for this, Andreas.
>
> I've proposed this change upstream as well at
> https://invent.kde.org/utilities/kgpg/-/merge_requests/18


I think that this is a great debian stop gap measure, but due to 
upstream also supporting windows, the Good Fix[tm] should go into 
FindGpgme.cmake instead,


but could be derived from pkgconfig there.


/Sune



Bug#1024417: [pkg-gnupg-maint] Bug#1024417: kgpg FTBFS: Did not find GPGME

2022-11-23 Thread Daniel Kahn Gillmor
On Wed 2022-11-23 16:27:43 +0100, Andreas Metzler wrote:
> Unless kgpg maintainers/upstream has a strong opinion against using
> pkg-config the obvious choice would be to drop cmake/FindGpgme.cmake
> and simply use FindPkgConfig. - Attached patch seems to work for me,
> i.e. build including dh_auto_test works.

Thanks for this, Andreas.

I've proposed this change upstream as well at
https://invent.kde.org/utilities/kgpg/-/merge_requests/18

--dkg


signature.asc
Description: PGP signature


Bug#1024417: kgpg FTBFS: Did not find GPGME

2022-11-23 Thread Andreas Metzler
On 2022-11-19 Helmut Grohne  wrote:
[...]
> kgpg fails to build from source in unstable. The relevant portion is:

> | -- No usable gpgme flavors found.
[...]
> I think this is due to gpgme having dropped its gpgme-config tool in
> favour of providing a .pc file. I think the change is good in principle,
> but the transition is executed in a bad way. gpgme-config was always
> difficult for cross compilation while .pc just works.

> In any case, this puts kgpg into a difficult spot. I hope you can deal
> with it somehow. I've put the gpgme maintainers in the loop for
> assistance.

Hello,

Unless kgpg maintainers/upstream has a strong opinion against using
pkg-config the obvious choice would be to drop cmake/FindGpgme.cmake
and simply use FindPkgConfig. - Attached patch seems to work for me,
i.e. build including dh_auto_test works.

cu Andreas
-- 
`What a good friend you are to him, Dr. Maturin. His other friends are
so grateful to you.'
`I sew his ears on from time to time, sure'
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -21,10 +21,11 @@
 include(ECMInstallIcons)
 include(FeatureSummary)
 include(ECMSetupVersion)
 include(CMakeFindDependencyMacro)
 include(ECMQtDeclareLoggingCategory)
+include(FindPkgConfig)
 
 find_package(Qt5 ${QT_MIN_VERSION} CONFIG REQUIRED COMPONENTS
   Core
   DBus
   Gui
@@ -56,11 +57,11 @@
   AkonadiContact
   Contacts
 )
 
 # only headers are used
-find_package(Gpgme REQUIRED)
+pkg_search_module(GPGME REQUIRED gpgme)
 
 add_definitions(
 #-DQT_DISABLE_DEPRECATED_BEFORE=0x050f00
 -DQT_DEPRECATED_WARNINGS_SINCE=0x06
 -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x055200


Bug#1024417: kgpg FTBFS: Did not find GPGME

2022-11-19 Thread Helmut Grohne
Source: kgpg
Version: 4:22.04-2.2
Severity: serious
Tags: ftbfs
X-Debbugs-Cc: Debian GnuPG Maintainers 

kgpg fails to build from source in unstable. The relevant portion is:

| -- No usable gpgme flavors found.
| CMake Error at cmake/FindGpgme.cmake:367 (message):
|   Did not find GPGME
| Call Stack (most recent call first):
|   CMakeLists.txt:61 (find_package)
| 
| 
| -- Configuring incomplete, errors occurred!

I think this is due to gpgme having dropped its gpgme-config tool in
favour of providing a .pc file. I think the change is good in principle,
but the transition is executed in a bad way. gpgme-config was always
difficult for cross compilation while .pc just works.

In any case, this puts kgpg into a difficult spot. I hope you can deal
with it somehow. I've put the gpgme maintainers in the loop for
assistance.

Helmut