Bug#1025420: exim4: ${run}expansion fail Bug stiill open [TT#2568022]

2023-10-26 Thread SerNet Support Kevin Ivory

oh, well, thanks for analysing that.
Sorry, I didn't notice the change myself.

Am 25.10.23 um 16:24 schrieb Andreas Metzler:

On 2023-10-23 SerNet Support Kevin Ivory  wrote:
[...]

That binary does not fix the problem of quote with space included:



# /usr/sbin/exim4 -be '${run{/usr/bin/echo ${quote:hello world}}}'
Failed: Expansion of "${quote:hello" from command "/usr/bin/echo ${quote:hello 
world}" in ${run} expansion failed: missing } at end of string

[...]

${run expansion changed in 4.96:
"If the option preexpand is not used, the command string is split into
individual arguments by spaces and then each argument is expanded."

i.e.
 /usr/bin/echo ${quote:hello world}
is split into
 /usr/bin/echo
 ${quote:hello
 world}
and the second string yields an expansion error.
Use
/usr/sbin/exim4 -be '${run,preexpand{/usr/bin/echo ${quote:hello world}}}'
to get the old behavior.


Beste Grüße
Kevin Ivory (SerNet Support)
--
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: 0551-37-0, mailto:kont...@sernet.de
Gesch.F.: Dr. Johannes Loxen und Reinhild Jung
AG Göttingen: HR-B 2816 - http://www.sernet.de
Datenschutz: https://www.sernet.de/datenschutz

Besuchen Sie den SerNet Stammtisch
Nächster Termin, Infos & Anmeldung
unter https://sernet.de/stammtisch



Bug#1025420: exim4: ${run}expansion fail Bug stiill open [TT#2568022]

2023-10-25 Thread Andreas Metzler
On 2023-10-23 SerNet Support Kevin Ivory  wrote:
[...]
> That binary does not fix the problem of quote with space included:

> # /usr/sbin/exim4 -be '${run{/usr/bin/echo ${quote:hello world}}}'
> Failed: Expansion of "${quote:hello" from command "/usr/bin/echo 
> ${quote:hello world}" in ${run} expansion failed: missing } at end of string
[...]

${run expansion changed in 4.96:
"If the option preexpand is not used, the command string is split into
individual arguments by spaces and then each argument is expanded."

i.e.
/usr/bin/echo ${quote:hello world}
is split into
/usr/bin/echo
${quote:hello
world}
and the second string yields an expansion error.
Use
/usr/sbin/exim4 -be '${run,preexpand{/usr/bin/echo ${quote:hello world}}}'
to get the old behavior.

cu Andreas



Bug#1025420: exim4: ${run}expansion fail Bug stiill open [TT#2568022]

2023-10-23 Thread SerNet Support Kevin Ivory

Hi Andreas,

I installed the package
https://people.debian.org/~ametzler/tmp/exim4-daemon-heavy_4.96-15+deb12u2+almostu3_amd64.deb

The binary /usr/sbin/exim4 inside is from Sept 3rd:
-rwsr-xr-x 1 root root 1575384 2023-09-03 13:34 /usr/sbin/exim4

That binary does not fix the problem of quote with space included:

# /usr/sbin/exim4 -be '${run{/usr/bin/echo ${quote:hello world}}}'
Failed: Expansion of "${quote:hello" from command "/usr/bin/echo ${quote:hello 
world}" in ${run} expansion failed: missing } at end of string

Am 23.10.23 um 18:06 schrieb Andreas Metzler:

I have uploaded pre built binaries to
https://people.debian.org/~ametzler/tmp/


Best regards
Kevin Ivory (SerNet Support)
--
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: 0551-37-0, mailto:kont...@sernet.de
Gesch.F.: Dr. Johannes Loxen and Reinhild Jung
AG Göttingen: HR-B 2816 - http://www.sernet.de
Datenschutz: https://www.sernet.de/datenschutz



Bug#1025420: exim4: ${run}expansion fail Bug stiill open [TT#2568022]

2023-10-23 Thread Andreas Metzler
On 2023-10-23 SerNet Support Kevin Ivory  wrote:
> Hello Andreas,

> thanks for the info.
> I am not familiar with the Repository format at
> https://salsa.debian.org/exim-team/exim4/-/tree/12_bookworm?ref_type=heads

> Is there a binary or a package that I can test or do
> I have to patch and compile?
[...]

Hello,

It is a webpage. ;-) Standard gitlab-ish GIT WWW frontend, pointed at
the correct branch.

I have uploaded pre built binaries to
https://people.debian.org/~ametzler/tmp/

TIA, cu Andreas



Bug#1025420: exim4: ${run}expansion fail Bug stiill open [TT#2568022]

2023-10-23 Thread SerNet Support Kevin Ivory

Hello Andreas,

thanks for the info.
I am not familiar with the Repository format at
https://salsa.debian.org/exim-team/exim4/-/tree/12_bookworm?ref_type=heads

Is there a binary or a package that I can test or do
I have to patch and compile?

Am 23.10.23 um 14:29 schrieb Andreas Metzler:

On 2023-10-18 SerNet Support Kevin Ivory  wrote:

Hello Andreas,



I just realized Debian Bug #1025420 is closed even though
we are still running into it in exim 4.96-15+deb12u2



Please try:



# /usr/sbin/exim4 -be '${run{/usr/bin/echo ${quote:hello world}}}'
Failed: Expansion of "${quote:hello" from command "/usr/bin/echo ${quote:hello 
world}" in ${run} expansion failed: missing } at end of string



The bug is only fixed for exactly the version in the bug
report, variables with no space included. We need to use
${quote:$h_subject:} where the subject often includes
spaces.


Hello,

Yes, I now that. I had a stable update pending for the latest point
release but I pulled it because there needed to be DSA for CVE-2023-42114,
CVE-2023-42115, CVE-2023-42116 at basically the same time.

I would appreciate if you could check whether
https://salsa.debian.org/exim-team/exim4/-/tree/12_bookworm?ref_type=heads
works for you.

cu Andreas


Best regards
Kevin Ivory (SerNet Support)
--
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: 0551-37-0, mailto:kont...@sernet.de
Gesch.F.: Dr. Johannes Loxen and Reinhild Jung
AG Göttingen: HR-B 2816 - http://www.sernet.de
Datenschutz: https://www.sernet.de/datenschutz



Bug#1025420: exim4: ${run}expansion fail Bug stiill open [TT#2568022]

2023-10-23 Thread Andreas Metzler
On 2023-10-18 SerNet Support Kevin Ivory  wrote:
> Hello Andreas,

> I just realized Debian Bug #1025420 is closed even though
> we are still running into it in exim 4.96-15+deb12u2

> Please try:

> # /usr/sbin/exim4 -be '${run{/usr/bin/echo ${quote:hello world}}}'
> Failed: Expansion of "${quote:hello" from command "/usr/bin/echo 
> ${quote:hello world}" in ${run} expansion failed: missing } at end of string

> The bug is only fixed for exactly the version in the bug
> report, variables with no space included. We need to use
> ${quote:$h_subject:} where the subject often includes
> spaces.

Hello,

Yes, I now that. I had a stable update pending for the latest point
release but I pulled it because there needed to be DSA for CVE-2023-42114,
CVE-2023-42115, CVE-2023-42116 at basically the same time.

I would appreciate if you could check whether
https://salsa.debian.org/exim-team/exim4/-/tree/12_bookworm?ref_type=heads
works for you.

cu Andreas
-- 
`What a good friend you are to him, Dr. Maturin. His other friends are
so grateful to you.'
`I sew his ears on from time to time, sure'



Bug#1025420: exim4: ${run} expansion fail

2022-12-04 Thread Andreas Metzler
On 2022-12-04 Slavko  wrote:
> Package: exim4
> Version: 4.96-9

> Hi,

> yesterday (3.12.2022) discussion on exim's ML shows bug in ${run}
> expansion, which fails if there is another expansion, eg (not very
> useful, but shows problem):

> exim -be '${run{/usr/bin/echo ${quote:aaa}}}'
> Failed: Expansion of "${quote:aaa" from command "/usr/bin/echo
>   ${quote:aaa" in ${run} expansion failed: missing } at end of string

> (note missing "}" after quote...)

> It is already fixed, perhaps worth to include it, just in case that new
> version will not be released until next stable, see:

> https://github.com/Exim/exim/commit/44b6e099b76f403a55e77650821f8a69e9d2682e

Thanks for the heads-up. Sadly the fix from master does not apply
directly to 4.96 due to some rework ("Args count reduction in expansions
coding").

cu Andreas