Bug#1027871: evdi: please switch to B-D: dh-sequence-dkms (or dh-dkms)

2023-01-20 Thread Andreas Beckmann
Followup-For: Bug #1027871
Control: tag -1 patch pending

Hi,

I've prepared a NMU and uploaded it to DELAYED/10. Please let me know if
I should delay it longer or cancel it.


Andreas
diff -Nru evdi-1.12.0+dfsg/debian/changelog evdi-1.12.0+dfsg/debian/changelog
--- evdi-1.12.0+dfsg/debian/changelog   2022-11-01 16:56:26.0 +0100
+++ evdi-1.12.0+dfsg/debian/changelog   2023-01-20 18:37:23.0 +0100
@@ -1,3 +1,12 @@
+evdi (1.12.0+dfsg-0.2) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Switch to dh-sequence-dkms.  (Closes: #1027871)
+  * Switch to Testsuite: autopkgtest-pkg-dkms.
+  * Do not build the module for kernels without CONFIG_I2C.
+
+ -- Andreas Beckmann   Fri, 20 Jan 2023 18:37:23 +0100
+
 evdi (1.12.0+dfsg-0.1) unstable; urgency=medium
 
   * Non-maintainer upload.
diff -Nru evdi-1.12.0+dfsg/debian/control evdi-1.12.0+dfsg/debian/control
--- evdi-1.12.0+dfsg/debian/control 2022-11-01 16:56:26.0 +0100
+++ evdi-1.12.0+dfsg/debian/control 2023-01-20 18:24:04.0 +0100
@@ -2,12 +2,17 @@
 Section: misc
 Priority: optional
 Maintainer: Hanno Stock 
-Build-Depends: debhelper-compat (= 13), dh-dkms, dkms, dh-exec, libdrm-dev
+Build-Depends:
+ debhelper-compat (= 13),
+ dh-sequence-dkms,
+ dh-exec,
+ libdrm-dev,
 Standards-Version: 4.5.0
 Rules-Requires-Root: no
 Homepage: https://github.com/DisplayLink/evdi
 Vcs-Browser: https://salsa.debian.org/hansto-guest/evdi
 Vcs-Git: https://salsa.debian.org/hansto-guest/evdi.git
+Testsuite: autopkgtest-pkg-dkms
 
 Package: evdi-dkms
 Architecture: all
diff -Nru evdi-1.12.0+dfsg/debian/evdi-dkms.dkms 
evdi-1.12.0+dfsg/debian/evdi-dkms.dkms
--- evdi-1.12.0+dfsg/debian/evdi-dkms.dkms  2022-11-01 16:54:13.0 
+0100
+++ evdi-1.12.0+dfsg/debian/evdi-dkms.dkms  2023-01-20 18:34:37.0 
+0100
@@ -9,6 +9,7 @@
 PACKAGE_NAME="evdi"
 PACKAGE_VERSION="#MODULE_VERSION#"
 AUTOINSTALL=yes
+BUILD_EXCLUSIVE_CONFIG="CONFIG_I2C"
 
 MAKE[0]="make -C ${kernel_source_dir} 
M=${dkms_tree}/${PACKAGE_NAME}/${PACKAGE_VERSION}/build DKMS_BUILD=1"
 DEST_MODULE_LOCATION[0]="/kernel/drivers/gpu/drm/evdi"
diff -Nru evdi-1.12.0+dfsg/debian/rules evdi-1.12.0+dfsg/debian/rules
--- evdi-1.12.0+dfsg/debian/rules   2022-11-01 16:54:13.0 +0100
+++ evdi-1.12.0+dfsg/debian/rules   2023-01-20 18:20:52.0 +0100
@@ -7,7 +7,7 @@
 export DEB_BUILD_MAINT_OPTIONS=hardening=+bindnow
 
 %:
-   dh $@ --with dkms
+   dh $@
 
 override_dh_auto_install:
dh_install -p evdi-dkms -XLICENSE module/* 
usr/src/evdi-$(DEB_VERSION_UPSTREAM)/
diff -Nru evdi-1.12.0+dfsg/debian/source/lintian-overrides 
evdi-1.12.0+dfsg/debian/source/lintian-overrides
--- evdi-1.12.0+dfsg/debian/source/lintian-overrides2022-11-01 
16:54:13.0 +0100
+++ evdi-1.12.0+dfsg/debian/source/lintian-overrides2023-01-20 
18:27:15.0 +0100
@@ -2,4 +2,4 @@
 # the shared library
 dh-exec-subst-unknown-variable
 # Upstream does not provide signatures
-debian-watch-does-not-check-gpg-signature
+debian-watch-does-not-check-openpgp-signature
diff -Nru evdi-1.12.0+dfsg/debian/tests/control 
evdi-1.12.0+dfsg/debian/tests/control
--- evdi-1.12.0+dfsg/debian/tests/control   2022-11-01 16:54:13.0 
+0100
+++ evdi-1.12.0+dfsg/debian/tests/control   1970-01-01 01:00:00.0 
+0100
@@ -1,3 +0,0 @@
-Tests: dkms-build
-Restrictions: needs-root, allow-stderr, isolation-machine
-Depends: @, dkms
diff -Nru evdi-1.12.0+dfsg/debian/tests/dkms-build 
evdi-1.12.0+dfsg/debian/tests/dkms-build
--- evdi-1.12.0+dfsg/debian/tests/dkms-build2022-11-01 16:54:13.0 
+0100
+++ evdi-1.12.0+dfsg/debian/tests/dkms-build1970-01-01 01:00:00.0 
+0100
@@ -1,5 +0,0 @@
-#!/bin/sh
-export DEBIAN_FRONTEND=noninteractive
-KVER=$(uname -r)
-apt-get install -y "linux-headers-$KVER"
-/usr/lib/dkms/dkms-autopkgtest


Bug#1027871: evdi: please switch to B-D: dh-sequence-dkms (or dh-dkms)

2023-01-04 Thread Andreas Beckmann
Source: evdi
Version: 1.12.0+dfsg-0.1
Severity: important

Hi,

please switch the Build-Depends of your package from `dkms` to `dh-dkms`
or (preferrably) `dh-sequence-dkms`.
With the latter you can also drop the `--with dkms` argument to `dh`.

Please consider adding
  Testsuite: autopkgtest-pkg-dkms
to the source stanza in debian/control s.t. the module gets build-tested
against any new kernel version in the archive and breakage is noticed
quickly.

If you have questions or need help for disabling the module build on
unsupported architectures/configurations (that may be exposed when
enabling the autopkgtest), don't hesitate to contact me.


Thanks

Andreas