Bug#1031122: debhelper: strip trailing white space in d/changelog

2023-02-13 Thread Martin-Éric Racine
On Mon, Feb 13, 2023 at 2:22 PM Holger Levsen  wrote:
> On Sun, Feb 12, 2023 at 07:38:31AM +0100, Axel Beckert wrote:
> > P.S.: If you're an Emacs user, just run "M-x wh-cl" when editing
> > debian/changelog and you're done.

Nano has a similar option, but it only seems to take effect if a line
gets cut due to auto-formatting i.e. it's not enforced at every save
in a systematic way.

> also we have the Debian janitor now, which fixes these things for you,
> if you let them. :)

That only works for Git-maintained packages. For some packages,
Git-maintenance would be overkill.

Martin-Éric



Bug#1031122: debhelper: strip trailing white space in d/changelog

2023-02-13 Thread Martin-Éric Racine
On Sun, 12 Feb 2023 07:38:31 +0100 Axel Beckert  wrote:
> Martin-Éric Racine wrote:
> > Lintian randomly reports trailing white space in debian/changelog.
> > It would be desirable for debhelper to parse the file and strip
> > traling white space whnever found.
>
> No. debhelper does not edit files which are checked by that check
> (namely debian/changelog, debian/control and debian/rules).

dh_installchangelogs could start by stripping trailing whitespace in
the source changelog and only then copy the file to the binary
targets.

> P.S.: If you're an Emacs user, just run "M-x wh-cl" when editing
> debian/changelog and you're done.

In principle, "set trimblanks" in .nanorc accomplishes the same thing.
In practice, this only seems to work when lines are cut as the result
of text justification i.e. it doesn't trim trailing white space
unconditionally.

Martin-Éric



Bug#1031122: debhelper: strip trailing white space in d/changelog

2023-02-13 Thread Holger Levsen
On Sun, Feb 12, 2023 at 07:38:31AM +0100, Axel Beckert wrote:
> No. debhelper does not edit files which are checked by that check
> (namely debian/changelog, debian/control and debian/rules).

yup, I'd recommend to close this bug.
 
> P.S.: If you're an Emacs user, just run "M-x wh-cl" when editing
> debian/changelog and you're done.

also we have the Debian janitor now, which fixes these things for you,
if you let them. :)


-- 
cheers,
Holger

 ⢀⣴⠾⠻⢶⣦⠀
 ⣾⠁⢠⠒⠀⣿⡁  holger@(debian|reproducible-builds|layer-acht).org
 ⢿⡄⠘⠷⠚⠋⠀  OpenPGP: B8BF54137B09D35CF026FE9D 091AB856069AAA1C
 ⠈⠳⣄

The law, in its majestic equality, forbids the rich as well as the poor to
sleep under bridges, to beg in the streets, and to steal bread. (Anatole France)


signature.asc
Description: PGP signature


Bug#1031122: debhelper: strip trailing white space in d/changelog

2023-02-11 Thread Axel Beckert
Hi,

Martin-Éric Racine wrote:
> Lintian randomly reports trailing white space in debian/changelog.
> It would be desirable for debhelper to parse the file and strip
> traling white space whnever found.

No. debhelper does not edit files which are checked by that check
(namely debian/changelog, debian/control and debian/rules).

Out of those, it could fix the debian/changelog file in the resulting
binary as it fiddles around with it already anyways. But it cannot fix
it in the source package. That's the maintainer's work.

Additionally that lintian check runs against the source package, not
the binary packages. So fixing it in the binary package via debhelper
won't make that emitted tag going away.

P.S.: If you're an Emacs user, just run "M-x wh-cl" when editing
debian/changelog and you're done.

Regards, Axel
-- 
 ,''`.  |  Axel Beckert , https://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-|  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE



Bug#1031122: debhelper: strip trailing white space in d/changelog

2023-02-11 Thread Martin-Éric Racine
Package: debhelper
Version: 13.11.4
Severity: normal

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512

Lintian randomly reports trailing white space in debian/changelog. It would be 
desirable for debhelper to parse the file and strip traling white space whnever 
found.

- -- System Information:
Debian Release: bookworm/sid
  APT prefers unstable
  APT policy: (900, 'unstable')
Architecture: i386 (x86_64)

Kernel: Linux 5.10.0-21-amd64 (SMP w/4 CPU threads)
Locale: LANG=fi_FI.UTF-8, LC_CTYPE=fi_FI.UTF-8 (charmap=UTF-8), LANGUAGE=fi:en
Shell: /bin/sh linked to /usr/bin/dash
Init: unable to detect

Versions of packages debhelper depends on:
ii  autotools-dev20220109.1
ii  dh-autoreconf20
ii  dh-strip-nondeterminism  1.13.1-1
ii  dpkg 1.21.20
ii  dpkg-dev 1.21.20
ii  dwz  0.15-1
ii  file 1:5.44-3
ii  libdebhelper-perl13.11.4
ii  libdpkg-perl 1.21.20
ii  man-db   2.11.2-1
ii  perl 5.36.0-7
ii  po-debconf   1.0.21+nmu1

debhelper recommends no packages.

Versions of packages debhelper suggests:
ii  dh-make  2.202301

- -- no debconf information

-BEGIN PGP SIGNATURE-

iQIzBAEBCgAdFiEEyJACx3qL7GpObXOQrh+Cd8S017YFAmPogwIACgkQrh+Cd8S0
17bNIA//TcZ+RaAIIWQL9PGvFWS9Pi1rHtOoQ9kXG42u0oeSxLZBtxiLTA3skU/H
+X6bdNj+o//UVLojKyqQAcxhmRp285q+OaQ+Q8+BFEYydN9qUads3VQa4noxyC93
GoqwU6vEF9Ve636r6Ufjb0yPFrmfNu97cGdVjF+nHGmNkZsCqGzCLJyjbrPJMp/7
Bsco2hvVQ8pad0t7eCd8sutlp3nWTx3rsbL3N13HpQ92BNuHRm4I1xb9jwumd9OZ
GdlZZcpA56DkVa50kIzsW6bnrGWI9pr4LEgh/pZAz7m4+duf4XJ3DvG5fJLRC1TK
hmVubmNgym43QuFCd1UB8O1euk2tsQwOi6gVlqBoNgWDNdLBCPuzfD/6rDIIN/M0
2QUyo5XUoyIoSCM+X2KLU1FHLfo7SGZdhucqm/nmoIhWpSM1CdnRmpXqAnioYjle
F19cVesrO+dt+Be7k4GdY1ht0+uj2/b4TCQBz235h8TIHrbgSU12ahLIcFg/KLzq
V5oRsOtEBbng2zhbWH07GhvWklApiIEI2YSXJSXsgN/bTrodHI6aKH2W09Xjiq+z
wyoRxlR167VAZGhcxsWC6/q9eLnIzodSvOILINfa0IQo7aX8e89P9D7prBGUdiyW
E2Ch3BJLJYzKjxxULVmKIQOwjjq8Fb6z4Scy3nRX3GL09JF7BMo=
=utm/
-END PGP SIGNATURE-