Bug#1031453: sane-frontends: FTBFS: dh_install: error: missing files, aborting

2023-02-18 Thread Andreas Henriksson
Control: retitle -1 sane-frontends: FTBFS: Couldn't find SANE libraries 
(sane-backends)

Hello,

This seems to be a regression caused by the newly uploaded sane-backends.
Maybe that should get an RC bug to prevent it from going into testing!
Would probably make sense to atleast add a
Breaks: sane-fronteds (<< fixed-version)
to the new version of sane-backends.

Anyway, more about sane-frontends FTBFS below.

On Fri, Feb 17, 2023 at 08:04:01AM +0100, Lucas Nussbaum wrote:
> Source: sane-frontends
> Version: 1.0.14-16
> Severity: serious
> Justification: FTBFS
> Tags: bookworm sid ftbfs
> User: lu...@debian.org
> Usertags: ftbfs-20230216 ftbfs-bookworm
[...]
> > checking for sane-backends >= 1.0.0... yes
> > **
> > ERROR: Couldn't find SANE libraries (sane-backends). Possible reasons:
> >  - sane-backends isn't installed (install sane-backends before
> >sane-frontends)
> >  - the SANE header files aren't installed (if you installed
> >SANE as RPM make sure you also included the sane-devel RPM)
> >  - the SANE libraries can't be found because /usr/local/lib/ isn't
> >searched by the dynamic linker (see INSTALL for details)
> > **

^^ this is the actual error.
Unfontunately when this occurs the configure script exits with code 0.
https://sources.debian.org/src/sane-frontends/1.0.14-16/configure.in/#L131

It would be much better if it exited with an error code (and printed the
error messages to stderr instead of stdout while at it).

Then we wouldn't have to proceed to end up with this:

> > 
> >create-stamp debian/debhelper-build-stamp
> >dh_prep
> >dh_installdirs
> >dh_auto_install --destdir=debian/sane/
> >dh_install
> > dh_install: warning: Cannot find (any matches for) 
> > "debian/sane/usr/bin/xscanimage" (tried in ., debian/tmp)
[...]


The fix would probably be to replace ldflags with libs here (and bump
version of libsane-dev build-dep as this would not work with older
versions than the one currently in unstable):
https://sources.debian.org/src/sane-frontends/1.0.14-16/configure.in/#L117


The sane-backends.pc from unstable (1.2.1-1) has:

# grep -e ldflags= -e libs= 
/usr/lib/x86_64-linux-gnu/pkgconfig/sane-backends.pc 
libs= -ldl  -lm -ltiff -ljpeg  -lgphoto2 -lgphoto2_port -lm -lavahi-common 
-lavahi-client  -lusb-1.0   



While the sane-backends.pc currently in testing (1.1.1-6) has:

# grep -e ldflags= -e libs= usr/lib/x86_64-linux-gnu/pkgconfig/sane-backends.pc
ldflags=-Wl,-z,relro -Wl,-z,now
libs=



Regards,
Andreas Henriksson



Bug#1031453: sane-frontends: FTBFS: dh_install: error: missing files, aborting

2023-02-16 Thread Lucas Nussbaum
Source: sane-frontends
Version: 1.0.14-16
Severity: serious
Justification: FTBFS
Tags: bookworm sid ftbfs
User: lu...@debian.org
Usertags: ftbfs-20230216 ftbfs-bookworm

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.


Relevant part (hopefully):
>  debian/rules binary
> dh  binary
>dh_update_autotools_config
>dh_autoreconf
> autoreconf: warning: autoconf input should be named 'configure.ac', not 
> 'configure.in'
> aclocal: warning: autoconf input should be named 'configure.ac', not 
> 'configure.in'
> acinclude.m4:13: warning: underquoted definition of AM_PATH_GTK
> acinclude.m4:13:   run info Automake 'Extending aclocal'
> acinclude.m4:13:   or see 
> https://www.gnu.org/software/automake/manual/automake.html#Extending-aclocal
> configure.in:3: warning: The macro `AC_CONFIG_HEADER' is obsolete.
> configure.in:3: You should run autoupdate.
> ./lib/autoconf/status.m4:719: AC_CONFIG_HEADER is expanded from...
> configure.in:3: the top level
> configure.in:53: warning: The macro `AC_AIX' is obsolete.
> configure.in:53: You should run autoupdate.
> ./lib/autoconf/specific.m4:540: AC_AIX is expanded from...
> configure.in:53: the top level
> configure.in:54: warning: The macro `AC_MINIX' is obsolete.
> configure.in:54: You should run autoupdate.
> ./lib/autoconf/specific.m4:545: AC_MINIX is expanded from...
> configure.in:54: the top level
> configure.in:55: warning: The macro `AC_ISC_POSIX' is obsolete.
> configure.in:55: You should run autoupdate.
> ./lib/autoconf/specific.m4:550: AC_ISC_POSIX is expanded from...
> configure.in:55: the top level
> configure.in:56: warning: 'AM_PROG_CC_STDC': this macro is obsolete.
> configure.in:56: You should simply use the 'AC_PROG_CC' macro instead.
> configure.in:56: Also, your code should no longer depend upon 
> 'am_cv_prog_cc_stdc',
> configure.in:56: but upon 'ac_cv_prog_cc_stdc'.
> ./lib/autoconf/general.m4:2434: AC_DIAGNOSE is expanded from...
> aclocal.m4:746: AM_PROG_CC_STDC is expanded from...
> configure.in:56: the top level
> configure.in:64: warning: The macro `ac_cv_prog_gcc' is obsolete.
> configure.in:64: You should run autoupdate.
> ./lib/autoconf/c.m4:440: ac_cv_prog_gcc is expanded from...
> configure.in:64: the top level
> configure.in:77: warning: The macro `AC_HEADER_STDC' is obsolete.
> configure.in:77: You should run autoupdate.
> ./lib/autoconf/headers.m4:704: AC_HEADER_STDC is expanded from...
> configure.in:77: the top level
> configure.in:83: warning: The macro `AC_TYPE_SIGNAL' is obsolete.
> configure.in:83: You should run autoupdate.
> ./lib/autoconf/types.m4:776: AC_TYPE_SIGNAL is expanded from...
> configure.in:83: the top level
> configure.in:138: warning: The macro `AC_TRY_RUN' is obsolete.
> configure.in:138: You should run autoupdate.
> ./lib/autoconf/general.m4:2997: AC_TRY_RUN is expanded from...
> aclocal.m4:207: AM_PATH_GTK_2_0 is expanded from...
> configure.in:138: the top level
> configure.in:138: warning: The macro `AC_TRY_LINK' is obsolete.
> configure.in:138: You should run autoupdate.
> ./lib/autoconf/general.m4:2920: AC_TRY_LINK is expanded from...
> aclocal.m4:207: AM_PATH_GTK_2_0 is expanded from...
> configure.in:138: the top level
> configure.in:150: warning: The macro `AC_TRY_RUN' is obsolete.
> configure.in:150: You should run autoupdate.
> ./lib/autoconf/general.m4:2997: AC_TRY_RUN is expanded from...
> acinclude.m4:13: AM_PATH_GTK is expanded from...
> configure.in:150: the top level
> configure.in:150: warning: The macro `AC_TRY_LINK' is obsolete.
> configure.in:150: You should run autoupdate.
> ./lib/autoconf/general.m4:2920: AC_TRY_LINK is expanded from...
> acinclude.m4:13: AM_PATH_GTK is expanded from...
> configure.in:150: the top level
> configure.in:154: warning: The macro `AC_TRY_RUN' is obsolete.
> configure.in:154: You should run autoupdate.
> ./lib/autoconf/general.m4:2997: AC_TRY_RUN is expanded from...
> acinclude.m4:185: AM_PATH_GIMP is expanded from...
> configure.in:154: the top level
> configure.in:154: warning: The macro `AC_TRY_LINK' is obsolete.
> configure.in:154: You should run autoupdate.
> ./lib/autoconf/general.m4:2920: AC_TRY_LINK is expanded from...
> acinclude.m4:185: AM_PATH_GIMP is expanded from...
> configure.in:154: the top level
> configure.in:161: warning: The macro `AC_TRY_RUN' is obsolete.
> configure.in:161: You should run autoupdate.
> ./lib/autoconf/general.m4:2997: AC_TRY_RUN is expanded from...
> aclocal.m4:22: AM_PATH_GIMP_2_0 is expanded from...
> configure.in:161: the top level
> configure.in:161: warning: The macro `AC_TRY_LINK' is obsolete.
> configure.in:161: You should run autoupdate.
> ./lib/autoconf/general.m4:2920: AC_TRY_LINK is expanded from...
> aclocal.m4:22: AM_PATH_GIMP_2_0 is expanded from...
> configure.in:161: the top level
> configure.in:205: warning: AC_OUTPUT should be used without arguments.
> configure.in:205: You should run autoupdate.
> autoheader: warning: autoconf input should be named 'configure.ac',