Bug#1032418: zcfan service is not stopped on package removal

2023-04-09 Thread Chris Hofstaedtler
* Michel Alexandre Salim  [230409 09:09]:
> On Fri, 17 Mar 2023 16:01:16 +0100 Lee Garrett  wrote:
> > Debugging this issue I found that it's caused by #1031695 (a bug in 
> > dh_installsystemd). I've reduced this bug severity accordingly.

> Per our discussion in #debian-mentors we'll need to wait for the 
> dh_installsystemd issue to be fixed.

Heads-up: #1031695 in dh_installsystemd will not get fixed for bookworm.
If your package expects the functionality to work, you have to fix
this bug in your package.

Chris



Bug#1032418: zcfan service is not stopped on package removal

2023-03-17 Thread Michel Alexandre Salim
On Fri, 17 Mar 2023 16:01:16 +0100 Lee Garrett  wrote:
> Debugging this issue I found that it's caused by #1031695 (a bug in 
> dh_installsystemd). I've reduced this bug severity accordingly.
> 
>
Thanks! Also for the kind offer to help fixing this. Per our discussion in 
#debian-mentors we'll need to wait for the dh_installsystemd issue to be fixed.

zcfan is supposed to be zero-configuration, so... once dh_installsystemd does 
the right thing, I wonder if we should default this to on or off.

Thanks, 

-- 
Michel Alexandre Salim
identities: https://keyoxide.org/5dce2e7e9c3b1cffd335c1d78b229d2f7ccc04f2


signature.asc
Description: PGP signature


Bug#1032418: zcfan service is not stopped on package removal

2023-03-17 Thread Lee Garrett
Debugging this issue I found that it's caused by #1031695 (a bug in 
dh_installsystemd). I've reduced this bug severity accordingly.




Bug#1032418: zcfan service is not stopped on package removal

2023-03-06 Thread Lee Garrett
Package: zcfan
Severity: serious
X-Debbugs-Cc: deb...@rocketjump.eu

Hi,

while testing the Breaks: directive between zcfan and thinkfan, I noticed that
the zcfan service is not stopped upon uninstall. This is not caught by piuparts,
as by default the zcfan service is not started. The solution is to have a
debian/rules entry like in [0].

I noticed that you're a DM, and since it's fairly late in the freeze process,
I'm willing to guide your through the process of fixing the package for the
bookworm release.

Regards,
Lee

[0] https://salsa.debian.org/debian/thinkfan/-/blob/master/debian/rules#L24

Full terminal output showing the issue below:

12:59:18 [root@batou:~] 4s # apt install zcfan
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
The following NEW packages will be installed:
  zcfan
0 upgraded, 1 newly installed, 0 to remove and 1 not upgraded.
Need to get 0 B/8.980 B of archives.
After this operation, 36,9 kB of additional disk space will be used.
Selecting previously unselected package zcfan.
(Reading database ... 377831 files and directories currently installed.)
Preparing to unpack .../zcfan_1.2.1-1+b1_amd64.deb ...
Unpacking zcfan (1.2.1-1+b1) ...
Setting up zcfan (1.2.1-1+b1) ...
Processing triggers for man-db (2.11.2-1) ...
Scanning processes...   

   
Scanning candidates...  

   
Scanning processor microcode... 

   
Scanning linux images...

   

Running kernel seems to be up-to-date.

The processor microcode seems to be up-to-date.

No services need to be restarted.

No containers need to be restarted.

User sessions running outdated binaries:
 randall @ session #2: gdm-wayland-ses[1967]
 randall @ user manager service: firefox-esr[3254], gnome-session-b[2019], 
gnome-shell[2048], systemd[1784], thunderbird[2932]

No VM guests are running outdated hypervisor (qemu) binaries on this host.
12:59:27 [root@batou:~] 4s # systemctl status zcfan
○ zcfan.service - Zero-configuration fan control for ThinkPad
 Loaded: loaded (/lib/systemd/system/zcfan.service; enabled; preset: 
enabled)
 Active: inactive (dead) since Mon 2023-03-06 12:58:59 CET; 36s ago
   Duration: 1min 9.982s
Process: 17359 ExecStart=/usr/bin/zcfan (code=exited, status=0/SUCCESS)
   Main PID: 17359 (code=exited, status=0/SUCCESS)
CPU: 275ms

Mär 06 12:57:49 batou zcfan[17359]: [CFG] At 90C fan is set to maximum
Mär 06 12:57:49 batou zcfan[17359]: [CFG] At 80C fan is set to medium
Mär 06 12:57:49 batou zcfan[17359]: [CFG] At 70C fan is set to low
Mär 06 12:57:49 batou zcfan[17359]: [FAN] Temperature now 51C, fan set to off
Mär 06 12:58:23 batou zcfan[17359]: [FAN] Temperature now 71C, fan set to low
Mär 06 12:58:26 batou zcfan[17359]: [FAN] Temperature now 50C, fan set to off
Mär 06 12:58:59 batou zcfan[17359]: [FAN] Quit requested, reenabling 
thinkpad_acpi fan control
Mär 06 12:58:59 batou systemd[1]: Stopping zcfan.service - Zero-configuration 
fan control for ThinkPad...
Mär 06 12:58:59 batou systemd[1]: zcfan.service: Deactivated successfully.
Mär 06 12:58:59 batou systemd[1]: Stopped zcfan.service - Zero-configuration 
fan control for ThinkPad.
12:59:35 [root@batou:~] 3 # systemctl start zcfan
12:59:39 [root@batou:~] # systemctl status zcfan
● zcfan.service - Zero-configuration fan control for ThinkPad
 Loaded: loaded (/lib/systemd/system/zcfan.service; enabled; preset: 
enabled)
 Active: active (running) since Mon 2023-03-06 12:59:39 CET; 3s ago
   Main PID: 18995 (zcfan)
  Tasks: 1 (limit: 28396)
 Memory: 264.0K
CPU: 21ms
 CGroup: /system.slice/zcfan.service
 └─18995 /usr/bin/zcfan

Mär 06 12:59:39 batou systemd[1]: Started zcfan.service - Zero-configuration 
fan control for ThinkPad.
Mär 06 12:59:39 batou zcfan[18995]: [CFG] At 90C fan is set to maximum
Mär 06 12:59:39 batou zcfan[18995]: [CFG] At 80C fan is set to medium
Mär 06 12:59:39 batou zcfan[18995]: [CFG] At 70C fan is set to low
Mär 06 12:59:39 batou zcfan[18995]: [FAN] Temperature now 50C, fan set to off
12:59:43 [root@batou:~] # apt purge zcfan
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
The following package