Bug#1036584: libopenjpip-viewer: broken symlink: /usr/bin/opj_jpip_viewer -> ../share/opj_jpip_viewer/opj_jpip_viewer.jar
Le jeu. 25 mai 2023, 19:15, Andreas Metzler a écrit : > Hello, > > if you have not got time for an upload I can look into it. > Yes please ! Thanks very much > cu Andreas > >
Bug#1036584: libopenjpip-viewer: broken symlink: /usr/bin/opj_jpip_viewer -> ../share/opj_jpip_viewer/opj_jpip_viewer.jar
Hello, if you have not got time for an upload I can look into it. cu Andreas
Bug#1036584: libopenjpip-viewer: broken symlink: /usr/bin/opj_jpip_viewer -> ../share/opj_jpip_viewer/opj_jpip_viewer.jar
On 2023-05-24 Mathieu Malaterre wrote:
> On Wed, May 24, 2023 at 6:21 PM Andreas Metzler wrote:
[...]
> > Correct patch attached. Stuff was built but the respective dh_install
> > call was shadowed and therefore content was not shipped in the package.
> [...]
> -override_dh_install-indep:
> - dh_install -p$(pkg_doc) debian/tmp/usr/share/doc
> -
> [...]
> Isn't this going to break the openjpeg-doc package ?
Hello Mathieu,
No, replaced by the second part of the patch
8X---
--- openjpeg2-2.5.0/debian/openjpeg-doc.install 1970-01-01 01:00:00.0
+0100
+++ openjpeg2-2.5.0/debian/openjpeg-doc.install 2023-05-24 12:45:48.0
+0200
@@ -0,0 +1 @@
+usr/share/doc
8X---
| ametzler@argenau:/dev/shm/JPI$ debdiff openjpeg-doc_2.5.0-{1,2}_all.deb
| File lists identical (after any substitutions)
|
| Control files: lines which differ (wdiff format)
|
| Version: [-2.5.0-1-] {+2.5.0-2+}
cu Andreas
--
`What a good friend you are to him, Dr. Maturin. His other friends are
so grateful to you.'
`I sew his ears on from time to time, sure'
Bug#1036584: libopenjpip-viewer: broken symlink: /usr/bin/opj_jpip_viewer -> ../share/opj_jpip_viewer/opj_jpip_viewer.jar
Control: tags -1 - patch On Wed, May 24, 2023 at 6:21 PM Andreas Metzler wrote: > > Control: retitle -1 libopenjpip-viewer is basically empty > > On 2023-05-23 Mathieu Malaterre wrote: > > On Tue, May 23, 2023 at 10:46 AM Mathieu Malaterre wrote: > > > > > > Control: retitle -1 No java compiler found. Won't be able to build java > > > viewer > > > > > > openjpeg2/java compilation appears to be broken: > [...] > > > default-jdk is defined in B-D-I which looks wrong IMHO: > > > * > > https://salsa.debian.org/debian-phototools-team/openjpeg2/-/blob/master/debian/control#L16 > > > [...] > > Build-Depends-Indep: default-jdk, > > [...] > > Why does this look wrong? libopenjpip-viewer is arch-all. > > Correct patch attached. Stuff was built but the respective dh_install > call was shadowed and therefore content was not shipped in the package. [...] -override_dh_install-indep: - dh_install -p$(pkg_doc) debian/tmp/usr/share/doc - [...] Isn't this going to break the openjpeg-doc package ?
Bug#1036584: libopenjpip-viewer: broken symlink: /usr/bin/opj_jpip_viewer -> ../share/opj_jpip_viewer/opj_jpip_viewer.jar
Control: retitle -1 libopenjpip-viewer is basically empty On 2023-05-23 Mathieu Malaterre wrote: > On Tue, May 23, 2023 at 10:46 AM Mathieu Malaterre wrote: > > > > Control: retitle -1 No java compiler found. Won't be able to build java > > viewer > > > > openjpeg2/java compilation appears to be broken: [...] > default-jdk is defined in B-D-I which looks wrong IMHO: > * > https://salsa.debian.org/debian-phototools-team/openjpeg2/-/blob/master/debian/control#L16 > [...] > Build-Depends-Indep: default-jdk, > [...] Why does this look wrong? libopenjpip-viewer is arch-all. Correct patch attached. Stuff was built but the respective dh_install call was shadowed and therefore content was not shipped in the package. cu Andreas -- `What a good friend you are to him, Dr. Maturin. His other friends are so grateful to you.' `I sew his ears on from time to time, sure' diff -Nru openjpeg2-2.5.0/debian/changelog openjpeg2-2.5.0/debian/changelog --- openjpeg2-2.5.0/debian/changelog 2022-06-20 16:05:24.0 +0200 +++ openjpeg2-2.5.0/debian/changelog 2023-05-24 12:45:48.0 +0200 @@ -1,3 +1,10 @@ +openjpeg2 (2.5.0-2) UNRELEASED; urgency=medium + + * Team upload. + * Fix broken symlink. Closes: #1036584 + + -- Andreas Metzler Wed, 24 May 2023 12:45:48 +0200 + openjpeg2 (2.5.0-1) unstable; urgency=medium * New upstream version 2.5.0 diff -Nru openjpeg2-2.5.0/debian/openjpeg-doc.install openjpeg2-2.5.0/debian/openjpeg-doc.install --- openjpeg2-2.5.0/debian/openjpeg-doc.install 1970-01-01 01:00:00.0 +0100 +++ openjpeg2-2.5.0/debian/openjpeg-doc.install 2023-05-24 12:45:48.0 +0200 @@ -0,0 +1 @@ +usr/share/doc diff -Nru openjpeg2-2.5.0/debian/rules openjpeg2-2.5.0/debian/rules --- openjpeg2-2.5.0/debian/rules 2022-06-20 16:01:30.0 +0200 +++ openjpeg2-2.5.0/debian/rules 2023-05-24 12:45:48.0 +0200 @@ -50,9 +50,6 @@ pkg_vwr = libopenjpip-viewer pkg_dsrv = libopenjpip-dec-server -override_dh_install-indep: - dh_install -p$(pkg_doc) debian/tmp/usr/share/doc - override_dh_install-arch: # annoying cmake-fatal-error export stuff: sed -i -e "s/FATAL_ERROR/STATUS/g" debian/tmp/usr/lib/$(DEB_HOST_MULTIARCH)/openjpeg-2.5/OpenJPEGTargets*.cmake
Bug#1036584: libopenjpip-viewer: broken symlink: /usr/bin/opj_jpip_viewer -> ../share/opj_jpip_viewer/opj_jpip_viewer.jar
Control: tags -1 patch On Tue, May 23, 2023 at 10:46 AM Mathieu Malaterre wrote: > > Control: retitle -1 No java compiler found. Won't be able to build java viewer > > openjpeg2/java compilation appears to be broken: > > -- Could NOT find Java (missing: Java_JAVA_EXECUTABLE > Java_JAVAC_EXECUTABLE Java_JAR_EXECUTABLE Java_JAVADOC_EXECUTABLE > Java_JAVAH_EXECUTABLE Development) (Required is at least version > "1.8") > CMake Warning at src/bin/jpip/CMakeLists.txt:160 (message): > No java compiler found. Won't be able to build java viewer default-jdk is defined in B-D-I which looks wrong IMHO: * https://salsa.debian.org/debian-phototools-team/openjpeg2/-/blob/master/debian/control#L16 [...] Build-Depends-Indep: default-jdk, [...]
Bug#1036584: libopenjpip-viewer: broken symlink: /usr/bin/opj_jpip_viewer -> ../share/opj_jpip_viewer/opj_jpip_viewer.jar
Control: retitle -1 No java compiler found. Won't be able to build java viewer openjpeg2/java compilation appears to be broken: -- Could NOT find Java (missing: Java_JAVA_EXECUTABLE Java_JAVAC_EXECUTABLE Java_JAR_EXECUTABLE Java_JAVADOC_EXECUTABLE Java_JAVAH_EXECUTABLE Development) (Required is at least version "1.8") CMake Warning at src/bin/jpip/CMakeLists.txt:160 (message): No java compiler found. Won't be able to build java viewer ref: * https://buildd.debian.org/status/fetch.php?pkg=openjpeg2=amd64=2.5.0-1%2Bb1=1673540495=0
Bug#1036584: libopenjpip-viewer: broken symlink: /usr/bin/opj_jpip_viewer -> ../share/opj_jpip_viewer/opj_jpip_viewer.jar
Package: libopenjpip-viewer Version: 2.5.0-1 Severity: serious User: debian...@lists.debian.org Usertags: piuparts Hi, during a test with piuparts I noticed your package ships (or creates) a broken symlink: 0m17.6s ERROR: WARN: Broken symlinks: /usr/bin/opj_jpip_viewer -> ../share/opj_jpip_viewer/opj_jpip_viewer.jar (libopenjpip-viewer) The targeted .jar file seems to be no longer shipped by any package in sid. cheers, Andreas
