Bug#1036885: unblock: hipsparse/5.3.3+dfsg-2
control: tags -1 - moreinfo Hi Paul, On 2023-06-01 08:54, Paul Gevers wrote: > Please upload hipsparse to tpu (targeting bookworm in the changelog) > with no other changes than a changelog entry on top of what you have in > unstable. Please use the version number 5.3.3+dfsg-2~deb12u1. Thank you for considering this. > Remove the moreinfo tag once the upload has happened. The upload window > is tight. The *migration* needs to happen before Sunday. Done. I hope I made it into the time window. Best, Christian
Bug#1036885: unblock: hipsparse/5.3.3+dfsg-2
control: tags -1 moreinfo Hi Christian, On 31-05-2023 20:05, Christian Kastner wrote: I'm willing to do what it takes to get this fixed in testing, but I'm not sure which solution, if any, is agreeable to the RT: (6) Alternatives? Please upload hipsparse to tpu (targeting bookworm in the changelog) with no other changes than a changelog entry on top of what you have in unstable. Please use the version number 5.3.3+dfsg-2~deb12u1. Remove the moreinfo tag once the upload has happened. The upload window is tight. The *migration* needs to happen before Sunday. Paul OpenPGP_signature Description: OpenPGP digital signature
Bug#1036885: unblock: hipsparse/5.3.3+dfsg-2
On 2023-05-31 19:28, Adam D. Barratt wrote: > In the versions in testing, both packages only built for amd64. In > unstable, they have also built for arm64. Migrating the arm64 hipsparse > binaries from unstable therefore requires migrating a version of > rocsparse with arm64 binaries. Oh, that's a good catch, never thought of that, mainly because in practice, we only look at amd64. This is a rather new ecosystem and we're still ironing out the kinks. A successful build on arm64 is a bit annoying, as we don't expect many users there -- I'd be surprised if one manages to even get the required mainboard. I'm willing to do what it takes to get this fixed in testing, but I'm not sure which solution, if any, is agreeable to the RT: (1) Request an unblock for the rocsparse/5.3.0+dfsg-3 as-is (2) Re-upload hipsparse with a reduced arch: amd64 (3) Prepare new (minimal debdiff) upload for rocsparse, file unblock request (4) Remove the arm64 binaries (is that even possible?) (5) Fix this in the first point release (6) Alternatives? Please let me know what, if any, option you'd prefer. I'm aware that we are shortly before the release and that this might limit the available options. Best, Christian
Bug#1036885: unblock: hipsparse/5.3.3+dfsg-2
On Wed, 2023-05-31 at 19:09 +0200, Christian Kastner wrote: > I can't see why rocsparse 5.3.0+dfsg-3 would > block > hipsparse? The Depends and Build-Depends aren't versioned. In the versions in testing, both packages only built for amd64. In unstable, they have also built for arm64. Migrating the arm64 hipsparse binaries from unstable therefore requires migrating a version of rocsparse with arm64 binaries. Regards, Adam
Bug#1036885: unblock: hipsparse/5.3.3+dfsg-2
Hi Graham, On 2023-05-31 08:58, Graham Inggs wrote: > Hi Christian > > On Sun, 28 May 2023 at 18:48, Christian Kastner wrote: >> unblock hipsparse/5.3.3+dfsg-2 > > The debdiff looks good to me, however the migration of > hipsparse/5.3.3+dfsg-2 appears to be blocked by rocsparse/5.3.0+dfsg-3 > [1].> > Migrates after: rocsparse I didn't notice this because I didn't expect this, and to be honest I'm still a bit confused: I can't see why rocsparse 5.3.0+dfsg-3 would block hipsparse? The Depends and Build-Depends aren't versioned. > Migration status for hipsparse (5.3.3+dfsg-1 to 5.3.3+dfsg-2): > BLOCKED: Needs an approval (either due to a freeze, the source suite > or a manual hint) > Issues preventing migration: > ∙ ∙ Not touching package due to block request by freeze (Follow the > freeze policy when applying for an unblock) > ∙ ∙ Too young, only 2 of 5 days old > ∙ ∙ Build-Depends(-Arch): hipsparse rocsparse > ∙ ∙ Depends: hipsparse rocsparse > > I don't see an unblock request for rocsparse/5.3.0+dfsg-3, would you > file one please? I'd be happy to, but the debdiff for rocsparse/5.3.0+dfsg-3 to -2 would be a bit larger than for hipsparse; this is the changelog: > * Update patch DEP-3 metadata fields. >* d/rules: use DWARF 4 debug symbols >* d/rules: enable hardening flags >* d/rules: enable gfx1010 and gfx1011 >* Add d/p/0003-fix-oob-access-in-rocsparse-test.patch > to fix out-of-bound accesses in test suite. >* Reduce arch to amd64, arm64, ppc64el There's nothing dramatic in there, and the changes have been in unstable for almost 3 months now, so we would be fine with letting that migrate if that's the call. I'd also be happy to prepare an upload with some of the changes reduced, but I'm not sure how that would work on your end, schedule-wise. Anyway, perhaps there is a simpler resolution to this, namely the rocsparse block just being a false positive. Best, Christian
Bug#1036885: unblock: hipsparse/5.3.3+dfsg-2
Hi Christian On Sun, 28 May 2023 at 18:48, Christian Kastner wrote: > unblock hipsparse/5.3.3+dfsg-2 The debdiff looks good to me, however the migration of hipsparse/5.3.3+dfsg-2 appears to be blocked by rocsparse/5.3.0+dfsg-3 [1]. Migrates after: rocsparse Migration status for hipsparse (5.3.3+dfsg-1 to 5.3.3+dfsg-2): BLOCKED: Needs an approval (either due to a freeze, the source suite or a manual hint) Issues preventing migration: ∙ ∙ Not touching package due to block request by freeze (Follow the freeze policy when applying for an unblock) ∙ ∙ Too young, only 2 of 5 days old ∙ ∙ Build-Depends(-Arch): hipsparse rocsparse ∙ ∙ Depends: hipsparse rocsparse I don't see an unblock request for rocsparse/5.3.0+dfsg-3, would you file one please? Regards Graham [1] https://tracker.debian.org/pkg/hipsparse
Bug#1036885: unblock: hipsparse/5.3.3+dfsg-2
Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock
X-Debbugs-Cc: hipspa...@packages.debian.org
Control: affects -1 + src:hipsparse
Please unblock package hipsparse
[ Reason ]
hipsparse is missing explicit dependencies on libamdhip64-dev.
[ Impact ]
Users installing libhipsparse-dev will not be able to use it without
also installing libamdhip64-dev, and it is not immediately made clear
what the actual cause of the error is.
[ Tests ]
This package does not yet have autopkgtests but in this particular case,
the change is minimal and only affects d/control.
[ Risks ]
None, compared to the previous release -1.
[ Checklist ]
[X] all changes are documented in the d/changelog
[X] I reviewed all changes and I approve them
[X] attach debdiff against the package in testing
[ Other info ]
None.
unblock hipsparse/5.3.3+dfsg-2diff -Nru hipsparse-5.3.3+dfsg/debian/changelog
hipsparse-5.3.3+dfsg/debian/changelog
--- hipsparse-5.3.3+dfsg/debian/changelog 2023-01-24 11:35:25.0
+0100
+++ hipsparse-5.3.3+dfsg/debian/changelog 2023-05-28 17:17:36.0
+0200
@@ -1,3 +1,15 @@
+hipsparse (5.3.3+dfsg-2) unstable; urgency=medium
+
+ * Team upload.
+
+ [ Cordell Bloor ]
+ * d/control: explicitly depend on libamdhip64-dev
+hipsparse.h includes hip/hip_complex.h and hip/hip_runtime.h, so users
+must have the hip headers installed to use the hipsparse headers.
+(Closes: #1035789)
+
+ -- Christian Kastner Sun, 28 May 2023 17:17:36 +0200
+
hipsparse (5.3.3+dfsg-1) unstable; urgency=medium
* Initial release. (Closes: #1023092)
diff -Nru hipsparse-5.3.3+dfsg/debian/control
hipsparse-5.3.3+dfsg/debian/control
--- hipsparse-5.3.3+dfsg/debian/control 2023-01-24 11:35:25.0 +0100
+++ hipsparse-5.3.3+dfsg/debian/control 2023-05-28 17:17:36.0 +0200
@@ -15,6 +15,7 @@
hipcc,
libamd-comgr-dev,
libhsa-runtime-dev,
+ libamdhip64-dev,
librocsparse-dev,
libgtest-dev
Rules-Requires-Root: no
@@ -33,7 +34,8 @@
Package: libhipsparse-dev
Section: libdevel
Architecture: any
-Depends: libhipsparse0 (= ${binary:Version}),${misc:Depends},
${shlibs:Depends},
+Depends: libhipsparse0 (= ${binary:Version}), ${misc:Depends},
${shlibs:Depends},
+ libamdhip64-dev
Description: portable interface for sparse linear algebra on the GPU - headers
hipSPARSE is a wrapper library that provides a common interface to rocSPARSE
and cuSPARSE. The hipSPARSE library is designed to help applications using
