Bug#1037279: Angelfish built-in ad blocker not built due to missing Rust Build-Depends (Corrosion etc.)

[Nilesh Patra]

Quoting Nilesh Patra:
>> On Sat, 10 Jun 2023 05:09:08 +0200 Kevin Kofler  
>> wrote:
>> In addition to Corrosion, you will need cargo(though Corrosion should
>> already be requiring it), rust-adblock, rust-cxx-build, and rust-cxx.
> corossion, rust-adblock need packaging. Rest are in the archive already at 
> the moment. I doubt if we need
> corossion too, since this is mainly for comat with cmake based projects, and 
> we are usually not relying on
> submodule struct, and package things separately.

I have uploaded corrosion to NEW, it helps to build angelfish with adblock 
support
at least locally (with internet enabled fetching cargo deps).

Rest rust-cxx packages are in the archive already. rust-adblock is what we need.
I've filed an RFP bug#1063626 and pinged in rust-team IRC incase someone could 
pick
it up. I don't have the spoons to do so.

Best,
Nilesh


signature.asc
Description: PGP signature

Bug#1037279: Angelfish built-in ad blocker not built due to missing Rust Build-Depends (Corrosion etc.)

[Nilesh Patra]

On Sat, 10 Jun 2023 05:09:08 +0200 Kevin Kofler  wrote:> Angelfish has a built-in ad blocker based on the Rust adblock crate from 
the Brave developers. This feature is missing from the Debian package 
because Corrosion and other build-time dependencies are not Build-Depended.


Right, and the reason is...


(They may need to be added to Debian first.)


Precisely this. At the time of packaging angelfish, I suppose neither of us (me 
and Praveen) have had the
bandwidth to package all the rust toolchain yet.


In addition to Corrosion, you will need cargo(though Corrosion should
already be requiring it), rust-adblock, rust-cxx-build, and rust-cxx.


corossion, rust-adblock need packaging. Rest are in the archive already at the 
moment. I doubt if we need
corossion too, since this is mainly for comat with cmake based projects, and we 
are usually not relying on
submodule struct, and package things separately.


You may also need to hack things up so that it can build offline.


I'm quite sure it'd need some changes.

See also https://bugzilla.redhat.com/show_bug.cgi?id=2213926 for the exact 
same issue in the Fedora package.


Cool. Thanks for reporting. Can get back to this once we have the bandwidth.

Best
Nilesh

Bug#1037279: Angelfish built-in ad blocker not built due to missing Rust Build-Depends (Corrosion etc.)

[Kevin Kofler]

Package: angelfish
Version: 22.11-1+b2

Angelfish has a built-in ad blocker based on the Rust adblock crate from 
the Brave developers. This feature is missing from the Debian package 
because Corrosion and other build-time dependencies are not Build-Depended. 
(They may need to be added to Debian first.)


Just check your build logs, e.g.:
https://buildd.debian.org/status/fetch.php?pkg=angelfish=arm64=22.11-1%2Bb2=1679750090=0

Actual Results:  

-- The following RECOMMENDED packages have not been found:

 * Corrosion, CMake scripts to seamlessly build and link to targets using cargo, 

   Required to build the builtin adblocker


Expected Results:  
The ad blocker is built.


In addition to Corrosion, you will need cargo (though Corrosion should 
already be requiring it), rust-adblock, rust-cxx-build, and rust-cxx. You 
may also need to hack things up so that it can build offline.


See also https://bugzilla.redhat.com/show_bug.cgi?id=2213926 for the exact 
same issue in the Fedora package.