Bug#1037567: abseil: ftbfs with GCC-13

2023-08-06 Thread Benjamin Barenblat
Thank you for the patch, Aurelien! I’ve applied it to the 20220623.1
release and uploaded it to unstable as 20220623.1-2.



Bug#1037567: abseil: ftbfs with GCC-13

2023-08-05 Thread Aurelien Jarno
On 2023-08-04 08:53, Aurelien Jarno wrote:
> On 2023-08-03 21:33, Aurelien Jarno wrote:
> > Hi,
> > 
> > On 2023-08-02 14:27, Benjamin Barenblat wrote:
> > > I’ve been procrastinating on starting the transition because of some
> > > lingering MIPS issues. I think they’ve all been sorted out, and I just
> > > uploaded my latest work to experimental. If that passes the buildds,
> > > I’ll request a transition slot and do the transition as quickly as
> > > possible.
> > > 
> > > If waiting on the transition is going to unacceptably delay the riscv64
> > > bootstrap, please let me know. I think I know which patches I would have
> > > to backport to 20220623 to get it to build with GCC 13, so I may be able
> > > to fix this in unstable before the transition completes.
> > 
> > It was not clear when we're going to need abseil when sending the
> > initial mail, but it's not clear that we'll need to really soon for
> 
> After reading my email again, I noticed a typo that could lead to a
> misunderstanding: "it's now clear that we'll need it really soon"

The easiest and less risky way to make it build is probably to go back
to using gcc-12. This is what the attached patch does.

Regards
Aurelien

-- 
Aurelien Jarno  GPG: 4096R/1DDD8C9B
aurel...@aurel32.net http://aurel32.net
diff -Nru abseil-20220623.1/debian/control abseil-20220623.1/debian/control
--- abseil-20220623.1/debian/control	2022-10-18 14:31:29.0 +0200
+++ abseil-20220623.1/debian/control	2023-08-05 11:20:36.0 +0200
@@ -18,7 +18,8 @@
 Build-Depends:
  cmake (>= 3.5),
  debhelper-compat (= 12),
- googletest (>= 1.12) [!mipsel !ppc64] 
+ googletest (>= 1.12) [!mipsel !ppc64] ,
+ g++-12
 Rules-Requires-Root: no
 Standards-Version: 4.6.1
 Section: libs
diff -Nru abseil-20220623.1/debian/rules abseil-20220623.1/debian/rules
--- abseil-20220623.1/debian/rules	2022-10-18 14:37:10.0 +0200
+++ abseil-20220623.1/debian/rules	2023-08-05 11:20:36.0 +0200
@@ -38,11 +38,11 @@
 	$(RM) -r $(CURDIR)/shared
 
 override_dh_auto_configure:
-	dh_auto_configure -Bstatic -- -DCMAKE_CXX_STANDARD=17 -DBUILD_SHARED_LIBS=OFF
+	dh_auto_configure -Bstatic -- -DCMAKE_C_COMPILER=$(DEB_HOST_GNU_TYPE)-gcc-12 -DCMAKE_CXX_COMPILER=$(DEB_HOST_GNU_TYPE)-g++-12 -DCMAKE_CXX_STANDARD=17 -DBUILD_SHARED_LIBS=OFF
 ifeq ($(ABSL_RUN_TESTS),ON)
-	dh_auto_configure -Bshared -- -DCMAKE_CXX_STANDARD=17 -DBUILD_SHARED_LIBS=ON -DBUILD_TESTING=ON -DABSL_BUILD_TESTING=ON -DABSL_USE_GOOGLETEST_HEAD=OFF
+	dh_auto_configure -Bshared -- -DCMAKE_C_COMPILER=$(DEB_HOST_GNU_TYPE)-gcc-12 -DCMAKE_CXX_COMPILER=$(DEB_HOST_GNU_TYPE)-g++-12 -DCMAKE_CXX_STANDARD=17 -DBUILD_SHARED_LIBS=ON -DBUILD_TESTING=ON -DABSL_BUILD_TESTING=ON -DABSL_USE_GOOGLETEST_HEAD=OFF
 else
-	dh_auto_configure -Bshared -- -DCMAKE_CXX_STANDARD=17 -DBUILD_SHARED_LIBS=ON
+	dh_auto_configure -Bshared -- -DCMAKE_C_COMPILER=$(DEB_HOST_GNU_TYPE)-gcc-12 -DCMAKE_CXX_COMPILER=$(DEB_HOST_GNU_TYPE)-g++-12 -DCMAKE_CXX_STANDARD=17 -DBUILD_SHARED_LIBS=ON
 endif
 
 override_dh_auto_build:


Bug#1037567: abseil: ftbfs with GCC-13

2023-08-04 Thread Bo YU
Source: abseil
Followup-For: Bug #1037567

Dear Maintainer,

I'm terribly sorry if I'm suddenly intruding on this thread.

For riscv64, We need abseil more than anything else at this point in my
view. Because there are several dependencies chains that even end up
pointing to abseil.

Ideally we should wait for the transition, but now it seems the abseil
is our main blocker if without resolving other dependency loops. So
I think if we can upload new version with patch which fixed the gcc-13
build issueu[0] that will speed up our riscv64 official porting.

Thanks.

[0]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1037567#36


-- 
Regards,
--
  Bo YU



signature.asc
Description: PGP signature


Bug#1037567: abseil: ftbfs with GCC-13

2023-08-04 Thread Aurelien Jarno
On 2023-08-03 21:33, Aurelien Jarno wrote:
> Hi,
> 
> On 2023-08-02 14:27, Benjamin Barenblat wrote:
> > I’ve been procrastinating on starting the transition because of some
> > lingering MIPS issues. I think they’ve all been sorted out, and I just
> > uploaded my latest work to experimental. If that passes the buildds,
> > I’ll request a transition slot and do the transition as quickly as
> > possible.
> > 
> > If waiting on the transition is going to unacceptably delay the riscv64
> > bootstrap, please let me know. I think I know which patches I would have
> > to backport to 20220623 to get it to build with GCC 13, so I may be able
> > to fix this in unstable before the transition completes.
> 
> It was not clear when we're going to need abseil when sending the
> initial mail, but it's not clear that we'll need to really soon for

After reading my email again, I noticed a typo that could lead to a
misunderstanding: "it's now clear that we'll need it really soon"

-- 
Aurelien Jarno  GPG: 4096R/1DDD8C9B
aurel...@aurel32.net http://aurel32.net



Bug#1037567: abseil: ftbfs with GCC-13

2023-08-03 Thread Aurelien Jarno
Hi,

On 2023-08-02 14:27, Benjamin Barenblat wrote:
> I’ve been procrastinating on starting the transition because of some
> lingering MIPS issues. I think they’ve all been sorted out, and I just
> uploaded my latest work to experimental. If that passes the buildds,
> I’ll request a transition slot and do the transition as quickly as
> possible.
> 
> If waiting on the transition is going to unacceptably delay the riscv64
> bootstrap, please let me know. I think I know which patches I would have
> to backport to 20220623 to get it to build with GCC 13, so I may be able
> to fix this in unstable before the transition completes.

It was not clear when we're going to need abseil when sending the
initial mail, but it's not clear that we'll need to really soon for
building llvm-toolchain-XX through both libgrpc++-dev and
libctypes-ocaml.

Therefore it would be great if you can fix that in unstable before the
transition. From what I understand it should be this patch:
https://github.com/abseil/abseil-cpp/commit/4eef16170014f75f4291ae335a271900f89eaedf

Alternatively it could also be changing the compiler to gcc-12.

Thanks
Aurelien

-- 
Aurelien Jarno  GPG: 4096R/1DDD8C9B
aurel...@aurel32.net http://aurel32.net



Bug#1037567: abseil: ftbfs with GCC-13

2023-08-02 Thread Benjamin Barenblat
I’ve been procrastinating on starting the transition because of some
lingering MIPS issues. I think they’ve all been sorted out, and I just
uploaded my latest work to experimental. If that passes the buildds,
I’ll request a transition slot and do the transition as quickly as
possible.

If waiting on the transition is going to unacceptably delay the riscv64
bootstrap, please let me know. I think I know which patches I would have
to backport to 20220623 to get it to build with GCC 13, so I may be able
to fix this in unstable before the transition completes.



Bug#1037567: abseil: ftbfs with GCC-13

2023-08-01 Thread Aurelien Jarno
Hi,

On 2023-06-26 12:55, Benjamin Barenblat wrote:
> Control: fixed -1 20230125.3
> Control: forwarded -1 https://github.com/abseil/abseil-cpp/issues/1366
> Control: owner -1 !
> Control: tags -1 upstream fixed-upstream fixed-in-experimental
> 
> This has been resolved in the 20230125 series, which is currently in
> experimental and will be included in trixie after it transitions.

What are your plans with this transition? This bug will soon block the
riscv64 bootstrap in the official archive, and thus we would be
interested by a relatively quick fix in unstable.

Thanks
Aurelien

-- 
Aurelien Jarno  GPG: 4096R/1DDD8C9B
aurel...@aurel32.net http://aurel32.net


signature.asc
Description: PGP signature


Bug#1037567: abseil: ftbfs with GCC-13

2023-06-26 Thread Benjamin Barenblat
Control: fixed -1 20230125.3
Control: forwarded -1 https://github.com/abseil/abseil-cpp/issues/1366
Control: owner -1 !
Control: tags -1 upstream fixed-upstream fixed-in-experimental

This has been resolved in the 20230125 series, which is currently in
experimental and will be included in trixie after it transitions.