Source: netpbm-free Version: 2:11.01.00-2 Severity: normal X-Debbugs-Cc: Akira Urushibata <a...@wta.att.ne.jp>
Upstream Akira Urushibat wrote in private mail due to problems posting to Debian BTS: ----------------------------------------------------------------- I see that you have authored a patch file for modifying the tests reflecting the absence of certain executable files in Debian's Netpbm package. I have suggestions on how this should be done next time: (1) all-in-place.test If you modify all-in-place.test, you must also modify all-in-place.ok (in the same test directory.) All tests in the test framework produce output which is captured in a file in directory /tmp/nestpbm-test and suffixed ".out" . The ".out" file and ".ok" file are compared and if they match, the test is declared a success. A very simple way to deal with omitted programs is to take the file /tmp/netpbm-test/all-in-place.out, rename it to all-in-place.ok and use it as a replacement of the file in the test directory. It will have some lines saying things like "manweb: NO SUCH FILE" but that is proper for the Debian package. Once a patch is created it should be valid for a good time. (As some new programs are added to the list, offsets will be reported when applying the patch.) One advantage of this approach is that if in the future, someone erroneously makes a change that results in one of the omitted programs (say manweb) being created, the issue will be reported. (2) Test-Order Instead of deleting lines for tests to be skipped, I suggest commenting them out. Thank you for the work. If you have any questions, please feel free to ask me (Akira Urushibata <a...@wta.att.ne.jp>). ----------------------------------------------------------------------- I'm just recording these perfectly valid and helpful statements in BTS to make sure it does not become lost in my private mailbox. Kind regards Andreas. -- System Information: Debian Release: trixie/sid APT prefers unstable APT policy: (500, 'unstable'), (500, 'testing'), (50, 'buildd-unstable'), (1, 'experimental') Architecture: amd64 (x86_64) Kernel: Linux 6.3.0-2-amd64 (SMP w/8 CPU threads; PREEMPT) Kernel taint flags: TAINT_WARN Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8), LANGUAGE not set Shell: /bin/sh linked to /usr/bin/dash Init: systemd (via /run/systemd/system) LSM: AppArmor: enabled