Bug#1041754: [pcp] Bug#1041754: pcp: ships empty directory /usr/lib/pkgconfig

2024-01-29 Thread Nathan Scott
https://github.com/performancecopilot/pcp/pull/1874



Bug#1041754: pcp: ships empty directory /usr/lib/pkgconfig

2024-01-28 Thread Nathan Scott
On Mon, Jan 1, 2024 at 1:47 AM Chris Hofstaedtler  wrote:
> [..]
>
> I see you've uploaded two new upstream versions since this bug was
> filed. Is there anything blocking inclusion of Helmut's patch?
>

Thank you for the reminder and thanks for the patch Helmut.
I'll get this into the next update (pcp-6.2.0 expected late next week).

cheers.

--
Nathan



Bug#1041754: pcp: ships empty directory /usr/lib/pkgconfig

2023-12-31 Thread Chris Hofstaedtler
Hello Nathan,

On Sun, Jul 23, 2023 at 07:46:28AM +0200, Helmut Grohne wrote:
> Package: pcp
> Version: 6.0.5-1
> Severity: important
[..]

I see you've uploaded two new upstream versions since this bug was
filed. Is there anything blocking inclusion of Helmut's patch?

Thanks,
Chris



Bug#1041754: pcp: ships empty directory /usr/lib/pkgconfig

2023-07-22 Thread Helmut Grohne
Package: pcp
Version: 6.0.5-1
Severity: important
Tags: patch

The binary package pcp ships an empty /usr/lib/pkgconfig. Since we
implemented the /usr-merge using aliasing, this directory is prone to
loss.

As I see it, pcp is split into a number of packages some of which
contain files below /usr/lib/pkgconfig. The existence of that empty
directory is an artifact of how the package is being split and not
required for operation (as it is normally "owned" by pkg-config). As
such, we can delete it from pcp without loss of functionality (and in
the packages shipping .pc files it is non-empty). Since we cannot loose
something that does not exist, the original problem is solved. Do you
agree? I'm attaching a patch for your convenience.

Helmut
diff -Nru pcp-6.0.5/debian/changelog pcp-6.0.5/debian/changelog
--- pcp-6.0.5/debian/changelog  2023-06-14 04:49:33.0 +0200
+++ pcp-6.0.5/debian/changelog  2023-07-23 07:15:09.0 +0200
@@ -1,3 +1,10 @@
+pcp (6.0.5-1.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Do not ship empty directory /usr/lib/pkgconfig (closes: #-1)
+
+ -- Helmut Grohne   Sun, 23 Jul 2023 07:15:09 +0200
+
 pcp (6.0.5-1) unstable; urgency=low
 
   * New release (full details in CHANGELOG).
diff -Nru pcp-6.0.5/debian/rules pcp-6.0.5/debian/rules
--- pcp-6.0.5/debian/rules  2023-02-13 05:03:53.0 +0100
+++ pcp-6.0.5/debian/rules  2023-07-23 07:15:03.0 +0200
@@ -148,7 +148,7 @@
 uninstallpy = cat python*-pcp.list | sed -e "s,^,$(dirpcp)/," | xargs rm -fr
 uninstallpydir = ls -d $(dirpcp)/usr/lib*/python* | xargs rm -fr
 uninstalltest = cat $(dirpcp_testsuite).dirs | sed -e "s,^,debian/$(pcp)/," | 
xargs rm -fr
-uninstalldirs = rmdir $(dirpcp)/usr/include/pcp $(dirpcp)/usr/include 
$(dirpcp)/usr/share/man/man3
+uninstalldirs = rmdir $(dirpcp)/usr/include/pcp $(dirpcp)/usr/include 
$(dirpcp)/usr/share/man/man3 $(dirpcp)/usr/lib/pkgconfig
 uninstallib = cat $(dirpcp_pmda_infiniband).dirs | sed -e "s,^,$(dirpcp)/," | 
xargs rm -fr
 uninstallspark = cat $(dirdoc).dirs | sed -e "s,^,$(dirpcp_export_spark)/," | 
xargs rm -fr
 uninstallgui = cat $(dirgui).dirs | sed -e "s,^,$(dirpcp)/," | xargs rm -fr