Bug#1042671: Test successful

[Lutz Lübbert]

Hey,
 
I tested the deb package and the fix seems to work as expected. I tested it 
with a few extra snapshots (adding and removing files) and everything is listed 
as expected when running the diff feature.
 
Thank you very much for taking care of this!
 
Best,
Lutz

Bug#1042671:

[Nicholas D Steeves]

lu...@mailbox.org writes:

> Hi Nicholas,
>  
> thanks for your quick response and your proposal. I will give it a try in the 
> next days and report back as soon as possible.

You're welcome.  P.S.  Slight correction in the last email: I meant to
write that "Borg 1.2.4" was uploaded during the hard freeze, and not
"Vorta 1.2.4".  'hope that was obvious!


signature.asc
Description: PGP signature

Bug#1042671:

[lutzl]

Hi Nicholas,
 
thanks for your quick response and your proposal. I will give it a try in the 
next days and report back as soon as possible.
 
Regards,
Lutz

Bug#1042671: vorta: diff feature broken

[Nicholas D Steeves]

Control: retitle -1 vorta: diff feature broken
Control: tag -1 upstream fixed-upstream
Control: fixed -1 vorta/0.8.12-1

Thanks for the bug report, and I agree this is an important (and
expected) feature.  This happened because Vorta 1.2.4 was uploaded
during Bookworm's (Debian 12's) hard freeze, and I trust that the
release team will accommodate the targeted fix you've proposed.

You can find the package I intend to upload here:

  
https://drive.google.com/drive/folders/1xKyYKhVEByeo0-Jdp8Fvbheh28xSYNUk?usp=sharing

It's just a trivial cherry pick of the relevant commit, but metadata
(documenting metadata takes much longer).  Would you please confirm if
this is enough to resolve the bug?

Regards,
Nicholas


signature.asc
Description: PGP signature

Bug#1042671: reportbug: vorta diff feature broken

[lutzl]

Subject: reportbug: vorta diff feature broken
Package: vorta
Version: 0.8.10-1
Severity: important

Dear Maintainer,
there is a bug in the vorta package as it is part of Debian 12.0 and 12.1.
The diff feature for archives does not work: Select two backups / archives
and press the diff button.
I expect a list off diffs between both archives (and this is an important
feature for a backup tool).
However, all we get is a crash:
 
2023-07-30 20:10:52,427 - root - CRITICAL - Uncaught exception, file a report 
at https://github.com/borgbase/vorta/issues/new/choose
Traceback (most recent call last):
File "/usr/lib/python3/dist-packages/vorta/views/diff_result.py", line 50, in 
run
parse_diff_json(lines, self.model)
File "/usr/lib/python3/dist-packages/vorta/views/diff_result.py", line 273, in 
parse_diff_json
raise Exception('Unknown change type: {}'.format(change['type']))
Exception: Unknown change type: ctime
 
This seems to be fixed upstream already: 
https://github.com/borgbase/vorta/pull/1675
According to the linked page, the problem is related to the used borg version 
and the currently
used vorta version is lacking this change to stay compatible.
 
Thank you.
 
System Information:
Debian Release: 12.1
APT prefers stable-updates
APT policy: (500, 'stable-updates'), (500, 'stable-security'), (500, 'stable')
Architecture: amd64 (x86_64)
Kernel: Linux 6.1.0-10-amd64 (SMP w/12 CPU threads; PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=locale: Cannot set 
LC_ALL to default locale: No such file or directory
UTF-8), LANGUAGE=en_US:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages vorta depends on:
ii libqt5svg5 5.15.8-3
ii python3 3.11.2-1+b1
ii python3-appdirs 1.4.4-3
ii python3-paramiko 2.12.0-2
ii python3-peewee 3.14.10+dfsg-1+b3
ii python3-pkg-resources 66.1.1-1
ii python3-psutil 5.9.4-1+b1
ii python3-pyqt5 5.15.9+dfsg-1
ii python3-secretstorage 3.3.3-1
Versions of packages vorta recommends:
ii borgbackup 1.2.4-1
ii openssh-client 1:9.2p1-2
vorta suggests no packages.
-- debconf information excluded