Bug#1045479: pipexec: Fails to build source after successful build

2023-08-14 Thread Andreas Florath
Hello!

Thanks for reporting this.

The root cause of the problem is, that one .c file is autogenerated by
a script during the build process.
This file is not cleaned during the dh_clean phase.

My suggestion would be to add this file to debian/clean. This fixes the
problem for me.

    $ cat debian/clean 
    src/app_version.c

This needs to be done my the maintainer (Thorsten) as I have no access
to the files under 'debian' sub-directory.

Kind regards - Andre



Bug#1045479: pipexec: Fails to build source after successful build

2023-08-13 Thread Lucas Nussbaum
Source: pipexec
Version: 2.6.1-2
Severity: minor
Tags: trixie sid ftbfs
User: lu...@debian.org
Usertags: ftbfs-sab-20230813 ftbfs-source-after-build
User: debian...@lists.debian.org
Usertags: qa-doublebuild

Hi,

This package fails to build a source package after a successful build
(dpkg-buildpackage ; dpkg-buildpackage -S).

This is probably a clear violation of Debian Policy section 4.9 (clean target),
but this is filed as severity:minor for now, because a discussion on
debian-devel showed that we might want to revisit the requirement of a working
'clean' target.

More information about this class of issues, included common problems and
solutions, is available at
https://wiki.debian.org/qa.debian.org/FTBFS/SourceAfterBuild

Relevant part of the build log:
> cd /<> && runuser -u user42 -- dpkg-buildpackage --sanitize-env 
> -us -uc -rfakeroot -S
> -
> 
> dpkg-buildpackage: info: source package pipexec
> dpkg-buildpackage: info: source version 2.6.1-2
> dpkg-buildpackage: info: source distribution unstable
> dpkg-buildpackage: info: source changed by Thorsten Alteholz 
> 
>  dpkg-source --before-build .
>  debian/rules clean
> dh clean --with autoreconf
>dh_auto_clean
>   make -j8 distclean
> make[1]: Entering directory '/<>'
> test -z "" || rm -f 
> test -z "" || rm -f 
> rm -rf .libs _libs
> test -z "" || rm -f 
>  rm -f bin/pipexec bin/ptee bin/peet test/ptest
> rm -rf bin/.libs bin/_libs
> rm -f *.o
> test -z "" || rm -f 
> rm -f *.lo
> rm -f *.tab.c
> rm -rf test/.libs test/_libs
> rm -f src/*.o
> test -z "" || rm -f 
> test -z "" || rm -f 
> rm -f config.h stamp-h1
> rm -f libtool config.lt
> rm -f test/*.o
> test -z "test-suite.log" || rm -f test-suite.log
> rm -f TAGS ID GTAGS GRTAGS GSYMS GPATH tags
> test . = "." || test -z "" || rm -f 
> rm -f bin/.dirstamp
> rm -f cscope.out cscope.in.out cscope.po.out cscope.files
> rm -f src/.deps/.dirstamp
> rm -f src/.dirstamp
> rm -f test/.deps/.dirstamp
> rm -f test/.dirstamp
> rm -f config.status config.cache config.log configure.lineno 
> config.status.lineno
> rm -f src/.deps/app_version.Po
> rm -f src/.deps/command_info.Po
> rm -f src/.deps/logging.Po
> rm -f src/.deps/peet.Po
> rm -f src/.deps/pipe_info.Po
> rm -f src/.deps/pipexec.Po
> rm -f src/.deps/ptee.Po
> rm -f src/.deps/version.Po
> rm -f test/.deps/ptest.Po
> rm -f Makefile
> make[1]: Leaving directory '/<>'
>dh_autoreconf_clean
>dh_clean
>  dpkg-source -b .
> dpkg-source: info: using source format '3.0 (quilt)'
> dpkg-source: info: building pipexec using existing ./pipexec_2.6.1.orig.tar.xz
> dpkg-source: warning: ignoring deletion of file ltmain.sh, use 
> --include-removal to override
> dpkg-source: warning: ignoring deletion of directory autom4te.cache
> dpkg-source: warning: ignoring deletion of file autom4te.cache/requests, use 
> --include-removal to override
> dpkg-source: warning: ignoring deletion of file autom4te.cache/traces.2, use 
> --include-removal to override
> dpkg-source: warning: ignoring deletion of file autom4te.cache/output.2, use 
> --include-removal to override
> dpkg-source: warning: ignoring deletion of file autom4te.cache/output.1, use 
> --include-removal to override
> dpkg-source: warning: ignoring deletion of file autom4te.cache/traces.1, use 
> --include-removal to override
> dpkg-source: warning: ignoring deletion of file autom4te.cache/output.0, use 
> --include-removal to override
> dpkg-source: warning: ignoring deletion of file autom4te.cache/traces.0, use 
> --include-removal to override
> dpkg-source: info: local changes detected, the modified files are:
>  pipexec-2.6.1/src/app_version.c
> dpkg-source: error: aborting due to unexpected upstream changes, see 
> /tmp/pipexec_2.6.1-2.diff.EGyOJJ
> dpkg-source: info: Hint: make sure the version in debian/changelog matches 
> the unpacked source tree
> dpkg-source: info: you can integrate the local changes with dpkg-source 
> --commit
> dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 2
> 
> E: Command 'cd /<> && runuser -u user42 -- dpkg-buildpackage 
> --sanitize-env -us -uc -rfakeroot -S' failed to run.


The full build log is available from:
http://qa-logs.debian.net/2023/08/13/pipexec_2.6.1-2_unstable.log

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.