Bug#1046444: virtualjaguar: Fails to build source after successful build

2024-04-13 Thread John Paul Adrian Glaubitz
Hi,

On Sun, 2023-08-13 at 21:21 +0200, Lucas Nussbaum wrote:
> Relevant part of the build log:
> > cd /<> && runuser -u user42 -- dpkg-buildpackage 
> > --sanitize-env -us -uc -rfakeroot -S
> > -
> > 
> > dpkg-buildpackage: info: source package virtualjaguar
> > dpkg-buildpackage: info: source version 2.1.3-2
> > dpkg-buildpackage: info: source distribution unstable
> > dpkg-buildpackage: info: source changed by John Paul Adrian Glaubitz 
> > 
> >  dpkg-source --before-build .
> >  fakeroot debian/rules clean
> > dh clean
> > dh: warning: Compatibility levels before 10 are deprecated (level 9 in use)
> >dh_auto_clean
> > dh_auto_clean: warning: Compatibility levels before 10 are deprecated 
> > (level 9 in use)
> > make -j1 clean
> > make[1]: Entering directory '/<>'
> > -ne *** Cleaning out the garbage...
> > done!
> > make[1]: Leaving directory '/<>'
> >dh_clean
> > dh_clean: warning: Compatibility levels before 10 are deprecated (level 9 
> > in use)
> >  dpkg-source -b .
> > dpkg-source: info: using source format '3.0 (quilt)'
> > dpkg-source: info: building virtualjaguar using existing 
> > ./virtualjaguar_2.1.3.orig.tar.bz2
> > dpkg-source: info: using patch list from debian/patches/series
> > dpkg-source: warning: ignoring deletion of file src/m68000/m68kdasm.c.bak, 
> > use --include-removal to override
> > dpkg-source: info: local changes detected, the modified files are:
> >  virtualjaguar-2.1.3/.qmake.stash
> >  virtualjaguar-2.1.3/src/version.h
> > dpkg-source: error: aborting due to unexpected upstream changes, see 
> > /tmp/virtualjaguar_2.1.3-2.diff.v1VkyG
> > dpkg-source: info: Hint: make sure the version in debian/changelog matches 
> > the unpacked source tree
> > dpkg-source: info: you can integrate the local changes with dpkg-source 
> > --commit
> > dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 2
> > 
> > E: Command 'cd /<> && runuser -u user42 -- dpkg-buildpackage 
> > --sanitize-env -us -uc -rfakeroot -S' failed to run.

After close inspection of the build log and the original tarball, it turns out 
that the tarball
used is not identical to the one available from the upstream FTP server [1]:

glaubitz@z6:~/debian> wget -q 
http://icculus.org/virtualjaguar/tarballs/virtualjaguar-2.1.3.tar.bz2 -O 
virtualjaguar-upstream-2.1.3.tar.bz2
glaubitz@z6:~/debian> md5sum virtualjaguar-upstream-2.1.3.tar.bz2 
virtualjaguar_2.1.3.orig.tar.bz2 
17af87b3a7cfd9106e49afc56d4858e6  virtualjaguar-upstream-2.1.3.tar.bz2
0e3f30737c171c096ac2690a38f7029a  virtualjaguar_2.1.3.orig.tar.bz2
glaubitz@z6:~/debian>

Further inspection reveals that the file src/m68000/m68kdasm.c.bak that is 
deleted during build
and prevents a second successful build is not part of the original source:

glaubitz@z6:~/debian> tar tf virtualjaguar_2.1.3.orig.tar.bz2 |grep bak
linux-2.1.3/src/m68000/m68kdasm.c.bak
glaubitz@z6:~/debian> tar tf virtualjaguar-upstream-2.1.3.tar.bz2  |grep bak
glaubitz@z6:~/debian>

I don't really remember how I created the first upload of the 2.1.3 upstream 
version, but since
upstream development has ceased, I can upload a fixed version only with a 
forged upstream version
using "really" or similar since there won't be a new upstream release unless 
the upstream project
is forked.

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913



Bug#1046444: virtualjaguar: Fails to build source after successful build

2023-08-13 Thread Lucas Nussbaum
Source: virtualjaguar
Version: 2.1.3-2
Severity: minor
Tags: trixie sid ftbfs
User: lu...@debian.org
Usertags: ftbfs-sab-20230813 ftbfs-source-after-build
User: debian...@lists.debian.org
Usertags: qa-doublebuild

Hi,

This package fails to build a source package after a successful build
(dpkg-buildpackage ; dpkg-buildpackage -S).

This is probably a clear violation of Debian Policy section 4.9 (clean target),
but this is filed as severity:minor for now, because a discussion on
debian-devel showed that we might want to revisit the requirement of a working
'clean' target.

More information about this class of issues, included common problems and
solutions, is available at
https://wiki.debian.org/qa.debian.org/FTBFS/SourceAfterBuild

Relevant part of the build log:
> cd /<> && runuser -u user42 -- dpkg-buildpackage --sanitize-env 
> -us -uc -rfakeroot -S
> -
> 
> dpkg-buildpackage: info: source package virtualjaguar
> dpkg-buildpackage: info: source version 2.1.3-2
> dpkg-buildpackage: info: source distribution unstable
> dpkg-buildpackage: info: source changed by John Paul Adrian Glaubitz 
> 
>  dpkg-source --before-build .
>  fakeroot debian/rules clean
> dh clean
> dh: warning: Compatibility levels before 10 are deprecated (level 9 in use)
>dh_auto_clean
> dh_auto_clean: warning: Compatibility levels before 10 are deprecated (level 
> 9 in use)
>   make -j1 clean
> make[1]: Entering directory '/<>'
> -ne *** Cleaning out the garbage...
> done!
> make[1]: Leaving directory '/<>'
>dh_clean
> dh_clean: warning: Compatibility levels before 10 are deprecated (level 9 in 
> use)
>  dpkg-source -b .
> dpkg-source: info: using source format '3.0 (quilt)'
> dpkg-source: info: building virtualjaguar using existing 
> ./virtualjaguar_2.1.3.orig.tar.bz2
> dpkg-source: info: using patch list from debian/patches/series
> dpkg-source: warning: ignoring deletion of file src/m68000/m68kdasm.c.bak, 
> use --include-removal to override
> dpkg-source: info: local changes detected, the modified files are:
>  virtualjaguar-2.1.3/.qmake.stash
>  virtualjaguar-2.1.3/src/version.h
> dpkg-source: error: aborting due to unexpected upstream changes, see 
> /tmp/virtualjaguar_2.1.3-2.diff.v1VkyG
> dpkg-source: info: Hint: make sure the version in debian/changelog matches 
> the unpacked source tree
> dpkg-source: info: you can integrate the local changes with dpkg-source 
> --commit
> dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 2
> 
> E: Command 'cd /<> && runuser -u user42 -- dpkg-buildpackage 
> --sanitize-env -us -uc -rfakeroot -S' failed to run.


The full build log is available from:
http://qa-logs.debian.net/2023/08/13/virtualjaguar_2.1.3-2_unstable.log

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.