Bug#1050164: [Debian-med-packaging] Bug#1050164: libleidenalg: missing symbols with newer glibc/lto

2023-08-21 Thread Étienne Mollier 
Control: tags -1 + confirmed

Hi Gianfranco,

Gianfranco Costamagna, on 2023-08-21:
> I found in Ubuntu that 4 symbols are disappearing, probably due to lto and 
> them being virtually provided.
> I think it might be useful to mark them as optional, to avoid FTBFS with lto 
> or newer gcc versions.
> 
> Thanks for considering the patch.

I haven't tested this library with optimize=+lto yet, so thanks
for checking!  The symbols you flag are consistent with my own
verification.  I consider applying your patch.

Have a nice day,  :)
-- 
  .''`.  Étienne Mollier 
 : :' :  gpg: 8f91 b227 c7d6 f2b1 948c  8236 793c f67e 8f0d 11da
 `. `'   sent from /dev/pts/1, please excuse my verbosity
   `-


signature.asc
Description: PGP signature

Bug#1050164: libleidenalg: missing symbols with newer glibc/lto

2023-08-21 Thread Gianfranco Costamagna 

Package: libleidenalg
Version: 0.11.1-1
Severity: normal
Tags: patch


Dear Maintainer,
I found in Ubuntu that 4 symbols are disappearing, probably due to lto and them 
being virtually provided.
I think it might be useful to mark them as optional, to avoid FTBFS with lto or 
newer gcc versions.

Thanks for considering the patch.

*** /tmp/tmpzbxu077g/libleidenalg_0.11.1-1.1.debdiff
diff -Nru libleidenalg-0.11.1/debian/liblibleidenalg1.symbols.amd64 
libleidenalg-0.11.1/debian/liblibleidenalg1.symbols.amd64
--- libleidenalg-0.11.1/debian/liblibleidenalg1.symbols.amd64   2023-08-16 
18:22:12.0 +0200
+++ libleidenalg-0.11.1/debian/liblibleidenalg1.symbols.amd64   2023-08-21 
10:15:01.0 +0200
@@ -55,9 +55,9 @@
  _ZN22MutableVertexPartition6cnodesEm@Base 0.11.1
  _ZN22MutableVertexPartition6createEP5Graph@Base 0.11.1
  _ZN22MutableVertexPartition6createEP5GraphRKSt6vectorImSaImEE@Base 0.11.1
- _ZN22MutableVertexPartition7qualityEv@Base 0.11.1
+ (optional)_ZN22MutableVertexPartition7qualityEv@Base 0.11.1
  _ZN22MutableVertexPartition9clean_memEv@Base 0.11.1
- _ZN22MutableVertexPartition9diff_moveEmm@Base 0.11.1
+ (optional)_ZN22MutableVertexPartition9diff_moveEmm@Base 0.11.1
  _ZN22MutableVertexPartition9move_nodeEmm@Base 0.11.1
  _ZN22MutableVertexPartitionC1EP5Graph@Base 0.11.1
  _ZN22MutableVertexPartitionC1EP5GraphRKSt6vectorImSaImEE@Base 0.11.1
@@ -114,8 +114,8 @@
  _ZN30RBConfigurationVertexPartitionD0Ev@Base 0.11.1
  _ZN30RBConfigurationVertexPartitionD1Ev@Base 0.11.1
  _ZN30RBConfigurationVertexPartitionD2Ev@Base 0.11.1
- _ZN34ResolutionParameterVertexPartition7qualityEd@Base 0.11.1
- _ZN34ResolutionParameterVertexPartition7qualityEv@Base 0.11.1
+ (optional)_ZN34ResolutionParameterVertexPartition7qualityEd@Base 0.11.1
+ (optional)_ZN34ResolutionParameterVertexPartition7qualityEv@Base 0.11.1
  _ZN34ResolutionParameterVertexPartitionC1EP5Graph@Base 0.11.1
  _ZN34ResolutionParameterVertexPartitionC1EP5GraphSt6vectorImSaImEE@Base 0.11.1
  _ZN34ResolutionParameterVertexPartitionC1EP5GraphSt6vectorImSaImEEd@Base 
0.11.1


OpenPGP_signature
Description: OpenPGP digital signature