Bug#1051150: RFS: blender-doc/3.6-1 [ITP] -- Blender Manual by the Blender Foundation
Hey Hugh, I have added a README.source file detailing the need for git-lfs to build, and updated the changelog timestamp. If there is further action required, please let me know. Best Regards, Jonathan Rubenstein
Bug#1051150: RFS: blender-doc/3.6-1 [ITP] -- Blender Manual by the Blender Foundation
Hi Jonathan, Thanks for your work on this package. Just two more things to do. On Tue, 3 Oct 2023 at 05:53, Jonathan Rubenstein wrote: > > Hey, I've implemented the requested changes, again with some > questions/exceptions. > > > * Not all files in tools*/* are explicitly marked Apache-2.0, but > > given most are, I think it's okay to assume that. In any case, the > > attributable copyright is the same as for the main package. > > Not sure if this is asking for any particular action or just a comment > on the situation. That was just a comment. 1. Add a debian/README.source file and add a comment that says package builders must install the package git-lfs before cloning upstream's git repository. 2. Run `dch -r` to update the timestamp in d/changelog. Once both of those items are done, please upload the final version to Debian Mentors, and we should be good to go. Hugh
Bug#1051150: RFS: blender-doc/3.6-1 [ITP] -- Blender Manual by the Blender Foundation
Hey, I've implemented the requested changes, again with some questions/exceptions. * Not all files in tools*/* are explicitly marked Apache-2.0, but given most are, I think it's okay to assume that. In any case, the attributable copyright is the same as for the main package. Not sure if this is asking for any particular action or just a comment on the situation. Please change your source overrides to the following: # This may appear to be a binary file to lintian, but it's not source-is-missing [resources/templates/footer.html] # WebP graphics files; resources/templates/footer.html very-long-line-length-in-source-file I've done this but kept the "blender-doc source:" portions at the beginning. It doesn't do anything really, but I feel better about having it there. These changes were again uploaded to mentors.debian.net, please let me know if there's something I still missed. Best Regards, Jonathan Rubenstein
Bug#1051150: RFS: blender-doc/3.6-1 [ITP] -- Blender Manual by the Blender Foundation
Hi Jonathan, On Wed, 27 Sept 2023 at 05:48, Jonathan Rubenstein wrote: > > Control: tags -1 - moreinfo > > Hey, I have completed the requested changes with a few exceptions. Nice work. We're almost there. d/copyright: * Please update your explanatory comment to the following: Comment: A cursory search will find many ":License: GPL" lines in these files. Those ":License: GPL" lines are part of a template describing other software that is GPL-licensed but not included in this package. The file containing the template (and the template itself) is licensed as CC-BY-SA-4.0. * Email addresses are optional in Files stanzas. I don't include them because I find they add clutter, but it's a personal choice. * Not all files in tools*/* are explicitly marked Apache-2.0, but given most are, I think it's okay to assume that. In any case, the attributable copyright is the same as for the main package. d/control: * Remove versioned dependency from libjs-mathjax. d/rules: * In override_dh_auto_build, the `export` command should only appear once, and only at the start of the line. d/source/overrides: * I see you added an override for 'very-long-line-length-in-source-file' in 'resources/templates/footer.html'. Lintian also emits the tag for a lot of .webp graphics files, so let's take care of them all with one global override. Please change your source overrides to the following: # This may appear to be a binary file to lintian, but it's not source-is-missing [resources/templates/footer.html] # WebP graphics files; resources/templates/footer.html very-long-line-length-in-source-file
Bug#1051150: RFS: blender-doc/3.6-1 [ITP] -- Blender Manual by the Blender Foundation
Control: tags -1 - moreinfo Hey, I have completed the requested changes with a few exceptions. * You are missing several files that are GPL-licensed. I saw them in the Add-ons section. Please check every file in the source package carefully I added an explicit clarification to debian/copyright that hopefully resolves this. The files in the Add-ons sections are not GPL-licensed themselves but mention GPL-licensed software, which shows up when grepping for "license" (or "GPL"), but is not actually indicative of the file's license. Please let me know if this clarification needs further changes or amendments. * In the short and (long) binary package description, please indicate the manual is in HTML format. I have mentioned this in the long description but not the short description, as I have seen many other documentation packages which don't mention documentation format in the short description, only the long description, [1] and I think it degrades the short description. That information would certainly be beneficial in the short description if there were more than one package containing different builds, like blender-doc-html and blender-doc-pdf; but there is only one package named blender-doc, so I don't really want to add that to the short description. Otherwise, I have checked lintian notes and fixed a few of them that I missed before. I have also submitted a bug to upstream here about the jpg-png type mismatch: https://projects.blender.org/blender/blender-manual/issues/104565 I have uploaded my changes again for review to mentors.debian.net. Does everything look good now? Regards, Jonathan Rubenstein [1]: apache2-doc, bzip2-doc, aptitude-doc-en, docutils-doc, linux-doc-*
Bug#1051150: RFS: blender-doc/3.6-1 [ITP] -- Blender Manual by the Blender Foundation
Control: tags -1 moreinfo Hi Jonathan, On Sun, 3 Sep 2023 17:51:51 +0300 Jonathan Rubenstein wrote: > Package: sponsorship-requests > Severity: wishlist > > Dear mentors, > > I am looking for a sponsor for my package "blender-doc": > > * Package name : blender-doc > Version : 3.6-1 > Upstream contact : Blender Documentation Team > * URL : https://docs.blender.org/manual/ > * License : Apache-2.0, GPL-2.0-or-later, MIT, CC-BY-SA-4.0 > * Vcs : https://salsa.debian.org/JJRcop/blender-doc > Section : doc For your first package, this is great. Now, let's make it even better. :) d/copyright: * Please restructure this file so your licence stanzas are at the bottom. The order of stanzas is header, files, licences. * Please start filenames/paths and copyright information directly after the field name, so: Files: XXX Copyright: XX. Multiple lines can be aligned with spaces. * You are missing several files that are GPL-licensed. I saw them in the Add-ons section. Please check every file in the source package carefully. * You need to add a copyright stanza for debian/*, attributed to you. GPL-2.0-or-later is often a good choice here, but it's your decision. d/control: * You don't need to specify versions for your (build-)dependencies, as we're targeting sid/unstable. The exception is debhelper-compat, which does need to be versioned (= 13). * In the short and (long) binary package description, please indicate the manual is in HTML format. d/rules: * Please combine your dh_auto_build overrides and exports into a single recipe: override_dh_auto_build: export http_proxy=127.0.0.1:9 https_proxy=127.0.0.1:9 PYTHONPATH=. dh_auto_build -- html * To disable the dh_auto_tests, add `export DEB_BUILD_OPTIONS += nocheck` to the top of d/rules and remove the override. * Please add a line break between each target. d/upstream/metadata * Please add the Bug-Database, Bug-Submit and Changelog fields as flagged by Lintian. d/source/overrides * While the line in footer.html is very long, it is not a binary. It's actually a hyperlink that creates a new bug report upstream. Please also override the very-long-line-length-in-source-file tag (refer to your blender-doc mentors page to see what I mean). d/blender-doc.doc-base: * Is there a reason you've limited the line length to ~40 characters? You can go up to 79, although you probably want less so the lines look more balanced. d/blender-doc.install: * Install paths don't need a forward slash (/usr -> usr). You can also simplify the line to: build/html usr/share/doc/blender-doc * Please run Lintian using `lintian -EviI *amd64.changes` and review the output. + Lintian identified some images files that have a .jpg extension but according to `file` are actually PNG files. You might want to raise this discrepancy with upstream. + Lintian also identified file-references-package-build-path when blender-doc is built via sbuild. This could be another upstream bug. Once you've addressed all of the points above, please remove the 'moreinfo' tag and I'll have another look. It might take me a few days to get back to you once you've done that. Hugh
Bug#1051150: RFS: blender-doc/3.6-1 [ITP] -- Blender Manual by the Blender Foundation
Hi, where should I mention my RFS to hopefully get a sponsor? If anyone reading this is interested of course please respond, but there might be a suitable place with relevant uploaders who might be interested in sponsoring that I'm not aware of. Any help is appreciated. Best Regards, Jonathan Rubenstein
Bug#1051150: RFS: blender-doc/3.6-1 [ITP] -- Blender Manual by the Blender Foundation
Hey, I am pinging this RFS as I am still interested in a sponsor. I'm sure someone from debian-multimedia would be the most suitable for this purpose as they maintain the blender package, but their wiki page https://wiki.debian.org/DebianMultimedia/Sponsoring says > In general, we don't do sponsoring. So for the moment I am not bothering them, however, if I should then let me know! Regards, Jonathan Rubenstein
Bug#1051150: RFS: blender-doc/3.6-1 [ITP] -- Blender Manual by the Blender Foundation
Package: sponsorship-requests Severity: wishlist Dear mentors, I am looking for a sponsor for my package "blender-doc": * Package name : blender-doc Version : 3.6-1 Upstream contact : Blender Documentation Team * URL : https://docs.blender.org/manual/ * License : Apache-2.0, GPL-2.0-or-later, MIT, CC-BY-SA-4.0 * Vcs : https://salsa.debian.org/JJRcop/blender-doc Section : doc The source builds the following binary packages: blender-doc - Blender Manual by the Blender Foundation To access further information about this package, please visit the following URL: https://mentors.debian.net/package/blender-doc/ Alternatively, you can download the package with 'dget' using this command: dget -x https://mentors.debian.net/debian/pool/main/b/blender-doc/blender-doc_3.6-1.dsc Changes for the initial release: blender-doc (3.6-1) unstable; urgency=medium . * Initial release. (Closes: #1006255) Additional notes: I have already attempted this a little over a year ago in #1017875 but didn't get around to fixing the copyright issues; these are now fixed and the debian/copyright file should include all of the correct copyright attributions (all are compatible with DFSG to my knowledge). Additionally, I have added the lintian-override as suggested in my first attempt. I intend to maintain this package, but if it should be transitioned to a team, that's fine as well. It's quite simple to update as the patchset is very light and everything generally works out of the box especially with the sphinx debhelper tools. Please let me know if any further changes are required, I should be more responsive this time. Regards, -- Jonathan Rubenstein
