Bug#1053443: automount should not act if filesystem is already mounted
On Sun, May 26, 2024 at 06:30:34PM +0100, Luca Boccassi wrote: > This is not something that is appropriate to patch downstream, even if > it was desirable. Just for the record, I disagree. This is integration work and thus well inside the authority of a cooperative package maintainer in a distribution. I appreciate your trying to be helpful. -- - Marc Haber | "I don't trust Computers. They | Mailadresse im Header Leimen, Germany| lose things."Winona Ryder | Fon: *49 6224 1600402 Nordisch by Nature | How to make an American Quilt | Fax: *49 6224 1600421
Bug#1053443: automount should not act if filesystem is already mounted
On Sun, 26 May 2024 18:57:31 +0200 Marc Haber wrote: > On Sun, May 26, 2024 at 05:53:01PM +0100, Luca Boccassi wrote: > > So yeah, not going to risk this for the benefit of a non-default > > package with 0.19% popcon, sorry. Feel free to document the workaround > > and link to this bug as you see fit. I'd recommend noting the FS > > corruption issues too, but that's up to you of course. > > I just suggested the automounter to not try to mount a filesystem that > is already there. I am not a systemd expert, but that should be a > minimally invasive oneliner, not changing other system's behavior, > shouldn't it? Feel free to propose any change you want to see with a PR upstream. This is not something that is appropriate to patch downstream, even if it was desirable. -- Kind regards, Luca Boccassi signature.asc Description: This is a digitally signed message part
Bug#1053443: automount should not act if filesystem is already mounted
On Sun, May 26, 2024 at 05:53:01PM +0100, Luca Boccassi wrote: > So yeah, not going to risk this for the benefit of a non-default > package with 0.19% popcon, sorry. Feel free to document the workaround > and link to this bug as you see fit. I'd recommend noting the FS > corruption issues too, but that's up to you of course. I just suggested the automounter to not try to mount a filesystem that is already there. I am not a systemd expert, but that should be a minimally invasive oneliner, not changing other system's behavior, shouldn't it? -- - Marc Haber | "I don't trust Computers. They | Mailadresse im Header Leimen, Germany| lose things."Winona Ryder | Fon: *49 6224 1600402 Nordisch by Nature | How to make an American Quilt | Fax: *49 6224 1600421
Bug#1053443: automount should not act if filesystem is already mounted
On Sun, 26 May 2024 at 17:37, Marc Haber wrote: > > On Sun, May 26, 2024 at 04:57:10PM +0100, Luca Boccassi wrote: > > I am pretty sure this is working as intended, we do not want the ESP to > > be always mounted by default. You can disable this generator in > > multiple ways if you don't want this behaviour - via the cmdline as > > already mentioned, or by masking it with: > > > > touch /etc/systemd/system-generators/systemd-gpt-auto-generator > > Okay, this is then going as documentation into aide's systemd rule in > Debian with a link to this bug report. > > Thanks for being a friendly neighbor to other packages. It is a well known issue that keeping the ESP persistently mounted causes filesystem corruption which means boot failures, because FAT32 is what it is. They do it on Fedora for example, and it is a constant source of problems: https://bugzilla.redhat.com/show_bug.cgi?id=1077984 So yeah, not going to risk this for the benefit of a non-default package with 0.19% popcon, sorry. Feel free to document the workaround and link to this bug as you see fit. I'd recommend noting the FS corruption issues too, but that's up to you of course.
Bug#1053443: automount should not act if filesystem is already mounted
On Sun, May 26, 2024 at 04:57:10PM +0100, Luca Boccassi wrote: > I am pretty sure this is working as intended, we do not want the ESP to > be always mounted by default. You can disable this generator in > multiple ways if you don't want this behaviour - via the cmdline as > already mentioned, or by masking it with: > > touch /etc/systemd/system-generators/systemd-gpt-auto-generator Okay, this is then going as documentation into aide's systemd rule in Debian with a link to this bug report. Thanks for being a friendly neighbor to other packages. -- - Marc Haber | "I don't trust Computers. They | Mailadresse im Header Leimen, Germany| lose things."Winona Ryder | Fon: *49 6224 1600402 Nordisch by Nature | How to make an American Quilt | Fax: *49 6224 1600421
Bug#1053443: automount should not act if filesystem is already mounted
Control: tags -1 wontfix Control: close -1 On Wed, 4 Oct 2023 20:51:57 +0200 Marc Haber wrote: > On Wed, Oct 04, 2023 at 08:41:10PM +0200, Michael Biebl wrote: > > Do you both /efi *and* /boot/efi > > > > The automount unit is for efi.automount > > No, just /boot/efi, but the aide run triggers the automount, which > affects for some strange reason /boot/efi and makes the inode numbers > change. I am pretty sure this is working as intended, we do not want the ESP to be always mounted by default. You can disable this generator in multiple ways if you don't want this behaviour - via the cmdline as already mentioned, or by masking it with: touch /etc/systemd/system-generators/systemd-gpt-auto-generator -- Kind regards, Luca Boccassi signature.asc Description: This is a digitally signed message part
Bug#1053443: automount should not act if filesystem is already mounted
On Wed, Oct 04, 2023 at 08:41:10PM +0200, Michael Biebl wrote: > Do you both /efi *and* /boot/efi > > The automount unit is for efi.automount No, just /boot/efi, but the aide run triggers the automount, which affects for some strange reason /boot/efi and makes the inode numbers change. Greetings Marc -- - Marc Haber | "I don't trust Computers. They | Mailadresse im Header Leimen, Germany| lose things."Winona Ryder | Fon: *49 6224 1600402 Nordisch by Nature | How to make an American Quilt | Fax: *49 6224 1600421
Bug#1053443: automount should not act if filesystem is already mounted
Do you both /efi *and* /boot/efi The automount unit is for efi.automount OpenPGP_signature.asc Description: OpenPGP digital signature
Bug#1053443: automount should not act if filesystem is already mounted
Am 04.10.23 um 08:38 schrieb Marc Haber: Package: systemd Version: 254.5-1 Severity: minor File: /usr/share/man/man8/systemd-gpt-auto-generator.8.gz Hi, on my systems, /boot/efi is mounted via /etc/fstab. I am not sure whether this is wrong, but I'd like it to be mounted all the time and stay mounted. When aide runs, a generated efi.automount is invoked and mounts /boot/efi again over the already mounted filesystem. Since the EFI partition is a vfat filesystem which doesn't have inodes, the inode values are synthesized differently for every aide run, which triggers a security mechanism in aide since aide now thinks that somebody is trying to move a different file in place between file enumeration and checksum building. Could the generated automounter please grow a condition to not act if the filesystem in question is already mounted? hm, that sounds like a bug. Reading man systemd-gpt-auto-generator ''' The ESP is mounted to /boot/ if that directory exists and is not used for XBOOTLDR, and otherwise to /efi/. Same as for /boot/, an automount unit is used. The mount point will be created if necessary. No configuration is created for mount points that are configured in fstab(5) or when the target directory contains files. ''' You can disable systemd-gpt-auto-generator via the systemd.gpt_auto=0 kernel command line parameter until this is addressed. Michael OpenPGP_signature.asc Description: OpenPGP digital signature
