Bug#1054306: Please install helper binaries into /usr/libexec

2023-10-24 Thread Douglas Kosovic 
> If I do an update from a previously installed version using the following 
> command:
> 
>  sudo debi -u network-manager-l2tp_1.20.10-1_amd64.changes

I meant upgrade, not update.

> I get the following error when trying to establish a L2TP VPN
> connection:
> 
>  ... starting: failure to start VPN service: Failed to
> execute child process "/usr/lib/NetworkManager/nm-l2tp-service"
> (No such file or directory)


For whatever reason, I'm no longer able to reproduce the issue. Although I did 
have to restart NetworkManager once when I got that "Failed to execute child 
process /usr/lib/NetworkManager/nm-l2tp-service" which makes more sense than my 
previous nm-l2tp-service.name file not getting upgraded issue.

I don't think there is anything wrong with the new network-manager-l2tp 
1.20.10-1 package in regards to the nm-l2tp-service.name file issue, so think I 
will upload the new version.



Doug

Bug#1054306: Please install helper binaries into /usr/libexec

2023-10-23 Thread Douglas Kosovic 
Hi Michael,

> For consistencies sake, please consider applying the attached patch,
> which moves the helper binaries to /usr/libexec.


There was a new upstream version, so I updated to the newest version and 
incorporated the patch.

If I do an update from a previously installed version using the following 
command:

  sudo debi -u network-manager-l2tp_1.20.10-1_amd64.changes

I get the following error when trying to establish a L2TP  VPN connection:

 ... starting: failure to start VPN service: Failed to execute child 
process "/usr/lib/NetworkManager/nm-l2tp-service" (No such file or directory)

It looks like /usr/lib/NetworkManager/VPN/nm-l2tp-service.name which has the 
following line is not getting replaced in an upgrade:
   program=/usr/lib/NetworkManager/nm-l2tp-service

There is no issue when I remove the old network-manager-l2tp packages and do a 
clean install.

I haven't looked into it further yet.


Cheers,
Doug

Bug#1054306: Please install helper binaries into /usr/libexec

2023-10-21 Thread Michael Biebl 
Source: network-manager-l2tp
Version: 1.20.8-1
Severity: wishlist
Tags: patch
User: bi...@debian.org
Usertags: nm-libexec

Hi,

your package installs helper binaries that are currently located in
/usr/lib/NetworkManager.
Now that Debian policy allows to install such binaries into
/usr/libexec, it was requested in [1] that the network-manager package
is updated to use this location to align with other distros and avoid
unnecessary friction.

The network-manager package and the vpn packages maintained by the
pkg-utopia team have been updated accordingly.

For consistencies sake, please consider applying the attached patch,
which moves the helper binaries to /usr/libexec.

Thanks,
Michael



[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1026388
diff -Nru network-manager-l2tp-1.20.8/debian/changelog 
network-manager-l2tp-1.20.8/debian/changelog
--- network-manager-l2tp-1.20.8/debian/changelog2022-12-30 
23:30:00.0 +0100
+++ network-manager-l2tp-1.20.8/debian/changelog2023-10-21 
12:55:13.0 +0200
@@ -1,3 +1,10 @@
+network-manager-l2tp (1.20.8-1.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Install helper binaries into /usr/libexec (Closes: #-1)
+
+ -- Michael Biebl   Sat, 21 Oct 2023 12:55:13 +0200
+
 network-manager-l2tp (1.20.8-1) unstable; urgency=medium
 
   * New upstream release
diff -Nru network-manager-l2tp-1.20.8/debian/network-manager-l2tp-gnome.install 
network-manager-l2tp-1.20.8/debian/network-manager-l2tp-gnome.install
--- network-manager-l2tp-1.20.8/debian/network-manager-l2tp-gnome.install   
2022-04-18 13:45:26.0 +0200
+++ network-manager-l2tp-1.20.8/debian/network-manager-l2tp-gnome.install   
2023-10-21 12:52:37.0 +0200
@@ -1,4 +1,4 @@
+usr/libexec/nm-l2tp-auth-dialog
 usr/lib/*/NetworkManager/libnm-vpn-plugin-l2tp-editor.so
 usr/lib/*/NetworkManager/libnm-gtk4-vpn-plugin-l2tp-editor.so
-usr/lib/NetworkManager/nm-l2tp-auth-dialog
 usr/share/metainfo/network-manager-l2tp.metainfo.xml
diff -Nru network-manager-l2tp-1.20.8/debian/network-manager-l2tp.install 
network-manager-l2tp-1.20.8/debian/network-manager-l2tp.install
--- network-manager-l2tp-1.20.8/debian/network-manager-l2tp.install 
2019-11-04 14:58:04.0 +0100
+++ network-manager-l2tp-1.20.8/debian/network-manager-l2tp.install 
2023-10-21 12:55:02.0 +0200
@@ -1,6 +1,6 @@
 usr/lib/pppd/*/*.so
+usr/libexec/nm-l2tp-service
 usr/lib/NetworkManager/VPN/nm-l2tp-service.name
-usr/lib/NetworkManager/nm-l2tp-service
 usr/lib/*/NetworkManager/libnm-vpn-plugin-l2tp.so
 usr/share/dbus-1/
 usr/share/locale/
diff -Nru network-manager-l2tp-1.20.8/debian/rules 
network-manager-l2tp-1.20.8/debian/rules
--- network-manager-l2tp-1.20.8/debian/rules2022-12-30 23:21:06.0 
+0100
+++ network-manager-l2tp-1.20.8/debian/rules2023-10-21 12:52:24.0 
+0200
@@ -9,7 +9,6 @@
 
 override_dh_auto_configure:
dh_auto_configure -- \
-   --libexecdir=/usr/lib/NetworkManager \
--with-gtk4 \
--disable-static \
--with-pppd-plugin-dir=$(PPPD_PLUGIN_DIR)