Bug#1054309: Please install helper binaries into /usr/libexec

2023-10-21 Thread Eivind Næss
I have yet to release another version of the software for use with PPP 2.5.0. 
I'll look at merging the patch into the upstream repositoru

Sent from Outlook for Android<https://aka.ms/AAb9ysg>

From: Eivind Næss 
Sent: Saturday, October 21, 2023 10:52:13 AM
To: Michael Biebl ; 1054...@bugs.debian.org 
<1054...@bugs.debian.org>
Subject: Re: Bug#1054309: Please install helper binaries into /usr/libexec

Thank you!!


With two small kids, I would not be able to tend to the matter before after 
their bed times ...

Eivind

Sent from Outlook for Android<https://aka.ms/AAb9ysg>


From: Michael Biebl 
Sent: Saturday, October 21, 2023 10:47:40 AM
To: Eivind Næss ; 1054...@bugs.debian.org 
<1054...@bugs.debian.org>
Subject: Re: Bug#1054309: Please install helper binaries into /usr/libexec

Am 21.10.23 um 18:57 schrieb Michael Biebl:
> Thanks for your feedback/review.
>
> I completely missed that the package is actually within the utopia-team
> salsa group:
> https://salsa.debian.org/utopia-team/network-manager-sstp
>
> I will therefor update the package in Git and make a team upload.

Uploaded as 1.3.1-2 (including the fixes for #1049813, #1046985.

Regards,
Michael




Bug#1054309: Please install helper binaries into /usr/libexec

2023-10-21 Thread Eivind Næss
Thank you!!


With two small kids, I would not be able to tend to the matter before after 
their bed times ...

Eivind

Sent from Outlook for Android<https://aka.ms/AAb9ysg>


From: Michael Biebl 
Sent: Saturday, October 21, 2023 10:47:40 AM
To: Eivind Næss ; 1054...@bugs.debian.org 
<1054...@bugs.debian.org>
Subject: Re: Bug#1054309: Please install helper binaries into /usr/libexec

Am 21.10.23 um 18:57 schrieb Michael Biebl:
> Thanks for your feedback/review.
>
> I completely missed that the package is actually within the utopia-team
> salsa group:
> https://salsa.debian.org/utopia-team/network-manager-sstp
>
> I will therefor update the package in Git and make a team upload.

Uploaded as 1.3.1-2 (including the fixes for #1049813, #1046985.

Regards,
Michael




Bug#1054309: Please install helper binaries into /usr/libexec

2023-10-21 Thread Michael Biebl

Am 21.10.23 um 18:57 schrieb Michael Biebl:

Thanks for your feedback/review.

I completely missed that the package is actually within the utopia-team 
salsa group:

https://salsa.debian.org/utopia-team/network-manager-sstp

I will therefor update the package in Git and make a team upload.


Uploaded as 1.3.1-2 (including the fixes for #1049813, #1046985.

Regards,
Michael



OpenPGP_signature.asc
Description: OpenPGP digital signature


Bug#1054309: Please install helper binaries into /usr/libexec

2023-10-21 Thread Michael Biebl

Thanks for your feedback/review.

I completely missed that the package is actually within the utopia-team 
salsa group:

https://salsa.debian.org/utopia-team/network-manager-sstp

I will therefor update the package in Git and make a team upload.

Regards,
Michael


Am 21.10.23 um 18:43 schrieb Eivind Næss:

Sounds good to me.

Sent from Outlook for Android <https://aka.ms/AAb9ysg>

*From:* Michael Biebl 
*Sent:* Saturday, October 21, 2023 4:42:25 AM
*To:* Debian Bug Tracking System 
*Subject:* Bug#1054309: Please install helper binaries into /usr/libexec
Source: network-manager-sstp
Version: 1.3.1-1
Severity: wishlist
Tags: patch
User: bi...@debian.org
Usertags: nm-libexec

Hi,

your package installs helper binaries that are currently located in
/usr/lib/NetworkManager.
Now that Debian policy allows to install such binaries into
/usr/libexec, it was requested in [1] that the network-manager package
is updated to use this location to align with other distros and avoid
unnecessary friction.

The network-manager package and the vpn packages maintained by the
pkg-utopia team have been updated accordingly.

For consistencies sake, please consider applying the attached patch,
which moves the helper binaries to /usr/libexec.

Thanks,
Michael


[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1026388 
<https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1026388>




OpenPGP_signature.asc
Description: OpenPGP digital signature


Bug#1054309: Please install helper binaries into /usr/libexec

2023-10-21 Thread Michael Biebl
Source: network-manager-sstp
Version: 1.3.1-1
Severity: wishlist
Tags: patch
User: bi...@debian.org
Usertags: nm-libexec

Hi,

your package installs helper binaries that are currently located in
/usr/lib/NetworkManager.
Now that Debian policy allows to install such binaries into
/usr/libexec, it was requested in [1] that the network-manager package
is updated to use this location to align with other distros and avoid
unnecessary friction.

The network-manager package and the vpn packages maintained by the
pkg-utopia team have been updated accordingly.

For consistencies sake, please consider applying the attached patch,
which moves the helper binaries to /usr/libexec.

Thanks,
Michael


[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1026388
diff -Nru network-manager-sstp-1.3.1/debian/changelog 
network-manager-sstp-1.3.1/debian/changelog
--- network-manager-sstp-1.3.1/debian/changelog 2022-09-19 16:40:56.0 
+0200
+++ network-manager-sstp-1.3.1/debian/changelog 2023-10-21 13:10:17.0 
+0200
@@ -1,3 +1,10 @@
+network-manager-sstp (1.3.1-1.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Install helper binaries into /usr/libexec (Closes: #-1)
+
+ -- Michael Biebl   Sat, 21 Oct 2023 13:10:17 +0200
+
 network-manager-sstp (1.3.1-1) unstable; urgency=medium
 
   [ Eivind Næss ]
diff -Nru network-manager-sstp-1.3.1/debian/network-manager-sstp-gnome.install 
network-manager-sstp-1.3.1/debian/network-manager-sstp-gnome.install
--- network-manager-sstp-1.3.1/debian/network-manager-sstp-gnome.install
2022-09-19 16:40:56.0 +0200
+++ network-manager-sstp-1.3.1/debian/network-manager-sstp-gnome.install
2023-10-21 13:10:01.0 +0200
@@ -1,4 +1,4 @@
+usr/libexec/nm-sstp-auth-dialog
 usr/lib/*/NetworkManager/libnm-vpn-plugin-sstp-editor.so
 usr/lib/*/NetworkManager/libnm-gtk4-vpn-plugin-sstp-editor.so
-usr/lib/NetworkManager/nm-sstp-auth-dialog
 usr/share/metainfo/network-manager-sstp.metainfo.xml
diff -Nru network-manager-sstp-1.3.1/debian/network-manager-sstp.install 
network-manager-sstp-1.3.1/debian/network-manager-sstp.install
--- network-manager-sstp-1.3.1/debian/network-manager-sstp.install  
2022-09-19 16:40:56.0 +0200
+++ network-manager-sstp-1.3.1/debian/network-manager-sstp.install  
2023-10-21 13:10:16.0 +0200
@@ -1,6 +1,6 @@
+usr/libexec/nm-sstp-service
 usr/lib/*/NetworkManager/libnm-vpn-plugin-sstp.so
 usr/lib/NetworkManager/VPN/nm-sstp-service.name
-usr/lib/NetworkManager/nm-sstp-service
 usr/lib/pppd/*/*.so
 usr/share/dbus-1/
 usr/share/locale/
diff -Nru network-manager-sstp-1.3.1/debian/rules 
network-manager-sstp-1.3.1/debian/rules
--- network-manager-sstp-1.3.1/debian/rules 2022-09-19 16:40:56.0 
+0200
+++ network-manager-sstp-1.3.1/debian/rules 2023-10-21 13:09:49.0 
+0200
@@ -10,7 +10,6 @@
 override_dh_auto_configure:
intltoolize; \
dh_auto_configure -- \
-   --libexecdir=/usr/lib/NetworkManager \
--disable-static \
--with-gtk4 \
--with-pppd-plugin-dir=$(PPPD_PLUGIN_DIR) \