Bug#1054608: tt-rss: New entries always marked as read even if the unread counter is not null

2024-02-08 Thread Matija Nalis
Package: tt-rss
Version: 21~git20210204.b4cbc79+dfsg-1.2
Severity: important
Followup-For: Bug #1054608
X-Debbugs-Cc: mnalis-debian...@voyager.hr

I agree, this is MAJOR usability problem.

I can confirm that the patch suggested here works, as does the (two-years old) 
upstream change:
https://git.tt-rss.org/fox/tt-rss.git/commit/?id=931e33c3818d160a2ea4e7e30c220df0b622cca7

So either applying patch, or upgrading the tt-rss to newer upstream would fix 
the issue.



Bug#1054608: tt-rss: New entries always marked as read even if the unread counter is not null

2023-10-26 Thread Antoine EMERIT
Package: tt-rss
Version: 21~git20210204.b4cbc79+dfsg-1.2
Severity: normal
Tags: patch

Dear Maintainer,

After a dist-upgrade my server from Debien 11 to Debian 12, my Tiny Tiny RSS 
server diplays
all new entries as already ridden. The unread counters are not impacted.

To reproduce : 
- access to new unread entries in any categories (or in "Unread Articles"), 
unread entries
  are well displayed but the title text is greyed.
- the unread filter is well applied and the unread counters count theses 
entries.
- manually mark an entry as unread -> counter doens't change (this is correct)
- manually mark an entry as read -> counter is correctly decreased (this is 
correct)

After a search in the javascript, I see that the entry JSON attribut returned 
by the
backend.php is always "unread: 0".

In the class/feeds.php at line 258, I see a specific code that check the unread 
database
value and retest it in case of mysql :

if (DB_TYPE == "mysql") {
   foreach (["unread", "marked", "published"] as $k) {
  $line[$k] = $line[$k] === "1";
   }
}

I suspect a change in the MariaDB upgrade that cause this problem.

I propose the following simple modification :
diff classes/feeds.php classes/feeds.php.old
258c258
<   $line[$k] = $line[$k]  === 1 || 
$line[$k] === "1";
---
>   $line[$k] = $line[$k] === "1";

Regards


-- System Information:
Debian Release: 12.2
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable-security'), (500, 'stable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 6.1.0-13-amd64 (SMP w/8 CPU threads; PREEMPT)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages tt-rss depends on:
ii  dbconfig-common   2.0.24
ii  dbconfig-pgsql2.0.24
ii  debconf [debconf-2.0] 1.5.82
ii  fonts-material-design-icons-iconfont  6.7.0+dfsg-1
ii  init-system-helpers   1.65.2
ii  libapache2-mod-php2:8.2+93
ii  libapache2-mod-php8.2 [php-json]  8.2.7-1~deb12u1
ii  libjs-dojo-core   1.17.2+dfsg1-2.1
ii  libjs-dojo-dijit  1.17.2+dfsg1-2.1
ii  libjs-scriptaculous   1.9.0-3
ii  lsb-base  11.6
ii  php   2:8.2+93
ii  php-cli   2:8.2+93
ii  php-intl  2:8.2+93
ii  php-json  2:8.2+93
ii  php-mbstring  2:8.2+93
ii  php-mysql 2:8.2+93
ii  php-php-gettext   1.0.12-5
ii  php-psr-log   1.1.4-2
ii  php-xml   2:8.2+93
ii  php8.2 [php]  8.2.7-1~deb12u1
ii  php8.2-cli [php-json] 8.2.7-1~deb12u1
ii  php8.2-intl [php-intl]8.2.7-1~deb12u1
ii  php8.2-mbstring [php-mbstring]8.2.7-1~deb12u1
ii  php8.2-phpdbg [php-json]  8.2.7-1~deb12u1
ii  php8.2-xml [php-xml]  8.2.7-1~deb12u1
ii  phpqrcode 1.1.4-3.1
ii  sysvinit-utils [lsb-base] 3.06-4

Versions of packages tt-rss recommends:
ii  apache2 [httpd] 2.4.57-2
ii  ca-certificates 20230311
ii  php-curl2:8.2+93
ii  php-gd  2:8.2+93
pn  php-mcrypt  
ii  php8.2-curl [php-curl]  8.2.7-1~deb12u1
ii  php8.2-gd [php-gd]  8.2.7-1~deb12u1

Versions of packages tt-rss suggests:
pn  php-apc   
pn  sphinxsearch  

-- Configuration Files:
/etc/tt-rss/config.php changed [not included]

-- debconf information excluded

-- debsums errors found:
debsums: changed file /usr/share/tt-rss/www/classes/feeds.php (from tt-rss 
package)
debsums: changed file /usr/share/tt-rss/www/include/errorhandler.php (from 
tt-rss package)