Bug#1057169: pdftk-java: FTBFS with bouncycastle 1.77

2023-12-16 Thread Francois Mazen
Dear pdftk-java maintainers,

Please find attached a patch to fix this FTBFS due to bouncycastle update.

Because the package gtg depends on pdftk-java, I could provide an NMU. Just let
me know.

Best,
François

Description: Fix FTBFS with new version of bouncycastle (#1057169)
Author: Francois Mazen 
Forwarded: https://gitlab.com/pdftk-java/pdftk/-/issues/155

--- a/java/com/gitlab/pdftk_java/com/lowagie/text/pdf/PdfPKCS7.java
+++ b/java/com/gitlab/pdftk_java/com/lowagie/text/pdf/PdfPKCS7.java
@@ -225,7 +225,7 @@
 ASN1ObjectIdentifier objId = (ASN1ObjectIdentifier)signedData.getObjectAt(0);
 if (!objId.getId().equals(ID_PKCS7_SIGNED_DATA))
 throw new SecurityException("Not a valid PKCS#7 object - not signed data");
-ASN1Sequence content = (ASN1Sequence)((DERTaggedObject)signedData.getObjectAt(1)).getObject();
+ASN1Sequence content = (ASN1Sequence)((DERTaggedObject)signedData.getObjectAt(1)).getBaseObject();
 // the positions that we care are:
 // 0 - version
 // 1 - digestAlgorithms
@@ -258,7 +258,7 @@
 // the possible ID_PKCS7_DATA
 ASN1Sequence rsaData = (ASN1Sequence)content.getObjectAt(2);
 if (rsaData.size() > 1) {
-DEROctetString rsaDataContent = (DEROctetString)((DERTaggedObject)rsaData.getObjectAt(1)).getObject();
+DEROctetString rsaDataContent = (DEROctetString)((DERTaggedObject)rsaData.getObjectAt(1)).getBaseObject();
 RSAdata = rsaDataContent.getOctets();
 }
 
@@ -294,7 +294,7 @@
 next = 3;
 if (signerInfo.getObjectAt(next) instanceof ASN1TaggedObject) {
 ASN1TaggedObject tagsig = (ASN1TaggedObject)signerInfo.getObjectAt(next);
-ASN1Sequence sseq = (ASN1Sequence)tagsig.getObject();
+ASN1Sequence sseq = (ASN1Sequence)tagsig.getBaseObject();
 ByteArrayOutputStream bOut = new ByteArrayOutputStream();
 ASN1OutputStream dout = ASN1OutputStream.create(bOut);
 try {


signature.asc
Description: This is a digitally signed message part


Bug#1057169: pdftk-java: FTBFS with bouncycastle 1.77

2023-11-30 Thread Markus Koschany
Source: pdftk-java
Version: 3.3.3-1
Severity: serious
Tags: ftbfs sid
User: a...@debian.org
Usertags: bouncycastle-1.77
X-Debbugs-Cc: a...@debian.org

Dear maintainer,

pdftk-java fails to build from source with bouncycastle 1.77. The reason
is the removal of long deprecated methods. The (hopefully) relevant
error message from the build log.

[javac]
/<>/java/com/gitlab/pdftk_java/com/lowagie/text/pdf/PdfPKCS7.java:
228: error: cannot find symbol
[javac] ASN1Sequence content =
(ASN1Sequence)((DERTaggedObject)signedData.getObjectAt(1)).getObject();
[javac]   
^
[javac]   symbol:   method getObject()
[javac]   location: class DERTaggedObject
[javac]
/<>/java/com/gitlab/pdftk_java/com/lowagie/text/pdf/PdfPKCS7.java:
261: error: cannot find symbol
[javac] DEROctetString rsaDataContent =
(DEROctetString)((DERTaggedObject)rsaData.getObjectAt(1)).getObject();
[javac]   
^
[javac]   symbol:   method getObject()
[javac]   location: class DERTaggedObject
[javac]
/<>/java/com/gitlab/pdftk_java/com/lowagie/text/pdf/PdfPKCS7.java:
297: error: cannot find symbol
[javac] ASN1Sequence sseq = (ASN1Sequence)tagsig.getObject();
[javac] ^
[javac]   symbol:   method getObject()
[javac]   location: variable tagsig of type ASN1TaggedObject
[javac] /<>/java/com/gitlab/pdftk_


signature.asc
Description: This is a digitally signed message part