Bug#1057555: Acknowledgement (system-wide neomuttrc causes warning at startup)

2023-12-30 Thread Carlos Henrique Lima Melara
Control: tags -1 + confirmed

Hi, Ryan.

On Tue, Dec 05, 2023 at 05:10:08PM -0500, Ryan Kavanagh wrote:
> Please see attached for a patch.

Yes, you are correct, the sort=threads is a legacy option now. I'm
fixing it in the patch we apply to change docs/neomuttrc.head.

Thanks for reporting and also sending a patch :-)

Cheers,
Charles


signature.asc
Description: PGP signature


Bug#1057555: Acknowledgement (system-wide neomuttrc causes warning at startup)

2023-12-05 Thread Ryan Kavanagh
Control: tags -1 + patch

Please see attached for a patch.

-- 
|)|/  Ryan Kavanagh  | 4E46 9519 ED67 7734 268F
|\|\  https://rak.ac | BD95 8F7B F8FC 4A11 C97A
From 4a44678b55064ef93383a72b7f78fa2ef9748fba Mon Sep 17 00:00:00 2001
From: Ryan Kavanagh 
Date: Tue, 5 Dec 2023 17:08:37 -0500
Subject: [PATCH] System-wide configuration should use 'use_threads=threads'
 instead of 'sort=threads' (Closes: #1057555)

---
 debian/patches/debian-specific/neomuttrc.patch | 16 ++--
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/debian/patches/debian-specific/neomuttrc.patch b/debian/patches/debian-specific/neomuttrc.patch
index 4f452b4..422fbc1 100644
--- a/debian/patches/debian-specific/neomuttrc.patch
+++ b/debian/patches/debian-specific/neomuttrc.patch
@@ -1,7 +1,9 @@
 Some changes to the official documentation for neomutt.rc.
 
 a/docs/neomuttrc.head
-+++ b/docs/neomuttrc.head
+Index: neomutt/docs/neomuttrc.head
+===
+--- neomutt.orig/docs/neomuttrc.head	2023-12-05 16:56:09.045866610 -0500
 neomutt/docs/neomuttrc.head	2023-12-05 16:56:46.946375350 -0500
 @@ -12,6 +12,34 @@
  # Display the fields in this order
  hdr_order date from to cc subject
@@ -18,8 +20,8 @@ Some changes to the official documentation for neomutt.rc.
 +#bind pager  previous-line
 +#bind pager  next-line
 +
-+# Specifies how to sort messages in the index menu.
-+set sort=threads
++# Sort the index menu by threads, ordered by date
++set use_threads=threads
 +
 +# The behavior of this option on the Debian mutt package is
 +# not the original one because exim4, the default SMTP on Debian
@@ -69,8 +71,10 @@ Some changes to the official documentation for neomutt.rc.
  ##
  ## *** DEFAULT SETTINGS FOR THE ATTACHMENTS PATCH ***
  ##
 a/docs/neomuttrc.man.head
-+++ b/docs/neomuttrc.man.head
+Index: neomutt/docs/neomuttrc.man.head
+===
+--- neomutt.orig/docs/neomuttrc.man.head	2023-12-05 16:56:09.045866610 -0500
 neomutt/docs/neomuttrc.man.head	2023-12-05 16:56:09.037866503 -0500
 @@ -1326,8 +1326,8 @@
  .\".
  .TS
-- 
2.43.0



signature.asc
Description: PGP signature