Bug#1058451: ntpsec: FTBFS [Hurd] change Build-Depends: systemd to [linux-any]
ma 11. maalisk. 2024 klo 5.44 Richard Laager (rlaa...@debian.org) kirjoitti: > > I think, but am not sure, that this is now functionally a duplicate of > #1060506. That one tells me to change it from systemd to systemd-dev > because: > > Since systemd_253-2 [1], these two pkgconfig files have been split > into a separate package named systemd-dev. This package is arch:all, > so even available on non-Linux architectures, which will simplify > the installation of upstream provided service files / udev rules. > > I have made that change. If that is NOT sufficient, please let me know > and I'll adjust again. Yes, this probably accomplished the same. We'll know for sure once the buildd's have caught up with the upload. Thanks! Martin-Éric
Bug#1058451: ntpsec: FTBFS [Hurd] change Build-Depends: systemd to [linux-any]
I think, but am not sure, that this is now functionally a duplicate of #1060506. That one tells me to change it from systemd to systemd-dev because: Since systemd_253-2 [1], these two pkgconfig files have been split into a separate package named systemd-dev. This package is arch:all, so even available on non-Linux architectures, which will simplify the installation of upstream provided service files / udev rules. I have made that change. If that is NOT sufficient, please let me know and I'll adjust again. -- Richard OpenPGP_signature.asc Description: OpenPGP digital signature
Bug#1058451: ntpsec: FTBFS [Hurd] change Build-Depends: systemd to [linux-any]
On 2023-12-26 22:02, Martin-Éric Racine wrote: On Wed, Dec 27, 2023 at 5:54 AM Richard Laager wrote: On 2023-12-26 21:43, Martin-Éric Racine wrote: Looking at the diff for the Hurd port What Hurd port? https://deb.debian.org/debian-ports/pool-hurd-i386/main/n/ntp/ That is the wrong package (ntp vs ntpsec). That is not in any way relevant to this conversation. -- Richard OpenPGP_signature.asc Description: OpenPGP digital signature
Bug#1058451: ntpsec: FTBFS [Hurd] change Build-Depends: systemd to [linux-any]
On Wed, Dec 27, 2023 at 5:54 AM Richard Laager wrote: > > On 2023-12-26 21:43, Martin-Éric Racine wrote: > > Looking at the diff for the Hurd port > > What Hurd port? https://deb.debian.org/debian-ports/pool-hurd-i386/main/n/ntp/ Martin-Éric
Bug#1058451: ntpsec: FTBFS [Hurd] change Build-Depends: systemd to [linux-any]
On 2023-12-26 21:43, Martin-Éric Racine wrote: Looking at the diff for the Hurd port What Hurd port? -- Richard OpenPGP_signature.asc Description: OpenPGP digital signature
Bug#1058451: ntpsec: FTBFS [Hurd] change Build-Depends: systemd to [linux-any]
On Wed, Dec 27, 2023 at 12:04 AM Richard Laager wrote: > > On 2023-12-26 02:38, Martin-Éric Racine wrote: > > On Mon, Dec 25, 2023 at 12:20 AM Richard Laager wrote: > >> If past me was correct, without systemd at build-time, waf will not > >> install the systemd units. Then we will end up with other failures in > >> debian/rules or from the .install files. > > > > Not installing them on platforms where systemd has not been ported is > > the correct action. > > Agreed. My point was that additional work would be required, during the > package building process, to not blow up when those files are missing > from `waf install`. Looking at the diff for the Hurd port would tell you what's needed. Anything else is speculation. > > It built enough to have ntpdate. > bin:ntpdate is just a transitional package to transition uses of the old > src:ntp's bin:ntpdate to src:ntpsec's bin:ntpsec-ntpdate. It is > Architecture: all, which is why it is available on Hurd. > > In ntpsec, the ntpdate executable is just a thin wrapper around ntpdig, > which ships in the bin:ntpsec-ntpdig package (formerly, it was in > bin:ntpsec-ntpdate). While ntpdig is Python, so it doesn't actually > require compilation, it is presumably going to require some build steps > happen. Noted. > >> ifeq (hurd, $(DEB_HOST_ARCH_OS)) > >> # hurd does not provided the system calls needed for ntpd to work. > >> exit 1 > >> endif > >> > >> I see a couple of ways forward here: > >> > >> A) I properly indicate this package does not support HURD. > >> > >> I think I would just replace the "Architecture: any" with > >> "Architecture: linux-any" on binary packages in debian/control, but > >> I would love confirmation on that. > > > > Which is what this bug requested > > I'm confused. > > What you asked for was for me to limit "Build-Depends: systemd" to > [linux-any]. Which is the correct course of action. Puposely limiting binary targets isn't. Martin-Éric
Bug#1058451: ntpsec: FTBFS [Hurd] change Build-Depends: systemd to [linux-any]
On 2023-12-26 02:38, Martin-Éric Racine wrote:
On Mon, Dec 25, 2023 at 12:20 AM Richard Laager wrote:
If past me was correct, without systemd at build-time, waf will not
install the systemd units. Then we will end up with other failures in
debian/rules or from the .install files.
Not installing them on platforms where systemd has not been ported is
the correct action.
Agreed. My point was that additional work would be required, during the
package building process, to not blow up when those files are missing
from `waf install`.
It built enough to have ntpdate.
bin:ntpdate is just a transitional package to transition uses of the old
src:ntp's bin:ntpdate to src:ntpsec's bin:ntpsec-ntpdate. It is
Architecture: all, which is why it is available on Hurd.
In ntpsec, the ntpdate executable is just a thin wrapper around ntpdig,
which ships in the bin:ntpsec-ntpdig package (formerly, it was in
bin:ntpsec-ntpdate). While ntpdig is Python, so it doesn't actually
require compilation, it is presumably going to require some build steps
happen.
ifeq (hurd, $(DEB_HOST_ARCH_OS))
# hurd does not provided the system calls needed for ntpd to work.
exit 1
endif
I see a couple of ways forward here:
A) I properly indicate this package does not support HURD.
I think I would just replace the "Architecture: any" with
"Architecture: linux-any" on binary packages in debian/control, but
I would love confirmation on that.
Which is what this bug requested
I'm confused.
What you asked for was for me to limit "Build-Depends: systemd" to
[linux-any]. What I said here was that I'd limit all the built binary
packages to [linux-any], dropping any claims of support for HURD.
The rest of your email reads to me like you think this package should
support HURD to some degree. But here you are agreeing with the choice
that it should not support HURD _at all_.
I'm fine with dropping support for HURD entirely. I think that would be
more honest than the current state of affairs where the build just fails.
But if ntpdig is something that would be useful on HURD, I suppose it
would be nice if we could figure out how to make bin:ntpsec-ntpdig (and
some other packages) build for HURD.
If you are interested in HURD support, could you start with the attached
patch to ntpsec, try to build it, and see what happens?
--
Richard
diff --git a/debian/control b/debian/control
index a33a26ecb..2b1bc2a18 100644
--- a/debian/control
+++ b/debian/control
@@ -18,7 +18,7 @@
python3,
python3-dev,
python3-gps,
- systemd,
+ systemd [linux-any],
xsltproc,
xz-utils,
Build-Conflicts: libavahi-compat-libdnssd-dev,
@@ -31,7 +31,7 @@
Homepage: https://www.ntpsec.org
Package: ntpsec
-Architecture: any
+Architecture: [linux-any]
Pre-Depends: ${misc:Pre-Depends},
Depends: adduser,
netbase,
diff --git a/debian/rules b/debian/rules
index dc23970f5..ff816974d 100755
--- a/debian/rules
+++ b/debian/rules
@@ -12,10 +12,6 @@
dh $@ --with apache2,python3
override_dh_auto_configure:
-ifeq (hurd, $(DEB_HOST_ARCH_OS))
- # hurd does not provided the system calls needed for ntpd to work.
- exit 1
-endif
# Only build with refclocks NOT slated for removal. See also
# debian/patches/update-refclock-docs.patch. However, if the reason
# for deprecation is only "two digit years", I *am* keeping it.
OpenPGP_signature.asc
Description: OpenPGP digital signature
Bug#1058451: ntpsec: FTBFS [Hurd] change Build-Depends: systemd to [linux-any]
On Tue, Dec 26, 2023 at 10:38 AM Martin-Éric Racine wrote: > > On Mon, Dec 25, 2023 at 12:20 AM Richard Laager wrote: > > > > On 2023-12-12 04:52, Martin-Éric Racine wrote: > > > Build-Depends: systemd must be changed to systemd [linux-any], since > > > systemd has not been powerted to non-Linux platforms. > > > > I suspect that change would be necessary, but not sufficient. > > > > In commit 7f969a0ecab4ef3ab50defd4fe9d7e7a47817dbe, I wrote: > >Build-Depend on systemd > > > >This is required for the pkg-config file, so that waf will detect > >systemd and install the systemd units. > > Only on linux-any. > > > If past me was correct, without systemd at build-time, waf will not > > install the systemd units. Then we will end up with other failures in > > debian/rules or from the .install files. > > Not installing them on platforms where systemd has not been ported is > the correct action. > > > HURD is the only non-Linux platform that Debian supports these days, > > right? kFreeBSD is gone, IIRC. > > > > The ntpsec package (like ntp before it, IIRC) does not build on HURD > > anyway. From debian/rules: > > It built enough to have ntpdate. The Hurd patch was even updated just > a few days before the version that added the build-depends on systemd. $ LC_ALL=C apt policy ntpdate ntpdate: Installed: 1:4.2.8p15+dfsg-2~1.2.2+dfsg1-2+hurd.1 Candidate: 1:4.2.8p15+dfsg-2~1.2.2+dfsg1-4 Version table: 1:4.2.8p15+dfsg-2~1.2.2+dfsg1-4 500 500 https://deb.debian.org/debian-ports unstable/main hurd-i386 Packages 1:4.2.8p15+dfsg-2~1.2.2+dfsg1-3 500 500 https://deb.debian.org/debian-ports unstable/main hurd-i386 Packages *** 1:4.2.8p15+dfsg-2~1.2.2+dfsg1-2+hurd.1 500 500 https://deb.debian.org/debian-ports unreleased/main hurd-i386 Packages 100 /var/lib/dpkg/status Martin-Éric
Bug#1058451: ntpsec: FTBFS [Hurd] change Build-Depends: systemd to [linux-any]
On Mon, Dec 25, 2023 at 12:20 AM Richard Laager wrote: > > On 2023-12-12 04:52, Martin-Éric Racine wrote: > > Build-Depends: systemd must be changed to systemd [linux-any], since > > systemd has not been powerted to non-Linux platforms. > > I suspect that change would be necessary, but not sufficient. > > In commit 7f969a0ecab4ef3ab50defd4fe9d7e7a47817dbe, I wrote: >Build-Depend on systemd > >This is required for the pkg-config file, so that waf will detect >systemd and install the systemd units. Only on linux-any. > If past me was correct, without systemd at build-time, waf will not > install the systemd units. Then we will end up with other failures in > debian/rules or from the .install files. Not installing them on platforms where systemd has not been ported is the correct action. > HURD is the only non-Linux platform that Debian supports these days, > right? kFreeBSD is gone, IIRC. > > The ntpsec package (like ntp before it, IIRC) does not build on HURD > anyway. From debian/rules: It built enough to have ntpdate. The Hurd patch was even updated just a few days before the version that added the build-depends on systemd. > ifeq (hurd, $(DEB_HOST_ARCH_OS)) > # hurd does not provided the system calls needed for ntpd to work. > exit 1 > endif > > I see a couple of ways forward here: > > A) I properly indicate this package does not support HURD. > > I think I would just replace the "Architecture: any" with > "Architecture: linux-any" on binary packages in debian/control, but > I would love confirmation on that. Which is what this bug requested. Martin-Éric
Bug#1058451: ntpsec: FTBFS [Hurd] change Build-Depends: systemd to [linux-any]
On 2023-12-12 04:52, Martin-Éric Racine wrote: Build-Depends: systemd must be changed to systemd [linux-any], since systemd has not been powerted to non-Linux platforms. I suspect that change would be necessary, but not sufficient. In commit 7f969a0ecab4ef3ab50defd4fe9d7e7a47817dbe, I wrote: Build-Depend on systemd This is required for the pkg-config file, so that waf will detect systemd and install the systemd units. If past me was correct, without systemd at build-time, waf will not install the systemd units. Then we will end up with other failures in debian/rules or from the .install files. HURD is the only non-Linux platform that Debian supports these days, right? kFreeBSD is gone, IIRC. The ntpsec package (like ntp before it, IIRC) does not build on HURD anyway. From debian/rules: ifeq (hurd, $(DEB_HOST_ARCH_OS)) # hurd does not provided the system calls needed for ntpd to work. exit 1 endif I see a couple of ways forward here: A) I properly indicate this package does not support HURD. I think I would just replace the "Architecture: any" with "Architecture: linux-any" on binary packages in debian/control, but I would love confirmation on that. B) Someone who cares about HURD figures out how much of this package can reasonably be expected to work and submits a patch. -- Richard OpenPGP_signature.asc Description: OpenPGP digital signature
Bug#1058451: ntpsec: FTBFS [Hurd] change Build-Depends: systemd to [linux-any]
Source: ntpsec Severity: important -BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Build-Depends: systemd must be changed to systemd [linux-any], since systemd has not been powerted to non-Linux platforms. Martin-Éric -BEGIN PGP SIGNATURE- iQIzBAEBCgAdFiEEyJACx3qL7GpObXOQrh+Cd8S017YFAmV4O3QACgkQrh+Cd8S0 17YJMA//dN97bYQU+07sobISsqryypzDaO6i/Ioci96Nbzq7ZXtv2ezsCVsVa7KG aKFV1TD9vh4fXlVf5KorJg/qNS2RP7pK7G71lHMU0k8KVwAoPvONRWQw/5GfEkO3 4mjYIHIqoC7jUzW0W6g626CDxWRkzvaKlKzL7/IFbO77XXPixOU3uup1+4jL1O6T 6TDZRH9CNQNGUlocd6JeE9TH3v9tGELXlPMSJsif9H+aSXy7GbBiaCTvS/0Wunis yzirO5hIGJA2PNMVnzCboh6HIWMAUITrPpt2l/y52RnEalDfPcbPytPJlT1/iUPE vMfXeVeD3jFu5fzfSzXViOLZEAz+nM3Cjs1uawaxR1sdugtzkpp9GktB4bUwV+xK Bmc6XJ45X/uRZCZFNho97Bo1z8PIaoFwEEF58sUR3PbcVC+RQ177Uc0uyaTPYvJM DSXk5Y0jG6BxWZJC1sbb2URqWChXYKg3CtEFyZUKksIZixoeBIrC1MvB7ehKgMc0 r2Gtm9xw/u1uiDYTNy2sMVUjFS1Fl8N0H0UmwSBHlujIxrA92jAMZFwxu9f48aR9 f+LFPIfEXM6nrK27royUNCbU0qJ+7LzfhFLTxcRQFl3+rCsjQMrqAJ7PG+jUJ/9h RkGmkIdqLpjck8knVzMql39VYnyrLhFSd+xDJBWCtTVZBxxTVnA= =RgXH -END PGP SIGNATURE-
