On Sun, Dec 31, 2023 at 11:39:42AM +0100, Damian wrote:
> The fix for #1028030 introduced a regression for amavisd-new. Its hook [1] is
> never run as long as spamd is not installed.
Right, it seems like this:
if [ -d /etc/spamassassin/sa-update-hooks.d ]; then
run-parts --lsbsysinit /etc/spamassassin/sa-update-hooks.d
fi
should not be conditional on spamd running.
> I'd also like an opinion on a related issue: When spamd is running but
> amavisd-new is not, spamassassin-maintenance.service fails by virtue of [1]
> failing with a dedicated exit code. Would you like to consider this a
> spamassassin or an amavisd-new bug?
>
> [1] /etc/spamassassin/sa-update-hooks.d/amavisd-new
I think the amavisd-new hook probably shouldn't exit nonzero if it's not
running. But we can also ensure that we fall through to an explicit
"exit 0" in the maintenance script, which should also take care of this.
noah
