Bug#1060104: dcmtk: FTBFS on armel: Error: bad immediate value for offset (4100)
Hi Emanuele. Am Tue, Mar 19, 2024 at 12:16:16PM +0100 schrieb Emanuele Rocca: > I've uploaded a NMU to DELAYED/2: https://bugs.debian.org/1067147 Thanks a lot for your attempt to help. In principle we have a team wide low threshold NMU - so undelayed NMUs are fine. The kind of race condition in uploads might imply that some ping in advance might be helpful to avoid duplicated work. > With those changes dcmtk builds fine on both armel and armhf. I've > dropped the graphviz build-depend on those arches too, it can of course > be reintroduced once graphviz become installable again. Meanwhile your patch is imported and was uploaded by Michael - thanks to all who helped solving this. Kind regards Andreas. -- http://fam-tille.de
Bug#1060104: dcmtk: FTBFS on armel: Error: bad immediate value for offset (4100)
On Tue, 19 Mar 2024 12:16:16 +0100 Emanuele Rocca wrote: > Hi Andreas, > > On 2024-03-19 10:40, Andreas Tille wrote: > > Since you all pinged that bug we now have another 4 weeks of time before > > anything gets removed from testing. So we just need to bear the noise > > from testing removal warnings of quite some packages (which I'd love to > > get rid of thus uploading a fix would be great). > > I've uploaded a NMU to DELAYED/2: https://bugs.debian.org/1067147 > > With those changes dcmtk builds fine on both armel and armhf. I've > dropped the graphviz build-depend on those arches too, it can of course > be reintroduced once graphviz become installable again. Thanks, Emanuele; I've incorporated your changes on top of Sébastien Jodogne's very recent upload and will be uploading that shortly. > -- Michael R. Crusoe OpenPGP_signature.asc Description: OpenPGP digital signature
Bug#1060104: dcmtk: FTBFS on armel: Error: bad immediate value for offset (4100)
Hi Andreas, On 2024-03-19 10:40, Andreas Tille wrote: > Since you all pinged that bug we now have another 4 weeks of time before > anything gets removed from testing. So we just need to bear the noise > from testing removal warnings of quite some packages (which I'd love to > get rid of thus uploading a fix would be great). I've uploaded a NMU to DELAYED/2: https://bugs.debian.org/1067147 With those changes dcmtk builds fine on both armel and armhf. I've dropped the graphviz build-depend on those arches too, it can of course be reintroduced once graphviz become installable again. Emanuele
Bug#1060104: dcmtk: FTBFS on armel: Error: bad immediate value for offset (4100)
Hi again, sorry, I did not checked the situation. Am Tue, Mar 19, 2024 at 10:34:13AM +0100 schrieb Andreas Tille: > Testing removals are happening automatically if some RC bug exists > for a certain time without pinging. Just writing some additional > information to the bug in question would have prevented this but > nobody of us had sufficient capacity. That's a shame but will be > healed over time (which is hopefully not that long). Since you all pinged that bug we now have another 4 weeks of time before anything gets removed from testing. So we just need to bear the noise from testing removal warnings of quite some packages (which I'd love to get rid of thus uploading a fix would be great). Kind regards Andreas. -- http://fam-tille.de
Bug#1060104: dcmtk: FTBFS on armel: Error: bad immediate value for offset (4100)
Dear all, > Indeed, and there is a simple fix too, which has been uploaded to > experimental only so far: yes, there is a simple fix (that disables the error), but there is also a more fundamental fix that (hopefully) solves the issue at its core: https://git.dcmtk.org/?p=dcmtk.git;a=commit;h=bdc18c85b7fca130464dd745ea3efef3c9b8b94e Furthermore, it feels kind of strange that the DCMTK package was about to be removed because a rather insignificant test tool causes problems on a single platform, and this test tool is even not part of any Debian package (see "debian/rules" file): override_dh_install-arch: [...] #remove test binaries [...] rm ./debian/dcmtk/usr/bin/drttest [...] Regards, Jörg -- Dr. Joerg Riesmeier, Etzhorner Weg 19, 26125 Oldenburg, Germany E-Mail: di...@jriesmeier.com, Homepage: www.jriesmeier.com
Bug#1060104: dcmtk: FTBFS on armel: Error: bad immediate value for offset (4100)
Dear Emmanuele and Mathieu, On 3/19/24 08:51, Mathieu Malaterre wrote: On Tue, Mar 19, 2024 at 8:44 AM Emanuele Rocca wrote: Hi, On 2024-03-19 06:24, Sébastien Jodogne wrote: Because of bug #1060104, a large majority of the packages related to medical imaging have just disappeared from Debian Unstable. But, if I correctly understand #1060104, it is specific to one single platform (armel). Indeed, and there is a simple fix too, which has been uploaded to experimental only so far: https://salsa.debian.org/med-team/dcmtk/-/commit/42583dfe9fd344a63cdbc278268d4176d4a22ec4 Mathieu (or someone else from debian-med), could you please apply that to unstable as well? It seems that with the current state of unstable the transition will take a while anyways. I will be away from any Debian tasks for at least another month unfortunately. The patch was suggested by an armel porter so I believe this is the right thing to do. Worth pointing out that right now dcmtk cannot be built in sid/armel due to a missing build depend, namely graphviz. It seems worth applying the fix to unstable anyways so that it does not fall through the cracks, and we can schedule a binNMU later when graphviz is available again. I could try to upload this patch by myself to unstable. Unfortunately, I'm not an uploader of the dcmtk package, so an intervention from a Debian Developer is required to give me the proper access rights: https://tracker.debian.org/pkg/dcmtk Kind Regards, Sébastien-
Bug#1060104: dcmtk: FTBFS on armel: Error: bad immediate value for offset (4100)
On Tue, Mar 19, 2024 at 8:44 AM Emanuele Rocca wrote: > > Hi, > > On 2024-03-19 06:24, Sébastien Jodogne wrote: > > Because of bug #1060104, a large majority of the packages related to > > medical imaging have just disappeared from Debian Unstable. > > > > But, if I correctly understand #1060104, it is specific to one single > > platform (armel). > > Indeed, and there is a simple fix too, which has been uploaded to > experimental only so far: > https://salsa.debian.org/med-team/dcmtk/-/commit/42583dfe9fd344a63cdbc278268d4176d4a22ec4 > > Mathieu (or someone else from debian-med), could you please apply that > to unstable as well? It seems that with the current state of unstable > the transition will take a while anyways. I will be away from any Debian tasks for at least another month unfortunately. The patch was suggested by an armel porter so I believe this is the right thing to do. > Worth pointing out that right now dcmtk cannot be built in sid/armel due > to a missing build depend, namely graphviz. It seems worth applying the > fix to unstable anyways so that it does not fall through the cracks, and > we can schedule a binNMU later when graphviz is available again. -M
Bug#1060104: dcmtk: FTBFS on armel: Error: bad immediate value for offset (4100)
Hi, On 2024-03-19 06:24, Sébastien Jodogne wrote: > Because of bug #1060104, a large majority of the packages related to > medical imaging have just disappeared from Debian Unstable. > > But, if I correctly understand #1060104, it is specific to one single > platform (armel). Indeed, and there is a simple fix too, which has been uploaded to experimental only so far: https://salsa.debian.org/med-team/dcmtk/-/commit/42583dfe9fd344a63cdbc278268d4176d4a22ec4 Mathieu (or someone else from debian-med), could you please apply that to unstable as well? It seems that with the current state of unstable the transition will take a while anyways. Worth pointing out that right now dcmtk cannot be built in sid/armel due to a missing build depend, namely graphviz. It seems worth applying the fix to unstable anyways so that it does not fall through the cracks, and we can schedule a binNMU later when graphviz is available again. Thanks! Emanuele
Bug#1060104: dcmtk: FTBFS on armel: Error: bad immediate value for offset (4100)
Dear all, Because of bug #1060104, a large majority of the packages related to medical imaging have just disappeared from Debian Unstable. But, if I correctly understand #1060104, it is specific to one single platform (armel). My question is: Rather than penalizing all platforms (including the most common arm64) and thus a huge number of users working on healthcare application, couldn't a temporary measure be to remove the armel builds? Best Regards, Sébastien- On Sat, 24 Feb 2024 10:03:07 +0100 Sebastian Ramacher wrote: > Control: severity -1 serious > > On 2024-01-18 13:38:20 +0100, Mathieu Malaterre wrote: > > Control: severity -1 important > > > > On Mon, Jan 15, 2024 at 1:49 PM Emanuele Rocca wrote: > > [...] > > > For this reason I would > > > suggest to disable stackclash on the armel build of dcmtk (just like you > > > did in experimental) to make sure the package builds properly again, but > > > keep #1060104 open at a lower severity so that we don't lose track of > > > this. > > > > Done ! Thanks > > dcmtk is still failing to build on unstable buildds, so raising the > severity again to serious. Please only lower the severity once the > package builds again. > > Cheers > -- > Sebastian Ramacher
Bug#1060104: dcmtk: FTBFS on armel: Error: bad immediate value for offset (4100)
Dear all, Because of bug #1060104, a large majority of the packages related to medical imaging have just disappeared from Debian Unstable. But, if I correctly understand #1060104, it is specific to one single platform (armel). My question is: Rather than penalizing all platforms (including the most common arm64) and thus a huge number of users working on healthcare application, couldn't a temporary measure be to remove the armel builds? Note that as far as I'm concerned, I cannot help on armel. Best Regards, Sébastien- On Sat, 24 Feb 2024 10:03:07 +0100 Sebastian Ramacher wrote: Control: severity -1 serious On 2024-01-18 13:38:20 +0100, Mathieu Malaterre wrote: > Control: severity -1 important > > On Mon, Jan 15, 2024 at 1:49 PM Emanuele Rocca wrote: > [...] > > For this reason I would > > suggest to disable stackclash on the armel build of dcmtk (just like you > > did in experimental) to make sure the package builds properly again, but > > keep #1060104 open at a lower severity so that we don't lose track of > > this. > > Done ! Thanks dcmtk is still failing to build on unstable buildds, so raising the severity again to serious. Please only lower the severity once the package builds again. Cheers -- Sebastian Ramacher
Bug#1060104: dcmtk: FTBFS on armel: Error: bad immediate value for offset (4100)
Control: severity -1 serious On 2024-01-18 13:38:20 +0100, Mathieu Malaterre wrote: > Control: severity -1 important > > On Mon, Jan 15, 2024 at 1:49 PM Emanuele Rocca wrote: > [...] > > For this reason I would > > suggest to disable stackclash on the armel build of dcmtk (just like you > > did in experimental) to make sure the package builds properly again, but > > keep #1060104 open at a lower severity so that we don't lose track of > > this. > > Done ! Thanks dcmtk is still failing to build on unstable buildds, so raising the severity again to serious. Please only lower the severity once the package builds again. Cheers -- Sebastian Ramacher
Bug#1060104: dcmtk: FTBFS on armel: Error: bad immediate value for offset (4100)
Control: severity -1 important On Mon, Jan 15, 2024 at 1:49 PM Emanuele Rocca wrote: [...] > For this reason I would > suggest to disable stackclash on the armel build of dcmtk (just like you > did in experimental) to make sure the package builds properly again, but > keep #1060104 open at a lower severity so that we don't lose track of > this. Done ! Thanks
Bug#1060104: dcmtk: FTBFS on armel: Error: bad immediate value for offset (4100)
Hi Mathieu et al., it seems that the stack problem is limited to the "drttest" tool, which is not really needed for a Linux distribution like Debian. Anyway, in the meantime, I have revised the implementation of this test tool to avoid the creation of huge data structures on the stack. See this commit: https://git.dcmtk.org/?p=dcmtk.git;a=commit;h=bdc18c85b7fca130464dd745ea3efef3c9b8b94e It's up to you whether you switch to this implementation for the "experimental" 3.6.8 package or not. For 3.6.7 ("unstable" and "testing"), there seems to be another solution. Regards, Jörg ----------------- Subject: Bug#1060104: dcmtk: FTBFS on armel: Error: bad immediate value for offset (4100) Date: Sunday, January 14, 2024, 11:24:06 AM CET From: Mathieu Malaterre To: Emanuele Rocca, 1060...@bugs.debian.org Control: fixed -1 3.6.8-3 On Sat, Jan 13, 2024 at 9:42 PM Emanuele Rocca wrote: > > Control: user -1 debian-...@lists.debian.org > Control: usertag -1 + 32bit-stackclash > > Hi, > > On Fri, Jan 05, 2024 at 11:45:28PM +0100, Sebastian Ramacher wrote: > > /tmp/ccm0eYhx.s: Assembler messages: > > /tmp/ccm0eYhx.s:537: Error: bad immediate value for offset (4100) > > This is caused by stack-clash-protection on armel and a workaround is in > version 3.6.8-3 currently in experimental, see: > https://tracker.debian.org/news/1494233/accepted-dcmtk-368-3-source-into-experimental/ > > We should downgrade the severity to minor once the fix enters unstable, but > keep the bug open as this seems to be an interesting case of > stack-clash-protection malfunctioning on 32bit arm to further look into. Bit lost here... I do not see the bug reported against GCC-13 package. In the end do you want me to upload a patched 3.6.7 or is it ok to wait for transition ? Thanks! - -- Dr. Joerg Riesmeier, Etzhorner Weg 19, 26125 Oldenburg, Germany E-Mail: di...@jriesmeier.com, Homepage: www.jriesmeier.com
Bug#1060104: dcmtk: FTBFS on armel: Error: bad immediate value for offset (4100)
Hi Mathieu, On 2024-01-14 11:24, Mathieu Malaterre wrote: > On Sat, Jan 13, 2024 at 9:42 PM Emanuele Rocca wrote: > > We should downgrade the severity to minor once the fix enters unstable, but > > keep the bug open as this seems to be an interesting case of > > stack-clash-protection malfunctioning on 32bit arm to further look into. > > Bit lost here... I do not see the bug reported against GCC-13 package. Sorry for the lack of context. Out of all packages in the archive, a few (less than 10 it seems, rebuilds still ongoing) fail to build on armhf or armel with the stack-clash-protection flag on, but build successfully without it. It's not entirely clear why this is the case yet, but we know that disabling the flag fixes the issue. For this reason I would suggest to disable stackclash on the armel build of dcmtk (just like you did in experimental) to make sure the package builds properly again, but keep #1060104 open at a lower severity so that we don't lose track of this. > In the end do you want me to upload a patched 3.6.7 or is it ok to > wait for transition ? Up to you really, no rush on my side. Thanks, Emanuele
Bug#1060104: dcmtk: FTBFS on armel: Error: bad immediate value for offset (4100)
Control: fixed -1 3.6.8-3 On Sat, Jan 13, 2024 at 9:42 PM Emanuele Rocca wrote: > > Control: user -1 debian-...@lists.debian.org > Control: usertag -1 + 32bit-stackclash > > Hi, > > On Fri, Jan 05, 2024 at 11:45:28PM +0100, Sebastian Ramacher wrote: > > /tmp/ccm0eYhx.s: Assembler messages: > > /tmp/ccm0eYhx.s:537: Error: bad immediate value for offset (4100) > > This is caused by stack-clash-protection on armel and a workaround is in > version 3.6.8-3 currently in experimental, see: > https://tracker.debian.org/news/1494233/accepted-dcmtk-368-3-source-into-experimental/ > > We should downgrade the severity to minor once the fix enters unstable, but > keep the bug open as this seems to be an interesting case of > stack-clash-protection malfunctioning on 32bit arm to further look into. Bit lost here... I do not see the bug reported against GCC-13 package. In the end do you want me to upload a patched 3.6.7 or is it ok to wait for transition ? Thanks!
Bug#1060104: dcmtk: FTBFS on armel: Error: bad immediate value for offset (4100)
Control: user -1 debian-...@lists.debian.org Control: usertag -1 + 32bit-stackclash Hi, On Fri, Jan 05, 2024 at 11:45:28PM +0100, Sebastian Ramacher wrote: > /tmp/ccm0eYhx.s: Assembler messages: > /tmp/ccm0eYhx.s:537: Error: bad immediate value for offset (4100) This is caused by stack-clash-protection on armel and a workaround is in version 3.6.8-3 currently in experimental, see: https://tracker.debian.org/news/1494233/accepted-dcmtk-368-3-source-into-experimental/ We should downgrade the severity to minor once the fix enters unstable, but keep the bug open as this seems to be an interesting case of stack-clash-protection malfunctioning on 32bit arm to further look into. Thanks, Emanuele
Bug#1060104: dcmtk: FTBFS on armel: Error: bad immediate value for offset (4100)
Source: dcmtk Version: 3.6.7-9 Severity: serious Tags: ftbfs Justification: fails to build from source (but built successfully in the past) X-Debbugs-Cc: sramac...@debian.org https://buildd.debian.org/status/fetch.php?pkg=dcmtk=armel=3.6.7-9%2Bb1=1704494616=0 [ 90%] Building CXX object dcmpstat/libsrc/CMakeFiles/dcmpstat.dir/dcmpstat.cc.o cd /<>/obj-arm-linux-gnueabi/dcmpstat/libsrc && /usr/bin/c++ -DDCMTK_BUILD_IN_PROGRESS -DDCMTK_HAVE_POLL=1 -DUSE_NULL_SAFE_OFSTRING -D_REENTRANT -Ddcmpstat_EXPORTS -I/<>/obj-arm-linux-gnueabi/config/include -I/<>/ofstd/include -I/<>/oflog/include -I/<>/dcmdata/include -I/<>/dcmimgle/include -I/<>/dcmimage/include -I/<>/dcmjpeg/include -I/<>/dcmjpls/include -I/<>/dcmtls/include -I/<>/dcmnet/include -I/<>/dcmsr/include -I/<>/dcmsign/include -I/<>/dcmwlm/include -I/<>/dcmqrdb/include -I/<>/dcmpstat/include -I/<>/dcmrt/include -I/<>/dcmiod/include -I/<>/dcmfg/include -I/<>/dcmseg/include -I/<>/dcmtract/include -I/<>/dcmpmap/include -I/<>/dcmect/include -I/usr/include/libxml2 -g -O2 -ffile-prefix-map=/<>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -DENABLE_DCMJPLS_INTERLEAVE_NONE -Wdate-time -D_FORTIFY_SOURCE=2 -fvisibility=hidden -D_XOPEN_SOURCE_EXTENDED -D_XOPEN_SOURCE=500 -D_BSD_SOURCE -D_DEFAULT_SOURCE -D_BSD_COMPAT -D_OSF_SOURCE -D_POSIX_C_SOURCE=199506L -std=gnu++17 -fPIC -Wall -MD -MT dcmpstat/libsrc/CMakeFiles/dcmpstat.dir/dcmpstat.cc.o -MF CMakeFiles/dcmpstat.dir/dcmpstat.cc.o.d -o CMakeFiles/dcmpstat.dir/dcmpstat.cc.o -c /<>/dcmpstat/libsrc/dcmpstat.cc /tmp/ccm0eYhx.s: Assembler messages: /tmp/ccm0eYhx.s:537: Error: bad immediate value for offset (4100) make[4]: *** [dcmrt/tests/CMakeFiles/drttest.dir/build.make:79: dcmrt/tests/CMakeFiles/drttest.dir/drttest.cc.o] Error 1 make[4]: Leaving directory '/<>/obj-arm-linux-gnueabi' make[3]: *** [CMakeFiles/Makefile2:5064: dcmrt/tests/CMakeFiles/drttest.dir/all] Error 2 make[3]: *** Waiting for unfinished jobs [ 90%] Building CXX object dcmpstat/libsrc/CMakeFiles/dcmpstat.dir/dviface.cc.o Cheers -- Sebastian Ramacher