Bug#1060189: [Pkg-pascal-devel] Bug#1060189: Bug#1060189: lazarus-src-3.0: diversion handling seems wrong (it works, but after an error)

2024-01-12 Thread Paul Gevers

Hi Abou,

On 12-01-2024 22:44, Abou Al Montacir wrote:

Well, maybe I just didn't spot this issue before. But because of the
/usr-merged work of helmut, I'm much more aware of diversions so they'd
trigger me much more then they used to.


Makes sense, but I'm not sure I understand why diverted files should be 
the same? Isn't diversion is used to enable a package to supersede 
another shipping a different version of the same file?


Indeed, diverted files are supposed to be different, otherwise it 
doesn't make sense to use diversions. To I think the error message is 
trying to say something else, but I don't know what it means exactly. I 
suspect it's saying that the file is already diverted and that we're 
trying to divert it a second time. Or something in that direction.


Paul


OpenPGP_signature.asc
Description: OpenPGP digital signature


Bug#1060189: [Pkg-pascal-devel] Bug#1060189: Bug#1060189: lazarus-src-3.0: diversion handling seems wrong (it works, but after an error)

2024-01-12 Thread Abou Al Montacir
Hi Paul,

On Fri, 2024-01-12 at 20:12 +0100, Paul Gevers wrote:
> Hi Abou,
> 
> On 11-01-2024 20:40, Abou Al Montacir wrote:
> > But this is the case of all lpk files where the binary package provide a 
> > Manually compilable package while the source one provides a Compile AsĀ  >
> > Needed package file.
> 
> Don't we want them to be the same? Why do we even ship the files twice?
They are not the same for the following reasons:

When someone installs only binary packages (let's say an auto build setup) they
don't want to recompile units, and they don't even install sources, so we tell
lazbuild tool to not try to compile the units of this package. This is why the
lcl-units-* binary packages provide lpk fills with .

When a human installs full Lazarus on a desktop/laptop, he will want to install
sources and may need to recompile Lazarus (unfortunately upstream does not
support dynamically linked plugins and thus need to recompile lazarus when you
install some new packages). This will fail with 
and thus we change it to .
> 
> > This was the case since many years now.
> 
> Well, maybe I just didn't spot this issue before. But because of the 
> /usr-merged work of helmut, I'm much more aware of diversions so they'd 
> trigger me much more then they used to.
Makes sense, but I'm not sure I understand why diverted files should be the
same? Isn't diversion is used to enable a package to supersede another shipping
a different version of the same file?
-- 
Cheers,
Abou Al Montacir


signature.asc
Description: This is a digitally signed message part