Bug#1062022: [Debian-med-packaging] Bug#1062022: dcmtk: NMU diff for 64-bit time_t transition

2024-02-28 Thread Étienne Mollier 
Hi Michael,

mwhud...@fastmail.fm, on 2024-02-28:
> Please find attached a final version of this patch for the time_t
> transition.  This patch is being uploaded to unstable.

Thanks for moving forwards the 64-bit time_t transition!  Your
NMU is injected in the packaging tree, so it won't risk being
undone by accident.

Have a nice day,  :)
-- 
  .''`.  Étienne Mollier 
 : :' :  pgp: 8f91 b227 c7d6 f2b1 948c  8236 793c f67e 8f0d 11da
 `. `'   sent from /dev/pts/1, please excuse my verbosity
   `-on air: Arena - Returning The Curse


signature.asc
Description: PGP signature

Bug#1062022: dcmtk: NMU diff for 64-bit time_t transition

2024-02-27 Thread mwhudson 
Dear maintainer,

Please find attached a final version of this patch for the time_t
transition.  This patch is being uploaded to unstable.

Note that this adds a versioned build-dependency on dpkg-dev, to guard
against accidental backports with a wrong ABI.

Thanks!


-- System Information:
Debian Release: trixie/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 6.5.0-21-generic (SMP w/16 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
diff -Nru dcmtk-3.6.7/debian/changelog dcmtk-3.6.7/debian/changelog
--- dcmtk-3.6.7/debian/changelog2023-06-22 07:53:48.0 +
+++ dcmtk-3.6.7/debian/changelog2024-02-28 01:17:02.0 +
@@ -1,3 +1,10 @@
+dcmtk (3.6.7-9.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Rename libraries for 64-bit time_t transition.  Closes: #1062022
+
+ -- Michael Hudson-Doyle   Wed, 28 Feb 2024 01:17:02 +
+
 dcmtk (3.6.7-9) unstable; urgency=medium
 
   * Team upload.
diff -Nru dcmtk-3.6.7/debian/control dcmtk-3.6.7/debian/control
--- dcmtk-3.6.7/debian/control  2023-06-22 07:53:48.0 +
+++ dcmtk-3.6.7/debian/control  2024-02-28 01:17:02.0 +
@@ -4,7 +4,7 @@
Mathieu Malaterre 
 Section: science
 Priority: optional
-Build-Depends: cmake,
+Build-Depends: dpkg-dev (>= 1.22.5), cmake,
debhelper-compat (= 13),
gettext,
help2man,
@@ -38,13 +38,14 @@
  .
  Note: This version was compiled with libssl support.
 
-Package: libdcmtk17
+Package: libdcmtk17t64
+Provides: ${t64:Provides}
 Architecture: any
 Section: libs
 Depends: ${misc:Depends},
  ${shlibs:Depends}
-Breaks: libdcmtk16 (= 3.6.7-1)
-Replaces: libdcmtk16 (= 3.6.7-1)
+Breaks: libdcmtk17 (<< ${source:Version}), libdcmtk16 (= 3.6.7-1)
+Replaces: libdcmtk17, libdcmtk16 (= 3.6.7-1)
 Multi-Arch: same
 Description: OFFIS DICOM toolkit runtime libraries
  DCMTK includes a collection of libraries and applications for examining,
@@ -60,7 +61,7 @@
 Package: libdcmtk-dev
 Architecture: any
 Section: libdevel
-Depends: libdcmtk17 (= ${binary:Version}),
+Depends: libdcmtk17t64 (= ${binary:Version}),
  libpng-dev,
  libssl-dev,
  libtiff-dev,
diff -Nru dcmtk-3.6.7/debian/libdcmtk17.install 
dcmtk-3.6.7/debian/libdcmtk17.install
--- dcmtk-3.6.7/debian/libdcmtk17.install   2023-06-22 07:53:48.0 
+
+++ dcmtk-3.6.7/debian/libdcmtk17.install   1970-01-01 00:00:00.0 
+
@@ -1,2 +0,0 @@
-usr/lib/*/*.so.*
-usr/share/libdcmtk17/*.dic
diff -Nru dcmtk-3.6.7/debian/libdcmtk17.lintian-overrides 
dcmtk-3.6.7/debian/libdcmtk17.lintian-overrides
--- dcmtk-3.6.7/debian/libdcmtk17.lintian-overrides 2023-06-22 
07:53:48.0 +
+++ dcmtk-3.6.7/debian/libdcmtk17.lintian-overrides 1970-01-01 
00:00:00.0 +
@@ -1,5 +0,0 @@
-# There is more than one library in one package bundles which makes perfectly
-# sense in this application but does not enable naming the library package 
apropriately
-libdcmtk17: package-name-doesnt-match-sonames
-libdcmtk17: embedded-library
-libdcmtk17: no-symbols-control-file
diff -Nru dcmtk-3.6.7/debian/libdcmtk17t64.install 
dcmtk-3.6.7/debian/libdcmtk17t64.install
--- dcmtk-3.6.7/debian/libdcmtk17t64.install1970-01-01 00:00:00.0 
+
+++ dcmtk-3.6.7/debian/libdcmtk17t64.install2023-06-22 07:53:48.0 
+
@@ -0,0 +1,2 @@
+usr/lib/*/*.so.*
+usr/share/libdcmtk17/*.dic
diff -Nru dcmtk-3.6.7/debian/libdcmtk17t64.lintian-overrides 
dcmtk-3.6.7/debian/libdcmtk17t64.lintian-overrides
--- dcmtk-3.6.7/debian/libdcmtk17t64.lintian-overrides  1970-01-01 
00:00:00.0 +
+++ dcmtk-3.6.7/debian/libdcmtk17t64.lintian-overrides  2024-02-28 
01:16:44.0 +
@@ -0,0 +1,6 @@
+# There is more than one library in one package bundles which makes perfectly
+# sense in this application but does not enable naming the library package 
apropriately
+libdcmtk17t64: package-name-doesnt-match-sonames
+libdcmtk17t64: embedded-library
+libdcmtk17t64: no-symbols-control-file
+libdcmtk17t64: package-name-doesnt-match-sonames libdcmtk17

Bug#1062022: dcmtk: NMU diff for 64-bit time_t transition

2024-02-20 Thread Michael Hudson-Doyle 
On Wed, 31 Jan 2024 at 22:03, Mathieu Malaterre  wrote:

> Hi,
>
> On Wed, Jan 31, 2024 at 1:09 AM  wrote:
> > If you have any concerns about this patch, please reach out ASAP.
> Although
> > this package will be uploaded to experimental immediately, there will be
> a
>
> Are you going to nuke my work on dcmtk 3.6.8 transition ?
>

Hi,

Sorry for the late reply. No, we are not going to nuke your work on the
transition. We still expect to NMU dcmtk to unstable along with the other
packages to avoid creating a dependence on your timetable, but you should
be able to ignore those changes when you do your transition in unstable.

Cheers,
mwh

Bug#1062022: dcmtk: NMU diff for 64-bit time_t transition

2024-01-31 Thread Mathieu Malaterre 
Hi,

On Wed, Jan 31, 2024 at 1:09 AM  wrote:
> If you have any concerns about this patch, please reach out ASAP.  Although
> this package will be uploaded to experimental immediately, there will be a

Are you going to nuke my work on dcmtk 3.6.8 transition ?

Bug#1062022: dcmtk: NMU diff for 64-bit time_t transition

2024-01-30 Thread mwhudson 
Source: dcmtk
Version: 3.6.7-9
Severity: serious
Tags: patch pending
Justification: library ABI skew on upgrade
User: debian-...@lists.debian.org
Usertags: time-t

Dear maintainer,

As part of the 64-bit time_t transition required to support 32-bit
architectures in 2038 and beyond
(https://wiki.debian.org/ReleaseGoals/64bit-time), we have identified
dcmtk as a source package shipping runtime libraries whose ABI
either is affected by the change in size of time_t, or could not be
analyzed via abi-compliance-checker (and therefore to be on the safe
side we assume is affected).

To ensure that inconsistent combinations of libraries with their
reverse-dependencies are never installed together, it is necessary to
have a library transition, which is most easily done by renaming the
runtime library package.

Since turning on 64-bit time_t is being handled centrally through a change
to the default dpkg-buildflags (https://bugs.debian.org/1037136), it is
important that libraries affected by this ABI change all be uploaded close
together in time.  Therefore I have prepared a 0-day NMU for dcmtk
which will initially be uploaded to experimental if possible, then to
unstable after packages have cleared binary NEW.

Please find the patch for this NMU attached.

If you have any concerns about this patch, please reach out ASAP.  Although
this package will be uploaded to experimental immediately, there will be a
period of several days before we begin uploads to unstable; so if information
becomes available that your package should not be included in the transition,
there is time for us to amend the planned uploads.



-- System Information:
Debian Release: trixie/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 6.5.0-15-generic (SMP w/16 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_WARN, TAINT_OOT_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
diff -Nru dcmtk-3.6.7/debian/changelog dcmtk-3.6.7/debian/changelog
--- dcmtk-3.6.7/debian/changelog2023-06-22 07:53:48.0 +
+++ dcmtk-3.6.7/debian/changelog2024-01-30 23:57:13.0 +
@@ -1,3 +1,10 @@
+dcmtk (3.6.7-9.1) experimental; urgency=medium
+
+  * Non-maintainer upload.
+  * Rename libraries for 64-bit time_t transition.
+
+ -- Michael Hudson-Doyle   Tue, 30 Jan 2024 23:57:13 +
+
 dcmtk (3.6.7-9) unstable; urgency=medium
 
   * Team upload.
diff -Nru dcmtk-3.6.7/debian/control dcmtk-3.6.7/debian/control
--- dcmtk-3.6.7/debian/control  2023-06-22 07:53:48.0 +
+++ dcmtk-3.6.7/debian/control  2024-01-30 23:57:13.0 +
@@ -38,13 +38,14 @@
  .
  Note: This version was compiled with libssl support.
 
-Package: libdcmtk17
+Package: libdcmtk17t64
+Provides: ${t64:Provides}
 Architecture: any
 Section: libs
 Depends: ${misc:Depends},
  ${shlibs:Depends}
-Breaks: libdcmtk16 (= 3.6.7-1)
-Replaces: libdcmtk16 (= 3.6.7-1)
+Breaks: libdcmtk17 (<< ${source:Version}), libdcmtk16 (= 3.6.7-1)
+Replaces: libdcmtk17, libdcmtk16 (= 3.6.7-1)
 Multi-Arch: same
 Description: OFFIS DICOM toolkit runtime libraries
  DCMTK includes a collection of libraries and applications for examining,
@@ -60,7 +61,7 @@
 Package: libdcmtk-dev
 Architecture: any
 Section: libdevel
-Depends: libdcmtk17 (= ${binary:Version}),
+Depends: libdcmtk17t64 (= ${binary:Version}),
  libpng-dev,
  libssl-dev,
  libtiff-dev,
diff -Nru dcmtk-3.6.7/debian/libdcmtk17.install 
dcmtk-3.6.7/debian/libdcmtk17.install
--- dcmtk-3.6.7/debian/libdcmtk17.install   2023-06-22 07:53:48.0 
+
+++ dcmtk-3.6.7/debian/libdcmtk17.install   1970-01-01 00:00:00.0 
+
@@ -1,2 +0,0 @@
-usr/lib/*/*.so.*
-usr/share/libdcmtk17/*.dic
diff -Nru dcmtk-3.6.7/debian/libdcmtk17.lintian-overrides 
dcmtk-3.6.7/debian/libdcmtk17.lintian-overrides
--- dcmtk-3.6.7/debian/libdcmtk17.lintian-overrides 2023-06-22 
07:53:48.0 +
+++ dcmtk-3.6.7/debian/libdcmtk17.lintian-overrides 1970-01-01 
00:00:00.0 +
@@ -1,5 +0,0 @@
-# There is more than one library in one package bundles which makes perfectly
-# sense in this application but does not enable naming the library package 
apropriately
-libdcmtk17: package-name-doesnt-match-sonames
-libdcmtk17: embedded-library
-libdcmtk17: no-symbols-control-file
diff -Nru dcmtk-3.6.7/debian/libdcmtk17t64.install 
dcmtk-3.6.7/debian/libdcmtk17t64.install
--- dcmtk-3.6.7/debian/libdcmtk17t64.install1970-01-01 00:00:00.0 
+
+++ dcmtk-3.6.7/debian/libdcmtk17t64.install2023-06-22 07:53:48.0 
+
@@ -0,0 +1,2 @@
+usr/lib/*/*.so.*
+usr/share/libdcmtk17/*.dic
diff -Nru dcmtk-3.6.7/debian/libdcmtk17t64.lintian-overrides 
dcmtk-3.6.7/debian/libdcmtk17t64.lintian-overrides
--- dcmtk-3.6.7/debian/libdcmtk17t64.lintian-overrides  1970-01-01