Bug#1062422: libmpdclient: NMU diff for 64-bit time_t transition

2024-02-28 Thread Benjamin Drung
Source: libmpdclient
Dear maintainer,

Please find attached a final version of this patch for the time_t
transition.  This patch is being uploaded to unstable.

Note that this adds a versioned build-dependency on dpkg-dev, to guard
against accidental backports with a wrong ABI.

Thanks!


-- System Information:
Debian Release: trixie/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 6.5.0-21-generic (SMP w/16 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, 
TAINT_UNSIGNED_MODULE
Locale: LANG=C, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: unable to detect
diff -Nru libmpdclient-2.22/debian/changelog libmpdclient-2.22/debian/changelog
--- libmpdclient-2.22/debian/changelog  2023-12-22 17:14:09.0 +
+++ libmpdclient-2.22/debian/changelog  2024-02-28 14:13:45.0 +
@@ -1,3 +1,10 @@
+libmpdclient (2.22-1.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Rename libraries for 64-bit time_t transition.  Closes: #1062422
+
+ -- Benjamin Drung   Wed, 28 Feb 2024 14:13:45 +
+
 libmpdclient (2.22-1) unstable; urgency=medium
 
   * Team upload
diff -Nru libmpdclient-2.22/debian/control libmpdclient-2.22/debian/control
--- libmpdclient-2.22/debian/control2023-12-21 13:40:26.0 +
+++ libmpdclient-2.22/debian/control2024-02-28 14:13:44.0 +
@@ -3,7 +3,7 @@
 Priority: optional
 Maintainer: mpd maintainers 
 Uploaders: Sebastian Harl , Florian Schlichting 

-Build-Depends: debhelper-compat (= 13),
+Build-Depends: dpkg-dev (>= 1.22.5), debhelper-compat (= 13),
check,
cmake,
meson (>= 0.47),
@@ -19,7 +19,7 @@
 Section: libdevel
 Architecture: any
 Multi-Arch: same
-Depends: libmpdclient2 (= ${binary:Version}), ${misc:Depends}
+Depends: libmpdclient2t64 (= ${binary:Version}), ${misc:Depends}
 Description: client library for the Music Player Daemon (development files)
  libmpdclient provides an API for interfacing the Music Player Daemon (MPD). It
  offers a low-level asynchronous API which knowns the MPD protocol syntax as
@@ -28,7 +28,10 @@
  .
  This package contains the header files.
 
-Package: libmpdclient2
+Package: libmpdclient2t64
+Provides: ${t64:Provides}
+Replaces: libmpdclient2
+Breaks: libmpdclient2 (<< ${source:Version})
 Architecture: any
 Multi-Arch: same
 Depends: ${shlibs:Depends}, ${misc:Depends}
diff -Nru libmpdclient-2.22/debian/libmpdclient2.install 
libmpdclient-2.22/debian/libmpdclient2.install
--- libmpdclient-2.22/debian/libmpdclient2.install  2023-12-20 
20:28:51.0 +
+++ libmpdclient-2.22/debian/libmpdclient2.install  1970-01-01 
00:00:00.0 +
@@ -1 +0,0 @@
-usr/lib/*/lib*.so.*
diff -Nru libmpdclient-2.22/debian/libmpdclient2.symbols 
libmpdclient-2.22/debian/libmpdclient2.symbols
--- libmpdclient-2.22/debian/libmpdclient2.symbols  2023-12-22 
17:11:33.0 +
+++ libmpdclient-2.22/debian/libmpdclient2.symbols  1970-01-01 
00:00:00.0 +
@@ -1,448 +0,0 @@
-libmpdclient.so.2 libmpdclient2 #MINVER#
-* Build-Depends-Package: libmpdclient-dev
- libmpdclient2@libmpdclient2 2.0
- mpd_async_events@libmpdclient2 2.0
- mpd_async_free@libmpdclient2 2.0
- mpd_async_get_error@libmpdclient2 2.0
- mpd_async_get_error_message@libmpdclient2 2.0
- mpd_async_get_fd@libmpdclient2 2.0
- mpd_async_get_system_error@libmpdclient2 2.0
- mpd_async_io@libmpdclient2 2.0
- mpd_async_new@libmpdclient2 2.0
- mpd_async_recv_line@libmpdclient2 2.0
- mpd_async_recv_raw@libmpdclient2 2.17
- mpd_async_send_command@libmpdclient2 2.0
- mpd_async_send_command_v@libmpdclient2 2.0
- mpd_async_set_keepalive@libmpdclient2 2.11
- mpd_command_list_begin@libmpdclient2 2.0
- mpd_command_list_end@libmpdclient2 2.0
- mpd_connection_clear_error@libmpdclient2 2.0
- mpd_connection_cmp_server_version@libmpdclient2 2.0
- mpd_connection_free@libmpdclient2 2.0
- mpd_connection_get_async@libmpdclient2 2.0
- mpd_connection_get_error@libmpdclient2 2.0
- mpd_connection_get_error_message@libmpdclient2 2.0
- mpd_connection_get_fd@libmpdclient2 2.0
- mpd_connection_get_server_error@libmpdclient2 2.0
- mpd_connection_get_server_error_location@libmpdclient2 2.9
- mpd_connection_get_server_version@libmpdclient2 2.0
- mpd_connection_get_settings@libmpdclient2 2.9
- mpd_connection_get_system_error@libmpdclient2 2.0
- mpd_connection_new@libmpdclient2 2.0
- mpd_connection_new_async@libmpdclient2 2.0
- mpd_connection_set_keepalive@libmpdclient2 2.11
- mpd_connection_set_timeout@libmpdclient2 2.0
- mpd_count_db_songs@libmpdclient2 2.0
- mpd_directory_begin@libmpdclient2 2.0
- mpd_directory_dup@libmpdclient2 2.0
- mpd_directory_feed@libmpdclient2 2.0
- mpd_directory_free@libmpdclient2 2.0
- mpd_directory_get_last_modified@libmpdclient2 2.9
- mpd_directory_get_path@libmpdclient2 2.0
- mpd_enqueue_pair@libmpdclient2 2.0
- mpd_entity_begin@libmpdclient2 2.0
- 

Bug#1062422: libmpdclient: NMU diff for 64-bit time_t transition

2024-02-01 Thread Steve Langasek
Source: libmpdclient
Version: 2.22-1
Severity: serious
Tags: patch pending
Justification: library ABI skew on upgrade
User: debian-...@lists.debian.org
Usertags: time-t

Dear maintainer,

As part of the 64-bit time_t transition required to support 32-bit
architectures in 2038 and beyond
(https://wiki.debian.org/ReleaseGoals/64bit-time), we have identified
libmpdclient as a source package shipping runtime libraries whose ABI
either is affected by the change in size of time_t, or could not be
analyzed via abi-compliance-checker (and therefore to be on the safe
side we assume is affected).

To ensure that inconsistent combinations of libraries with their
reverse-dependencies are never installed together, it is necessary to
have a library transition, which is most easily done by renaming the
runtime library package.

Since turning on 64-bit time_t is being handled centrally through a change
to the default dpkg-buildflags (https://bugs.debian.org/1037136), it is
important that libraries affected by this ABI change all be uploaded close
together in time.  Therefore I have prepared a 0-day NMU for libmpdclient
which will initially be uploaded to experimental if possible, then to
unstable after packages have cleared binary NEW.

Please find the patch for this NMU attached.

If you have any concerns about this patch, please reach out ASAP.  Although
this package will be uploaded to experimental immediately, there will be a
period of several days before we begin uploads to unstable; so if information
becomes available that your package should not be included in the transition,
there is time for us to amend the planned uploads.



-- System Information:
Debian Release: trixie/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 6.5.0-14-generic (SMP w/12 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE
Locale: LANG=C, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
diff -Nru libmpdclient-2.22/debian/changelog libmpdclient-2.22/debian/changelog
--- libmpdclient-2.22/debian/changelog  2023-12-22 17:14:09.0 +
+++ libmpdclient-2.22/debian/changelog  2024-02-01 10:12:06.0 +
@@ -1,3 +1,10 @@
+libmpdclient (2.22-1.1) experimental; urgency=medium
+
+  * Non-maintainer upload.
+  * Rename libraries for 64-bit time_t transition.
+
+ -- Steve Langasek   Thu, 01 Feb 2024 10:12:06 +
+
 libmpdclient (2.22-1) unstable; urgency=medium
 
   * Team upload
diff -Nru libmpdclient-2.22/debian/control libmpdclient-2.22/debian/control
--- libmpdclient-2.22/debian/control2023-12-21 13:40:26.0 +
+++ libmpdclient-2.22/debian/control2024-02-01 10:12:06.0 +
@@ -19,7 +19,7 @@
 Section: libdevel
 Architecture: any
 Multi-Arch: same
-Depends: libmpdclient2 (= ${binary:Version}), ${misc:Depends}
+Depends: libmpdclient2t64 (= ${binary:Version}), ${misc:Depends}
 Description: client library for the Music Player Daemon (development files)
  libmpdclient provides an API for interfacing the Music Player Daemon (MPD). It
  offers a low-level asynchronous API which knowns the MPD protocol syntax as
@@ -28,7 +28,10 @@
  .
  This package contains the header files.
 
-Package: libmpdclient2
+Package: libmpdclient2t64
+Provides: ${t64:Provides}
+Replaces: libmpdclient2
+Breaks: libmpdclient2 (<< ${source:Version})
 Architecture: any
 Multi-Arch: same
 Depends: ${shlibs:Depends}, ${misc:Depends}
diff -Nru libmpdclient-2.22/debian/libmpdclient2.install 
libmpdclient-2.22/debian/libmpdclient2.install
--- libmpdclient-2.22/debian/libmpdclient2.install  2023-12-20 
20:28:51.0 +
+++ libmpdclient-2.22/debian/libmpdclient2.install  1970-01-01 
00:00:00.0 +
@@ -1 +0,0 @@
-usr/lib/*/lib*.so.*
diff -Nru libmpdclient-2.22/debian/libmpdclient2.symbols 
libmpdclient-2.22/debian/libmpdclient2.symbols
--- libmpdclient-2.22/debian/libmpdclient2.symbols  2023-12-22 
17:11:33.0 +
+++ libmpdclient-2.22/debian/libmpdclient2.symbols  1970-01-01 
00:00:00.0 +
@@ -1,448 +0,0 @@
-libmpdclient.so.2 libmpdclient2 #MINVER#
-* Build-Depends-Package: libmpdclient-dev
- libmpdclient2@libmpdclient2 2.0
- mpd_async_events@libmpdclient2 2.0
- mpd_async_free@libmpdclient2 2.0
- mpd_async_get_error@libmpdclient2 2.0
- mpd_async_get_error_message@libmpdclient2 2.0
- mpd_async_get_fd@libmpdclient2 2.0
- mpd_async_get_system_error@libmpdclient2 2.0
- mpd_async_io@libmpdclient2 2.0
- mpd_async_new@libmpdclient2 2.0
- mpd_async_recv_line@libmpdclient2 2.0
- mpd_async_recv_raw@libmpdclient2 2.17
- mpd_async_send_command@libmpdclient2 2.0
- mpd_async_send_command_v@libmpdclient2 2.0
- mpd_async_set_keepalive@libmpdclient2 2.11
- mpd_command_list_begin@libmpdclient2 2.0
- mpd_command_list_end@libmpdclient2 2.0
- mpd_connection_clear_error@libmpdclient2 2.0
-