Bug#1062783: libxfce4ui FTCBFS: fails running gtk-doc scanner
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On Mon, 2024-02-05 at 20:38 +0100, Helmut Grohne wrote: > Is this line of reasoning convincing to you? Yes indeed, thanks for the explanation then. I'll import the diff to our repository. Regards, - -- Yves-Alexis -BEGIN PGP SIGNATURE- iQEzBAEBCAAdFiEE8vi34Qgfo83x35gF3rYcyPpXRFsFAmXCi3YACgkQ3rYcyPpX RFt4dwf/bXtVCuA9JN+o5DvMscBqVph819yDX7yz3FJJHmDxGOEJpm8qexb/buP1 I0KDPA5AVrEtMpDkJUzRfggg9wIjG1vEo//pIhEPrSZZdTnBA59aQe/2tKnfItX8 7JRORtZQ8AG3wvHg5ZfUXDlSqXgQyGFjD7doNpVpgGvUXEHcGJH5jO07OXI6UgYK OgnGsMCPxhjYlOOhZHubfzVra59i2/8B0QZicNqsA0PtTFsw7hsLbXO/jGa+dRft tbET8DzwYCuO8sjAqEMQY6z6+k0uWp3JwjjVGhaaRtDYbg4xaiD3J8Z2C7Lj5s9h uiLFEE3RHiFcIGcHR1ehXpBOm6DlVA== =f4R0 -END PGP SIGNATURE-
Bug#1062783: libxfce4ui FTCBFS: fails running gtk-doc scanner
Hi, On Mon, Feb 05, 2024 at 04:40:38PM +0100, Yves-Alexis Perez wrote: > The patch looks small, and I don't know a lot about cross-building, but would > it be better to use something like: > > ifneq (,$(filter cross,$(DEB_BUILD_PROFILES)) > > inside override_dh_auto_configure to only add gtk-doc when not cross-building? While that might technically work, such cross vs native differences are fragile and in a lot of cases, I've had to fix them, so I strongly prefer to not add cross vs native differences to the build unless necessary. Here, no part of an arch-only build needs gtk-doc. For this, it does not matter whether the build is cross or native. It applies to any arch-only build. In particular, disabling gtk-doc, also speeds up the build. I actually performed an arch-only and a full build to verify that no files go missing by this change using reproducible builds. Is this line of reasoning convincing to you? Helmut
Bug#1062783: libxfce4ui FTCBFS: fails running gtk-doc scanner
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On Sat, 2024-02-03 at 10:34 +0100, Helmut Grohne wrote: > libxfce4ui fails to cross build from source, because it fails running > the gtk-doc scanner with an Exec format error. This is fairly usual. > Fortunately, it also splits out its documentation to an Arch:all > package. Hence, we can disable gtk-doc in arch-only builds and thus > side-step this problem making the cross build succeed. I'm attaching a > patch for your convenience. Hi Helmut, thanks for the report and the patch. The patch looks small, and I don't know a lot about cross-building, but would it be better to use something like: ifneq (,$(filter cross,$(DEB_BUILD_PROFILES)) inside override_dh_auto_configure to only add gtk-doc when not cross-building? Regards, - -- Yves-Alexis -BEGIN PGP SIGNATURE- iQEzBAEBCAAdFiEE8vi34Qgfo83x35gF3rYcyPpXRFsFAmXBAXYACgkQ3rYcyPpX RFsBbwgA6yOREFfPDlNddwz6VZIYSF0IfxZ5/A5R5QB3xu+Nxx/ZYDl5XcSxALvQ 32BRjN1+cpubRj4R1h5yJ8RN3ac+ykz0PI7TmPw7zmYodJ0fYP/aCiONJZbIbuP5 4PAR9VLfI0EZ9Du7ArYuhN/bz//MXEO1ruHHl2nEigWzzPJinu3FUWIp42U5vI76 VfYSNz3mH1gFk0rshwMqsOx3Uokb5r1L+egGV7AwL79qJqXabMGolyMwjEzEWC23 +SmyY0NWaPwJBOSDTQ2Ren3lMeRE13FlowwQ0KzclDqEHNcZqlcBalC5d3iKzfLm ng5eQv8ht3WwkwW6vVDPyqc2VE0Wag== =h+YT -END PGP SIGNATURE-
Bug#1062783: libxfce4ui FTCBFS: fails running gtk-doc scanner
Source: libxfce4ui Version: 4.18.4-1 Tags: patch User: debian-cr...@lists.debian.org Usertags: ftcbfs libxfce4ui fails to cross build from source, because it fails running the gtk-doc scanner with an Exec format error. This is fairly usual. Fortunately, it also splits out its documentation to an Arch:all package. Hence, we can disable gtk-doc in arch-only builds and thus side-step this problem making the cross build succeed. I'm attaching a patch for your convenience. Helmut --- libxfce4ui-4.18.4/debian/changelog +++ libxfce4ui-4.18.4/debian/changelog @@ -1,3 +1,10 @@ +libxfce4ui (4.18.4-1.1) UNRELEASED; urgency=medium + + * Non-maintainer upload. + * Fix FTCBFS: Skip gtkdoc in arch-only build. (Closes: #-1) + + -- Helmut Grohne Sat, 03 Feb 2024 08:53:15 +0100 + libxfce4ui (4.18.4-1) unstable; urgency=medium * Team upload. --- libxfce4ui-4.18.4/debian/rules +++ libxfce4ui-4.18.4/debian/rules @@ -14,7 +14,7 @@ override_dh_auto_configure: dh_auto_configure -- \ --with-vendor-info=$(XFVENDOR) \ - --enable-gtk-doc \ + --$(if $(filter libxfce4ui-common,$(shell dh_listpackages)),en,dis)able-gtk-doc \ --enable-introspection=yes \ --enable-vala=no
