Bug#1062854: reiserfsprogs: NMU diff for 64-bit time_t transition

2024-02-29 Thread Benjamin Drung 
Source: reiserfsprogs
Dear maintainer,

Please find attached a final version of this patch for the time_t
transition.  This patch is being uploaded to unstable.

Note that this adds a versioned build-dependency on dpkg-dev, to guard
against accidental backports with a wrong ABI.

Thanks!


-- System Information:
Debian Release: trixie/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 6.5.0-21-generic (SMP w/16 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, 
TAINT_UNSIGNED_MODULE
Locale: LANG=C, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: unable to detect
diff -Nru reiserfsprogs-3.6.27/debian/changelog 
reiserfsprogs-3.6.27/debian/changelog
--- reiserfsprogs-3.6.27/debian/changelog   2023-09-20 16:33:40.0 
+
+++ reiserfsprogs-3.6.27/debian/changelog   2024-02-29 22:53:45.0 
+
@@ -1,3 +1,10 @@
+reiserfsprogs (1:3.6.27-7.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Rename libraries for 64-bit time_t transition.  Closes: #1062854
+
+ -- Benjamin Drung   Thu, 29 Feb 2024 22:53:45 +
+
 reiserfsprogs (1:3.6.27-7) unstable; urgency=medium
 
   * Remove udebs. Acked by Cyril Brulebois and Steve McIntyre on d-boot
diff -Nru reiserfsprogs-3.6.27/debian/control 
reiserfsprogs-3.6.27/debian/control
--- reiserfsprogs-3.6.27/debian/control 2023-09-18 16:53:43.0 +
+++ reiserfsprogs-3.6.27/debian/control 2024-02-29 22:53:45.0 +
@@ -2,13 +2,13 @@
 Section: admin
 Priority: optional
 Maintainer: Felix Zielcke 
-Build-Depends: comerr-dev, debhelper-compat (= 13), libacl1-dev, uuid-dev
+Build-Depends: dpkg-dev (>= 1.22.5), comerr-dev, debhelper-compat (= 13), 
libacl1-dev, uuid-dev
 Standards-Version: 4.6.2
 Rules-Requires-Root: no
 
 Package: reiserfsprogs
 Architecture: linux-any
-Depends: libreiserfscore0 (= ${binary:Version}),
+Depends: libreiserfscore0t64 (= ${binary:Version}),
  ${misc:Depends},
  ${shlibs:Depends}
 Suggests: fdisk | util-linux (<< 2.29.2-3~)
@@ -16,7 +16,10 @@
  This package contains utilities to create, check, resize, and debug
  ReiserFS filesystems.
 
-Package: libreiserfscore0
+Package: libreiserfscore0t64
+Provides: ${t64:Provides}
+Replaces: libreiserfscore0
+Breaks: libreiserfscore0 (<< ${source:Version})
 Architecture: linux-any
 Section: libs
 Depends: ${misc:Depends}, ${shlibs:Depends}
@@ -28,7 +31,7 @@
 Package: libreiserfscore-dev
 Architecture: linux-any
 Section: libdevel
-Depends: libreiserfscore0 (=${binary:Version}), ${misc:Depends}
+Depends: libreiserfscore0t64 (=${binary:Version}), ${misc:Depends}
 Description: ReiserFS core library - headers
  The ReiserFS core library allows system programs like btrfs-progs to
  access and convert ReiserFS filesystems. Without implementing all
diff -Nru reiserfsprogs-3.6.27/debian/libreiserfscore0.install 
reiserfsprogs-3.6.27/debian/libreiserfscore0.install
--- reiserfsprogs-3.6.27/debian/libreiserfscore0.install2023-02-15 
17:44:50.0 +
+++ reiserfsprogs-3.6.27/debian/libreiserfscore0.install1970-01-01 
00:00:00.0 +
@@ -1 +0,0 @@
-usr/lib/*/libreiserfscore.so.*
diff -Nru reiserfsprogs-3.6.27/debian/libreiserfscore0t64.install 
reiserfsprogs-3.6.27/debian/libreiserfscore0t64.install
--- reiserfsprogs-3.6.27/debian/libreiserfscore0t64.install 1970-01-01 
00:00:00.0 +
+++ reiserfsprogs-3.6.27/debian/libreiserfscore0t64.install 2023-02-15 
17:44:50.0 +
@@ -0,0 +1 @@
+usr/lib/*/libreiserfscore.so.*
diff -Nru reiserfsprogs-3.6.27/debian/libreiserfscore0t64.lintian-overrides 
reiserfsprogs-3.6.27/debian/libreiserfscore0t64.lintian-overrides
--- reiserfsprogs-3.6.27/debian/libreiserfscore0t64.lintian-overrides   
1970-01-01 00:00:00.0 +
+++ reiserfsprogs-3.6.27/debian/libreiserfscore0t64.lintian-overrides   
2024-02-29 22:53:41.0 +
@@ -0,0 +1 @@
+libreiserfscore0t64: package-name-doesnt-match-sonames libreiserfscore0

Bug#1062854: reiserfsprogs: NMU diff for 64-bit time_t transition

2024-02-04 Thread Felix Zielcke 
Am Samstag, dem 03.02.2024 um 20:27 + schrieb Sergio Durigan
Junior:
> Source: reiserfsprogs
> Version: 1:3.6.27-7
> Severity: serious
> Tags: patch pending sid trixie
> Justification: library ABI skew on upgrade
> User: debian-...@lists.debian.org
> Usertags: time-t
> 
> NOTICE: these changes must not be uploaded to unstable yet!
> 
> Dear maintainer,
> 
> As part of the 64-bit time_t transition required to support 32-bit
> architectures in 2038 and beyond
> (https://wiki.debian.org/ReleaseGoals/64bit-time), we have identified
> reiserfsprogs as a source package shipping runtime libraries whose
> ABI
> either is affected by the change in size of time_t, or could not be
> analyzed via abi-compliance-checker (and therefore to be on the safe
> side we assume is affected).
> 
> 

Hi,

thanks for working on the time_t transistion.

But ReiserFS is too old. It still uses 32bit fields in it's superblock
and other metadata blocks.
And fsck is just writing out the return value of time(NULL) to the
superblock when the last check was run.

So I don't think it makes currently any problems. But it can't be made
64bit safe and so shouldn't be used at all in 2038 and beyond.

Luckly it has been already marked deprecated upstream and scheduled for
removal in Linux this year 2024

Only problem to directly RM reiserfsprogs is, that now btrfs-progs
depend on libreiserfscore0 due to btrfs-convert supporting ReiserFS.

Cheers
Felix

Bug#1062854: reiserfsprogs: NMU diff for 64-bit time_t transition

2024-02-03 Thread Sergio Durigan Junior 
Source: reiserfsprogs
Version: 1:3.6.27-7
Severity: serious
Tags: patch pending sid trixie
Justification: library ABI skew on upgrade
User: debian-...@lists.debian.org
Usertags: time-t

NOTICE: these changes must not be uploaded to unstable yet!

Dear maintainer,

As part of the 64-bit time_t transition required to support 32-bit
architectures in 2038 and beyond
(https://wiki.debian.org/ReleaseGoals/64bit-time), we have identified
reiserfsprogs as a source package shipping runtime libraries whose ABI
either is affected by the change in size of time_t, or could not be
analyzed via abi-compliance-checker (and therefore to be on the safe
side we assume is affected).

To ensure that inconsistent combinations of libraries with their
reverse-dependencies are never installed together, it is necessary to
have a library transition, which is most easily done by renaming the
runtime library package.

Since turning on 64-bit time_t is being handled centrally through a change
to the default dpkg-buildflags (https://bugs.debian.org/1037136), it is
important that libraries affected by this ABI change all be uploaded close
together in time.  Therefore I have prepared a 0-day NMU for reiserfsprogs
which will initially be uploaded to experimental if possible, then to
unstable after packages have cleared binary NEW.

Please find the patch for this NMU attached.

If you have any concerns about this patch, please reach out ASAP.  Although
this package will be uploaded to experimental immediately, there will be a
period of several days before we begin uploads to unstable; so if information
becomes available that your package should not be included in the transition,
there is time for us to amend the planned uploads.



-- System Information:
Debian Release: trixie/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 6.5.0-5-amd64 (SMP w/32 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, 
TAINT_UNSIGNED_MODULE
Locale: LANG=C, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: unable to detect
diff -Nru reiserfsprogs-3.6.27/debian/changelog 
reiserfsprogs-3.6.27/debian/changelog
--- reiserfsprogs-3.6.27/debian/changelog   2023-09-20 16:33:40.0 
+
+++ reiserfsprogs-3.6.27/debian/changelog   2024-02-03 20:26:44.0 
+
@@ -1,3 +1,10 @@
+reiserfsprogs (1:3.6.27-7.1) experimental; urgency=medium
+
+  * Non-maintainer upload.
+  * Rename libraries for 64-bit time_t transition.
+
+ -- Sergio Durigan Junior   Sat, 03 Feb 2024 20:26:44 
+
+
 reiserfsprogs (1:3.6.27-7) unstable; urgency=medium
 
   * Remove udebs. Acked by Cyril Brulebois and Steve McIntyre on d-boot
diff -Nru reiserfsprogs-3.6.27/debian/control 
reiserfsprogs-3.6.27/debian/control
--- reiserfsprogs-3.6.27/debian/control 2023-09-18 16:53:43.0 +
+++ reiserfsprogs-3.6.27/debian/control 2024-02-03 20:26:44.0 +
@@ -8,7 +8,7 @@
 
 Package: reiserfsprogs
 Architecture: linux-any
-Depends: libreiserfscore0 (= ${binary:Version}),
+Depends: libreiserfscore0t64 (= ${binary:Version}),
  ${misc:Depends},
  ${shlibs:Depends}
 Suggests: fdisk | util-linux (<< 2.29.2-3~)
@@ -16,7 +16,10 @@
  This package contains utilities to create, check, resize, and debug
  ReiserFS filesystems.
 
-Package: libreiserfscore0
+Package: libreiserfscore0t64
+Provides: ${t64:Provides}
+Replaces: libreiserfscore0
+Breaks: libreiserfscore0 (<< ${source:Version})
 Architecture: linux-any
 Section: libs
 Depends: ${misc:Depends}, ${shlibs:Depends}
@@ -28,7 +31,7 @@
 Package: libreiserfscore-dev
 Architecture: linux-any
 Section: libdevel
-Depends: libreiserfscore0 (=${binary:Version}), ${misc:Depends}
+Depends: libreiserfscore0t64 (=${binary:Version}), ${misc:Depends}
 Description: ReiserFS core library - headers
  The ReiserFS core library allows system programs like btrfs-progs to
  access and convert ReiserFS filesystems. Without implementing all
diff -Nru reiserfsprogs-3.6.27/debian/libreiserfscore0.install 
reiserfsprogs-3.6.27/debian/libreiserfscore0.install
--- reiserfsprogs-3.6.27/debian/libreiserfscore0.install2023-02-15 
17:44:50.0 +
+++ reiserfsprogs-3.6.27/debian/libreiserfscore0.install1970-01-01 
00:00:00.0 +
@@ -1 +0,0 @@
-usr/lib/*/libreiserfscore.so.*
diff -Nru reiserfsprogs-3.6.27/debian/libreiserfscore0t64.install 
reiserfsprogs-3.6.27/debian/libreiserfscore0t64.install
--- reiserfsprogs-3.6.27/debian/libreiserfscore0t64.install 1970-01-01 
00:00:00.0 +
+++ reiserfsprogs-3.6.27/debian/libreiserfscore0t64.install 2023-02-15 
17:44:50.0 +
@@ -0,0 +1 @@
+usr/lib/*/libreiserfscore.so.*
diff -Nru reiserfsprogs-3.6.27/debian/libreiserfscore0t64.lintian-overrides 
reiserfsprogs-3.6.27/debian/libreiserfscore0t64.lintian-overrides
--- reiserfsprogs-3.6.27/debian/libreiserfscore0t64.lintian-overrides