Bug#1063221: pgpool2: NMU diff for 64-bit time_t transition

2024-03-01 Thread Steve Langasek
> please exclude pgpool2 from the t64 transition. It does ship a library
> package, but there are 0 external users, and all in-package rpdeps
> have strict versioned dependencies on libpgpool2.

While I will leave this to your discretion as maintainer, please note that
"0 external users" is not possible to determine conclusively.  There are 0
external users *in Debian*.  But this package ships a shared library, and a
-dev package to allow software to link against it; therefore, third-party
packages not included in Debian, which link against this library, may exist. 
If you want to be able to assert that this is not the case, it's better to
not ship a -dev package at all for your library.

-- 
Steve Langasek   Give me a lever long enough and a Free OS
Debian Developer   to set it on, and I can move the world.
Ubuntu Developer   https://www.debian.org/
slanga...@ubuntu.com vor...@debian.org


signature.asc
Description: PGP signature


Bug#1063221: pgpool2: NMU diff for 64-bit time_t transition

2024-02-05 Thread Lucas Kanashiro
Source: pgpool2
Version: 4.3.7-1
Severity: serious
Tags: patch pending sid trixie
Justification: library ABI skew on upgrade
User: debian-...@lists.debian.org
Usertags: time-t

NOTICE: these changes must not be uploaded to unstable yet!

Dear maintainer,

As part of the 64-bit time_t transition required to support 32-bit
architectures in 2038 and beyond
(https://wiki.debian.org/ReleaseGoals/64bit-time), we have identified
pgpool2 as a source package shipping runtime libraries whose ABI
either is affected by the change in size of time_t, or could not be
analyzed via abi-compliance-checker (and therefore to be on the safe
side we assume is affected).

To ensure that inconsistent combinations of libraries with their
reverse-dependencies are never installed together, it is necessary to
have a library transition, which is most easily done by renaming the
runtime library package.

Since turning on 64-bit time_t is being handled centrally through a change
to the default dpkg-buildflags (https://bugs.debian.org/1037136), it is
important that libraries affected by this ABI change all be uploaded close
together in time.  Therefore I have prepared a 0-day NMU for pgpool2
which will initially be uploaded to experimental if possible, then to
unstable after packages have cleared binary NEW.

Please find the patch for this NMU attached.

If you have any concerns about this patch, please reach out ASAP.  Although
this package will be uploaded to experimental immediately, there will be a
period of several days before we begin uploads to unstable; so if information
becomes available that your package should not be included in the transition,
there is time for us to amend the planned uploads.



-- System Information:
Debian Release: trixie/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 6.2.0-39-generic (SMP w/32 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, 
TAINT_UNSIGNED_MODULE
Locale: LANG=C.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
diff -Nru pgpool2-4.3.7/debian/changelog pgpool2-4.3.7/debian/changelog
--- pgpool2-4.3.7/debian/changelog  2023-11-25 07:47:05.0 -0300
+++ pgpool2-4.3.7/debian/changelog  2024-02-05 15:24:39.0 -0300
@@ -1,3 +1,10 @@
+pgpool2 (4.3.7-1.1) experimental; urgency=medium
+
+  * Non-maintainer upload.
+  * Rename libraries for 64-bit time_t transition.
+
+ -- Lucas Kanashiro   Mon, 05 Feb 2024 15:24:39 -0300
+
 pgpool2 (4.3.7-1) unstable; urgency=medium
 
   * New upstream version 4.3.7.
diff -Nru pgpool2-4.3.7/debian/control pgpool2-4.3.7/debian/control
--- pgpool2-4.3.7/debian/control2023-11-25 07:46:36.0 -0300
+++ pgpool2-4.3.7/debian/control2024-02-05 15:24:39.0 -0300
@@ -35,7 +35,7 @@
 Architecture: linux-any kfreebsd-any
 Pre-Depends: ${misc:Pre-Depends}
 Depends:
- libpgpool2 (= ${binary:Version}),
+ libpgpool2t64 (= ${binary:Version}),
  lsb-base,
  postgresql-common,
  ucf,
@@ -63,7 +63,10 @@
  .
  This is version 3 of pgpool-II, the second generation of pgpool.
 
-Package: libpgpool2
+Package: libpgpool2t64
+Provides: ${t64:Provides}
+Replaces: libpgpool2
+Breaks: libpgpool2 (<< ${source:Version})
 Architecture: linux-any kfreebsd-any
 Section: libs
 Depends: ${misc:Depends}, ${shlibs:Depends}
@@ -75,7 +78,7 @@
 Package: libpgpool-dev
 Architecture: linux-any kfreebsd-any
 Section: libdevel
-Depends: libpgpool2 (= ${binary:Version}), ${misc:Depends}, ${shlibs:Depends}
+Depends: libpgpool2t64 (= ${binary:Version}), ${misc:Depends}, 
${shlibs:Depends}
 # We also provide /usr/lib/libpcp.{a,so}
 Conflicts: libpcp3-dev
 Description: pgpool control protocol library - headers
@@ -86,7 +89,7 @@
 Package: postgresql-16-pgpool2
 Architecture: linux-any kfreebsd-any
 Depends:
- libpgpool2 (>= ${binary:Version}),
+ libpgpool2t64 (>= ${binary:Version}),
  postgresql-16,
  ${misc:Depends},
  ${shlibs:Depends},
diff -Nru pgpool2-4.3.7/debian/control.in pgpool2-4.3.7/debian/control.in
--- pgpool2-4.3.7/debian/control.in 2023-11-25 07:46:36.0 -0300
+++ pgpool2-4.3.7/debian/control.in 2024-02-05 15:24:39.0 -0300
@@ -35,7 +35,7 @@
 Architecture: linux-any kfreebsd-any
 Pre-Depends: ${misc:Pre-Depends}
 Depends:
- libpgpool2 (= ${binary:Version}),
+ libpgpool2t64 (= ${binary:Version}),
  lsb-base,
  postgresql-common,
  ucf,
@@ -63,7 +63,10 @@
  .
  This is version 3 of pgpool-II, the second generation of pgpool.
 
-Package: libpgpool2
+Package: libpgpool2t64
+Provides: ${t64:Provides}
+Replaces: libpgpool2
+Breaks: libpgpool2 (<< ${source:Version})
 Architecture: linux-any kfreebsd-any
 Section: libs
 Depends: ${misc:Depends}, ${shlibs:Depends}
@@ -75,7 +78,7 @@
 Package: libpgpool-dev
 Architecture: linux-any kfreebsd-any
 Section: libdevel
-Depends: libpgpool2 (= ${binary:Version}), ${misc:Depends}, ${shlibs:Depends}
+Depends: