Bug#1064531: src:amberol: unsatisfied build dependency in testing: librust-lofty-0.17-dev

2024-04-12 Thread Emanuele Rocca
Control: tags -1 + patch

Hi,

On 2024-02-23 08:33, Paul Gevers wrote:
> Dose [1] is reporting a build issue with your package, it's missing a
> build dependency.

It's actually two build deps that are missing: librust-lofty-0.17-dev
and librust-mpris-server-0.6-dev. Setting both to the versions currently
available in sid fixes the FTBFS. See attached patch.

  Emanuele
diff -Nru amberol-0.10.3/debian/changelog amberol-0.10.3/debian/changelog
--- amberol-0.10.3/debian/changelog	2024-01-06 12:12:15.0 +0100
+++ amberol-0.10.3/debian/changelog	2024-04-12 12:23:35.0 +0200
@@ -1,3 +1,11 @@
+amberol (0.10.3-2.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Update build dependencies: librust-lofty-0.18-dev,
+librust-mpris-server-0.7-dev. (Closes: #1064531) 
+
+ -- Emanuele Rocca   Fri, 12 Apr 2024 12:23:35 +0200
+
 amberol (0.10.3-2) unstable; urgency=medium
 
   * d/control: depend on `gstreamer1.0-plugins-good`
diff -Nru amberol-0.10.3/debian/control amberol-0.10.3/debian/control
--- amberol-0.10.3/debian/control	2024-01-06 12:12:15.0 +0100
+++ amberol-0.10.3/debian/control	2024-04-12 12:23:35.0 +0200
@@ -21,9 +21,9 @@
  librust-gdk-pixbuf-0.18+v2-42-dev,
  librust-gtk4-0.7+v4-10-dev,
  librust-libadwaita-0.5+v1-4-dev,
- librust-lofty-0.17-dev,
+ librust-lofty-0.18-dev,
  librust-log-0.4-dev,
- librust-mpris-server-0.6-dev,
+ librust-mpris-server-0.7-dev,
  librust-pretty-env-logger-0.5-dev,
  librust-once-cell-1-dev,
  librust-rand-0.8-dev,
diff -Nru amberol-0.10.3/debian/patches/0002-Update-dependencies.patch amberol-0.10.3/debian/patches/0002-Update-dependencies.patch
--- amberol-0.10.3/debian/patches/0002-Update-dependencies.patch	2024-01-06 12:12:15.0 +0100
+++ amberol-0.10.3/debian/patches/0002-Update-dependencies.patch	2024-04-12 12:23:03.0 +0200
@@ -36,7 +36,7 @@
 -gtk = { version = "0.6.6", package = "gtk4", features = ["v4_10"] }
 -lofty = "0.11.0"
 +gtk = { version = "0.7", package = "gtk4", features = ["v4_10"] }
-+lofty = "0.17.0"
++lofty = "0.18.0"
  log = "0.4"
  mpris-player = "0.6"
  once_cell = "1.10"
diff -Nru amberol-0.10.3/debian/patches/0003-Replace-mpris_player-with-mpris_server-and-fix-MPRIS.patch amberol-0.10.3/debian/patches/0003-Replace-mpris_player-with-mpris_server-and-fix-MPRIS.patch
--- amberol-0.10.3/debian/patches/0003-Replace-mpris_player-with-mpris_server-and-fix-MPRIS.patch	2024-01-06 12:12:15.0 +0100
+++ amberol-0.10.3/debian/patches/0003-Replace-mpris_player-with-mpris_server-and-fix-MPRIS.patch	2024-04-12 12:23:35.0 +0200
@@ -17,23 +17,23 @@
  src/audio/waveform_generator.rs |   2 +-
  7 files changed, 199 insertions(+), 144 deletions(-)
 
-diff --git a/Cargo.toml b/Cargo.toml
-index e15d84b..4eadcfb 100644
 a/Cargo.toml
-+++ b/Cargo.toml
-@@ -14,7 +14,7 @@ gettext-rs = { version = "0.7", features = ["gettext-system"] }
+Index: amberol-0.10.3/Cargo.toml
+===
+--- amberol-0.10.3.orig/Cargo.toml
 amberol-0.10.3/Cargo.toml
+@@ -14,7 +14,7 @@ gettext-rs = { version = "0.7", features
  gtk = { version = "0.7", package = "gtk4", features = ["v4_10"] }
- lofty = "0.17.0"
+ lofty = "0.18.0"
  log = "0.4"
 -mpris-player = "0.6"
-+mpris-server = "0.6"
++mpris-server = "0.7"
  once_cell = "1.10"
  pretty_env_logger = "0.5"
  rand = "0.8.5"
-diff --git a/src/audio/controller.rs b/src/audio/controller.rs
-index 62f89e7..e1484ae 100644
 a/src/audio/controller.rs
-+++ b/src/audio/controller.rs
+Index: amberol-0.10.3/src/audio/controller.rs
+===
+--- amberol-0.10.3.orig/src/audio/controller.rs
 amberol-0.10.3/src/audio/controller.rs
 @@ -7,6 +7,6 @@ pub trait Controller {
  fn set_playback_state(, state: );
  
@@ -42,10 +42,10 @@
 +fn set_position(, position: u64, notify: bool);
  fn set_repeat_mode(, repeat: RepeatMode);
  }
-diff --git a/src/audio/gst_backend.rs b/src/audio/gst_backend.rs
-index feb27c1..ff8c1c5 100644
 a/src/audio/gst_backend.rs
-+++ b/src/audio/gst_backend.rs
+Index: amberol-0.10.3/src/audio/gst_backend.rs
+===
+--- amberol-0.10.3.orig/src/audio/gst_backend.rs
 amberol-0.10.3/src/audio/gst_backend.rs
 @@ -21,6 +21,13 @@ pub struct GstReplayGain {
  rg_volume: gst::Element,
  }
@@ -82,10 +82,10 @@
  self.gst_player.connect_volume_changed(
  clone!(@strong self.sender as sender => move |player| {
  let volume = gst_audio::StreamVolume::convert_volume(
-diff --git a/src/audio/inhibit_controller.rs b/src/audio/inhibit_controller.rs
-index e532c74..01e36a0 100644
 a/src/audio/inhibit_controller.rs
-+++ b/src/audio/inhibit_controller.rs
+Index: amberol-0.10.3/src/audio/inhibit_controller.rs
+===
+--- amberol-0.10.3.orig/src/audio/inhibit_controller.rs
 

Bug#1064531: src:amberol: unsatisfied build dependency in testing: librust-lofty-0.17-dev

2024-02-23 Thread Paul Gevers

Source: amberol
Version: 0.10.3-2
Severity: serious
Tags: sid trixie
User: debian...@lists.debian.org
Usertags: edos-uninstallable

Dear maintainer(s),

Dose [1] is reporting a build issue with your package, it's missing a
build dependency. Obviously your build dependencies shouldn't be
removed from testing, but unfortunately there are multiple scenarios
where that can happen nevertheless. To uphold our social contract,
Debian requires that packages can be rebuild from source in the suite
we are shipping them, so currently this is a serious issue with your
package in testing.

Can you please investigate the situation and figure out how to resolve
it? Regularly, if the build dependency is available in unstable,
helping the maintainer of your Build-Depends to enable migration to
testing is a great way to solve the issue. If your build dependency is
gone from unstable and testing, you'll have to fix the build process
in some other way.

Paul

Note: this bug report was sent after some quick manual checks using a
template. Please reach out to me if you believe I made a mistake in my
process.

[1] https://qa.debian.org/dose/debcheck/src_testing_main/latest/amd64.html



OpenPGP_signature.asc
Description: OpenPGP digital signature