Source: lincity
Version: 1.13.1-15
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lu...@debian.org
Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

This is most likely caused by a change in dpkg 1.22.6, that enabled
-Werror=implicit-function-declaration. For more information, see
https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

Relevant part (hopefully):
> gcc -DHAVE_CONFIG_H -I.   -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 
> -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. 
> -fstack-protector-strong -fstack-clash-protection -Wformat 
> -Werror=format-security -fcf-protection  -Wall -c -o shrglobs.o shrglobs.c
> fileutil.c: In function ‘find_libdir’:
> fileutil.c:349:5: error: implicit declaration of function ‘HandleError’ 
> [-Werror=implicit-function-declaration]
>   349 |     HandleError (_("Error. Can't find LINCITY_HOME"), FATAL);
>       |     ^~~~~~~~~~~
> fileutil.c: In function ‘make_savedir’:
> fileutil.c:590:5: warning: ignoring return value of ‘chown’ declared with 
> attribute ‘warn_unused_result’ [-Wunused-result]
>   590 |     chown (lc_save_dir, getuid (), getgid ());
>       |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> gcc -DHAVE_CONFIG_H -I.   -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 
> -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. 
> -fstack-protector-strong -fstack-clash-protection -Wformat 
> -Werror=format-security -fcf-protection  -Wall -c -o stats.o stats.c
> fileutil.c: In function ‘find_libdir’:
> fileutil.c:324:13: warning: ‘__builtin_strncpy’ specified bound 256 equals 
> destination size [-Wstringop-truncation]
>   324 |             strncpy (LIBDIR, home_dir, LC_PATH_MAX);
>       |             ^
> fileutil.c:332:53: warning: ‘__builtin___snprintf_chk’ output may be 
> truncated before the last format character [-Wformat-truncation=]
>   332 |         snprintf (filename_buf, LC_PATH_MAX, "%s%c%s",
>       |                                                     ^
> In file included from /usr/include/stdio.h:906,
>                  from fileutil.c:7:
> In function ‘snprintf’,
>     inlined from ‘find_libdir’ at fileutil.c:332:2:
> /usr/include/x86_64-linux-gnu/bits/stdio2.h:54:10: note: 
> ‘__builtin___snprintf_chk’ output 2 or more bytes (assuming 257) into a 
> destination of size 256
>    54 |   return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,
>       |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    55 |                                    __glibc_objsize (__s), __fmt,
>       |                                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    56 |                                    __va_arg_pack ());
>       |                                    ~~~~~~~~~~~~~~~~~
> /bin/bash ./libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I.  
> -DLC_X11=1 -Wall -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 
> -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. 
> -fstack-protector-strong -fstack-clash-protection -Wformat 
> -Werror=format-security -fcf-protection  -Wall -c -o lcx-ldsvgui.lo `test -f 
> 'ldsvgui.c' || echo './'`ldsvgui.c
> /bin/bash ./libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I.  
> -DLC_X11=1 -Wall -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 
> -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. 
> -fstack-protector-strong -fstack-clash-protection -Wformat 
> -Werror=format-security -fcf-protection  -Wall -c -o lcx-splash.lo `test -f 
> 'splash.c' || echo './'`splash.c
> fileutil.c: In function ‘find_localized_paths’:
> fileutil.c:430:33: warning: ‘%s’ directive writing 8 bytes into a region of 
> size between 0 and 255 [-Wformat-overflow=]
>   430 |     sprintf (message_path, "%s%c%s%c%s%c", LIBDIR, PATH_SLASH, 
> "messages",
>       |                                 ^~                             
> ~~~~~~~~~~
> In function ‘sprintf’,
>     inlined from ‘find_localized_paths’ at fileutil.c:430:5:
> /usr/include/x86_64-linux-gnu/bits/stdio2.h:30:10: note: 
> ‘__builtin___sprintf_chk’ output 12 or more bytes (assuming 267) into a 
> destination of size 256
>    30 |   return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1,
>       |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    31 |                                   __glibc_objsize (__s), __fmt,
>       |                                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    32 |                                   __va_arg_pack ());
>       |                                   ~~~~~~~~~~~~~~~~~
> fileutil.c: In function ‘find_localized_paths’:
> fileutil.c:437:30: warning: ‘%s’ directive writing 4 bytes into a region of 
> size between 0 and 255 [-Wformat-overflow=]
>   437 |     sprintf (help_path, "%s%c%s%c%s%c", LIBDIR, PATH_SLASH, "help",
>       |                              ^~                             ~~~~~~
> In function ‘sprintf’,
>     inlined from ‘find_localized_paths’ at fileutil.c:437:5:
> /usr/include/x86_64-linux-gnu/bits/stdio2.h:30:10: note: 
> ‘__builtin___sprintf_chk’ output 8 or more bytes (assuming 263) into a 
> destination of size 256
>    30 |   return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1,
>       |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    31 |                                   __glibc_objsize (__s), __fmt,
>       |                                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    32 |                                   __va_arg_pack ());
>       |                                   ~~~~~~~~~~~~~~~~~
> fileutil.c: In function ‘find_localized_paths’:
> fileutil.c:455:35: warning: ‘%s’ directive writing 8 bytes into a region of 
> size between 0 and 255 [-Wformat-overflow=]
>   455 |       sprintf (message_path, "%s%c%s%c%s%c", LIBDIR, PATH_SLASH, 
> "messages",
>       |                                   ^~                             
> ~~~~~~~~~~
> In function ‘sprintf’,
>     inlined from ‘find_localized_paths’ at fileutil.c:455:7:
> /usr/include/x86_64-linux-gnu/bits/stdio2.h:30:10: note: 
> ‘__builtin___sprintf_chk’ output between 12 and 394 bytes into a destination 
> of size 256
>    30 |   return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1,
>       |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    31 |                                   __glibc_objsize (__s), __fmt,
>       |                                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    32 |                                   __va_arg_pack ());
>       |                                   ~~~~~~~~~~~~~~~~~
> fileutil.c: In function ‘find_localized_paths’:
> fileutil.c:464:32: warning: ‘%s’ directive writing 4 bytes into a region of 
> size between 0 and 255 [-Wformat-overflow=]
>   464 |       sprintf (help_path, "%s%c%s%c%s%c", LIBDIR, PATH_SLASH, "help",
>       |                                ^~                             ~~~~~~
> In function ‘sprintf’,
>     inlined from ‘find_localized_paths’ at fileutil.c:464:7:
> /usr/include/x86_64-linux-gnu/bits/stdio2.h:30:10: note: 
> ‘__builtin___sprintf_chk’ output between 8 and 390 bytes into a destination 
> of size 256
>    30 |   return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1,
>       |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    31 |                                   __glibc_objsize (__s), __fmt,
>       |                                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    32 |                                   __va_arg_pack ());
>       |                                   ~~~~~~~~~~~~~~~~~
> fileutil.c: In function ‘find_localized_paths’:
> fileutil.c:464:32: warning: ‘%s’ directive writing 4 bytes into a region of 
> size between 0 and 255 [-Wformat-overflow=]
>   464 |       sprintf (help_path, "%s%c%s%c%s%c", LIBDIR, PATH_SLASH, "help",
>       |                                ^~                             ~~~~~~
> In function ‘sprintf’,
>     inlined from ‘find_localized_paths’ at fileutil.c:464:7:
> /usr/include/x86_64-linux-gnu/bits/stdio2.h:30:10: note: 
> ‘__builtin___sprintf_chk’ output between 8 and 390 bytes into a destination 
> of size 256
>    30 |   return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1,
>       |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    31 |                                   __glibc_objsize (__s), __fmt,
>       |                                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    32 |                                   __va_arg_pack ());
>       |                                   ~~~~~~~~~~~~~~~~~
> fileutil.c: In function ‘find_localized_paths’:
> fileutil.c:477:33: warning: ‘%s’ directive writing 8 bytes into a region of 
> size between 0 and 255 [-Wformat-overflow=]
>   477 |     sprintf (message_path, "%s%c%s%c", LIBDIR, PATH_SLASH, "messages",
>       |                                 ^~                         ~~~~~~~~~~
> In function ‘sprintf’,
>     inlined from ‘find_localized_paths’ at fileutil.c:477:5:
> /usr/include/x86_64-linux-gnu/bits/stdio2.h:30:10: note: 
> ‘__builtin___sprintf_chk’ output between 11 and 266 bytes into a destination 
> of size 256
>    30 |   return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1,
>       |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    31 |                                   __glibc_objsize (__s), __fmt,
>       |                                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    32 |                                   __va_arg_pack ());
>       |                                   ~~~~~~~~~~~~~~~~~
> fileutil.c: In function ‘find_localized_paths’:
> fileutil.c:482:30: warning: ‘%s’ directive writing 4 bytes into a region of 
> size between 0 and 255 [-Wformat-overflow=]
>   482 |     sprintf (help_path, "%s%c%s%c", LIBDIR, PATH_SLASH, "help",
>       |                              ^~                         ~~~~~~
> In function ‘sprintf’,
>     inlined from ‘find_localized_paths’ at fileutil.c:482:5:
> /usr/include/x86_64-linux-gnu/bits/stdio2.h:30:10: note: 
> ‘__builtin___sprintf_chk’ output between 7 and 262 bytes into a destination 
> of size 256
>    30 |   return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1,
>       |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    31 |                                   __glibc_objsize (__s), __fmt,
>       |                                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    32 |                                   __va_arg_pack ());
>       |                                   ~~~~~~~~~~~~~~~~~
> libtool: compile:  gcc -DHAVE_CONFIG_H -I. -DLC_X11=1 -Wall -Wdate-time 
> -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration 
> -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong 
> -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection 
> -Wall -c ldsvgui.c  -fPIC -DPIC -o .libs/lcx-ldsvgui.o
> fileutil.c: In function ‘init_path_strings’:
> fileutil.c:511:36: warning: ‘%s’ directive writing 10 bytes into a region of 
> size between 0 and 255 [-Wformat-overflow=]
>   511 |     sprintf (colour_pal_file, "%s%c%s", LIBDIR, PATH_SLASH, 
> "colour.pal");
>       |                                    ^~                       
> ~~~~~~~~~~~~
> In function ‘sprintf’,
>     inlined from ‘init_path_strings’ at fileutil.c:511:5:
> /usr/include/x86_64-linux-gnu/bits/stdio2.h:30:10: note: 
> ‘__builtin___sprintf_chk’ output between 12 and 267 bytes into a destination 
> of size 256
>    30 |   return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1,
>       |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    31 |                                   __glibc_objsize (__s), __fmt,
>       |                                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    32 |                                   __va_arg_pack ());
>       |                                   ~~~~~~~~~~~~~~~~~
> fileutil.c: In function ‘init_path_strings’:
> fileutil.c:512:33: warning: ‘%s’ directive writing 7 bytes into a region of 
> size between 0 and 255 [-Wformat-overflow=]
>   512 |     sprintf (opening_path, "%s%c%s", LIBDIR, PATH_SLASH, "opening");
>       |                                 ^~                       ~~~~~~~~~
> In function ‘sprintf’,
>     inlined from ‘init_path_strings’ at fileutil.c:512:5:
> /usr/include/x86_64-linux-gnu/bits/stdio2.h:30:10: note: 
> ‘__builtin___sprintf_chk’ output between 9 and 264 bytes into a destination 
> of size 256
>    30 |   return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1,
>       |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    31 |                                   __glibc_objsize (__s), __fmt,
>       |                                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    32 |                                   __va_arg_pack ());
>       |                                   ~~~~~~~~~~~~~~~~~
> fileutil.c: In function ‘init_path_strings’:
> fileutil.c:516:32: warning: ‘%s’ directive writing 11 bytes into a region of 
> size between 0 and 255 [-Wformat-overflow=]
>   516 |     sprintf (opening_pic, 
> "%s%c%s",opening_path,PATH_SLASH,"open.tga.gz");
>       |                                ^~                          
> ~~~~~~~~~~~~~
> In function ‘sprintf’,
>     inlined from ‘init_path_strings’ at fileutil.c:516:5:
> /usr/include/x86_64-linux-gnu/bits/stdio2.h:30:10: note: 
> ‘__builtin___sprintf_chk’ output between 13 and 268 bytes into a destination 
> of size 256
>    30 |   return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1,
>       |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    31 |                                   __glibc_objsize (__s), __fmt,
>       |                                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    32 |                                   __va_arg_pack ());
>       |                                   ~~~~~~~~~~~~~~~~~
> fileutil.c: In function ‘init_path_strings’:
> fileutil.c:518:33: warning: ‘%s’ directive writing 5 bytes into a region of 
> size between 0 and 255 [-Wformat-overflow=]
>   518 |     sprintf (graphic_path, "%s%c%s%c", LIBDIR, PATH_SLASH, "icons",
>       |                                 ^~                         ~~~~~~~
> In function ‘sprintf’,
>     inlined from ‘init_path_strings’ at fileutil.c:518:5:
> /usr/include/x86_64-linux-gnu/bits/stdio2.h:30:10: note: 
> ‘__builtin___sprintf_chk’ output between 8 and 263 bytes into a destination 
> of size 256
>    30 |   return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1,
>       |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    31 |                                   __glibc_objsize (__s), __fmt,
>       |                                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    32 |                                   __va_arg_pack ());
>       |                                   ~~~~~~~~~~~~~~~~~
> fileutil.c: In function ‘init_path_strings’:
> fileutil.c:527:29: warning: ‘%s’ directive writing 17 bytes into a region of 
> size between 0 and 255 [-Wformat-overflow=]
>   527 |     sprintf (fontfile, "%s%c%s", opening_path, PATH_SLASH,
>       |                             ^~
>   528 |              "iso8859-1-8x8.raw");
>       |              ~~~~~~~~~~~~~~~~~~~
> In function ‘sprintf’,
>     inlined from ‘init_path_strings’ at fileutil.c:527:5:
> /usr/include/x86_64-linux-gnu/bits/stdio2.h:30:10: note: 
> ‘__builtin___sprintf_chk’ output between 19 and 274 bytes into a destination 
> of size 256
>    30 |   return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1,
>       |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    31 |                                   __glibc_objsize (__s), __fmt,
>       |                                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    32 |                                   __va_arg_pack ());
>       |                                   ~~~~~~~~~~~~~~~~~
> fileutil.c: In function ‘init_path_strings’:
> fileutil.c:553:44: warning: ‘%s’ directive writing 6 bytes into a region of 
> size between 0 and 255 [-Wformat-overflow=]
>   553 |     sprintf (lc_textdomain_directory, "%s%c%s", LIBDIR, PATH_SLASH, 
> "locale");
>       |                                            ^~                       
> ~~~~~~~~
> In function ‘sprintf’,
>     inlined from ‘init_path_strings’ at fileutil.c:553:5:
> /usr/include/x86_64-linux-gnu/bits/stdio2.h:30:10: note: 
> ‘__builtin___sprintf_chk’ output between 8 and 263 bytes into a destination 
> of size 256
>    30 |   return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1,
>       |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    31 |                                   __glibc_objsize (__s), __fmt,
>       |                                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    32 |                                   __va_arg_pack ());
>       |                                   ~~~~~~~~~~~~~~~~~
> /bin/bash ./libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I.  
> -DLC_X11=1 -Wall -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 
> -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. 
> -fstack-protector-strong -fstack-clash-protection -Wformat 
> -Werror=format-security -fcf-protection  -Wall -c -o lcx-lchelp.lo `test -f 
> 'lchelp.c' || echo './'`lchelp.c
> libtool: compile:  gcc -DHAVE_CONFIG_H -I. -DLC_X11=1 -Wall -Wdate-time 
> -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration 
> -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong 
> -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection 
> -Wall -c splash.c  -fPIC -DPIC -o .libs/lcx-splash.o
> cc1: some warnings being treated as errors
> make[3]: *** [Makefile:775: fileutil.o] Error 1


The full build log is available from:
http://qa-logs.debian.net/2024/03/13/lincity_1.13.1-15_unstable.log

All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lu...@debian.org
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240313&fusertaguser=lu...@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.

Reply via email to