Bug#1066310: dx: FTBFS: _compparse.c:51:17: error: implicit declaration of function ‘_dxfcclex’ [-Werror=implicit-function-declaration]

2024-04-13 Thread Bo YU
Hi,

On Sun, Apr 14, 2024 at 5:11 AM Graham Inggs  wrote:
>
> Hi Bo
>
> > I have attached one debdiff and it can be built with it. So could you
> > upload it with it?
>
> The attached patch just seems to be papering over the problem, so I
> would rather not.
I agree with that.

I should add some background on the original post:
https://trac.macports.org/ticket/61842. On this thread, the maintainer
prefers to fix it in a correct way as you said. But given upstream of
dx, maybe this is very thorny.

BR,
Bo
>
> Regards
> Graham



Bug#1066310: dx: FTBFS: _compparse.c:51:17: error: implicit declaration of function ‘_dxfcclex’ [-Werror=implicit-function-declaration]

2024-04-13 Thread Graham Inggs
Hi Bo

> I have attached one debdiff and it can be built with it. So could you
> upload it with it?

The attached patch just seems to be papering over the problem, so I
would rather not.

Regards
Graham



Bug#1066310: dx: FTBFS: _compparse.c:51:17: error: implicit declaration of function ‘_dxfcclex’ [-Werror=implicit-function-declaration]

2024-03-14 Thread Bo YU

On Wed, Mar 13, 2024 at 12:37:02PM +0100, Lucas Nussbaum wrote:
...

cc1: warning: command-line option ‘-std=c++11’ is valid for C++/ObjC++ but not 
for C
y.tab.c: In function ‘_dxfccparse’:
_compparse.c:51:17: error: implicit declaration of function ‘_dxfcclex’ 
[-Werror=implicit-function-declaration]
   51 | #define yylex   _dxfcclex
  | ^
y.tab.c:651:16: note: in expansion of macro ‘yylex’
y.tab.c:1107:16: note: in expansion of macro ‘YYLEX’
_compparse.c:52:17: error: implicit declaration of function ‘_dxfccerror’ 
[-Werror=implicit-function-declaration]
   52 | #define yyerror _dxfccerror
  | ^~~
y.tab.c:1682:2: note: in expansion of macro ‘yyerror’
./_compparse.y: In function ‘_dxfccerror’:
./_compparse.y:432:47: error: implicit declaration of function 
‘_dxfcclexerror’; did you mean ‘_dxfccerror’? 
[-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors
make[6]: *** [Makefile:961: _compparse.lo] Error 1


I have attached one debdiff and it can be built with it. So could you
upload it with it? I can team upload if nobody response with this sor
some days.

BTW, dx upstream has dead, so refer to:
https://trac.macports.org/ticket/61842


--
Regards,
--
  Bo YU

diff -Nru dx-4.4.4/debian/changelog dx-4.4.4/debian/changelog
--- dx-4.4.4/debian/changelog   2024-02-29 07:06:03.0 +0800
+++ dx-4.4.4/debian/changelog   2024-03-14 14:17:17.0 +0800
@@ -1,3 +1,11 @@
+dx (1:4.4.4-15.2) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Add -Wno-error=implicit-function-declaration into 
+DEB_CFLAGS_MAINT_APPEND. (Closes: #1066310)
+
+ -- Bo YU   Thu, 14 Mar 2024 14:17:17 +0800
+
 dx (1:4.4.4-15.1) unstable; urgency=medium
 
   * Non-maintainer upload.
diff -Nru dx-4.4.4/debian/rules dx-4.4.4/debian/rules
--- dx-4.4.4/debian/rules   2024-02-29 07:06:00.0 +0800
+++ dx-4.4.4/debian/rules   2024-03-14 14:17:05.0 +0800
@@ -4,6 +4,7 @@
 
 export DEB_BUILD_MAINT_OPTIONS=hardening=+all
 DEB_CFLAGS_MAINT_APPEND=-fsigned-char -fno-strict-aliasing -std=c++11
+DEB_CFLAGS_MAINT_APPEND=-Wno-error=implicit-function-declaration
 DEB_CXXFLAGS_MAINT_APPEND=-fsigned-char -fno-strict-aliasing -std=c++11
 DEB_HOST_ARCH ?= $(shell dpkg-architecture -qDEB_HOST_ARCH)
 ifeq ($(DEB_HOST_ARCH), alpha)


signature.asc
Description: PGP signature


Bug#1066310: dx: FTBFS: _compparse.c:51:17: error: implicit declaration of function ‘_dxfcclex’ [-Werror=implicit-function-declaration]

2024-03-13 Thread Lucas Nussbaum
Source: dx
Version: 1:4.4.4-15.1
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lu...@debian.org
Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

This is most likely caused by a change in dpkg 1.22.6, that enabled
-Werror=implicit-function-declaration. For more information, see
https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

Relevant part (hopefully):
> /bin/bash ../../../libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. 
> -I../../../include -I../../../include -I./../dpexec 
> -I/<>/include -Dlinux  -Wdate-time -D_FORTIFY_SOURCE=2   -g -O2 
> -Werror=implicit-function-declaration -ffile-prefix-map=/<>=. 
> -fstack-protector-strong -fstack-clash-protection -Wformat 
> -Werror=format-security -fcf-protection -fsigned-char -fno-strict-aliasing 
> -std=c++11 -D_GNU_SOURCE -I/usr/include/x86_64-linux-gnu/ImageMagick-6 
> -I/usr/include/ImageMagick-6 -fopenmp -DMAGICKCORE_HDRI_ENABLE=0 
> -DMAGICKCORE_QUANTUM_DEPTH=16  -c -o _compparse.lo _compparse.c
> libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../../../include 
> -I../../../include -I./../dpexec -I/<>/include -Dlinux 
> -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration 
> -ffile-prefix-map=/<>=. -fstack-protector-strong 
> -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection 
> -fsigned-char -fno-strict-aliasing -std=c++11 -D_GNU_SOURCE 
> -I/usr/include/x86_64-linux-gnu/ImageMagick-6 -I/usr/include/ImageMagick-6 
> -fopenmp -DMAGICKCORE_HDRI_ENABLE=0 -DMAGICKCORE_QUANTUM_DEPTH=16 -c 
> _compparse.c  -fPIC -DPIC -o .libs/_compparse.o
> cc1: warning: command-line option ‘-std=c++11’ is valid for C++/ObjC++ but 
> not for C
> y.tab.c: In function ‘_dxfccparse’:
> _compparse.c:51:17: error: implicit declaration of function ‘_dxfcclex’ 
> [-Werror=implicit-function-declaration]
>51 | #define yylex   _dxfcclex
>   | ^
> y.tab.c:651:16: note: in expansion of macro ‘yylex’
> y.tab.c:1107:16: note: in expansion of macro ‘YYLEX’
> _compparse.c:52:17: error: implicit declaration of function ‘_dxfccerror’ 
> [-Werror=implicit-function-declaration]
>52 | #define yyerror _dxfccerror
>   | ^~~
> y.tab.c:1682:2: note: in expansion of macro ‘yyerror’
> ./_compparse.y: In function ‘_dxfccerror’:
> ./_compparse.y:432:47: error: implicit declaration of function 
> ‘_dxfcclexerror’; did you mean ‘_dxfccerror’? 
> [-Werror=implicit-function-declaration]
> cc1: some warnings being treated as errors
> make[6]: *** [Makefile:961: _compparse.lo] Error 1


The full build log is available from:
http://qa-logs.debian.net/2024/03/13/dx_4.4.4-15.1_unstable.log

All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lu...@debian.org
or:
https://udd.debian.org/bugs/?release=na=ign=7=7=only=ftbfs-20240313=lu...@debian.org=1=1=1=1#results

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.