Bug#1066383: virtualjaguar: FTBFS: ./inlines.h:82:20: error: implicit declaration of function ‘m68k_read_memory_32’ [-Werror=implicit-function-declaration]
Control: tags -1 +patch
Hi,
On Wed, 2024-03-13 at 12:46 +0100, Lucas Nussbaum wrote:
> Relevant part (hopefully):
> > gcc -MMD -g -O2 -Werror=implicit-function-declaration
> > -ffile-prefix-map=/<>=. -fstack-protector-strong
> > -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection
> > -I. -I./obj `sdl-config --cflags` -c obj/cpustbl.c -o obj/cpustbl.o
> > In file included from obj/cpustbl.c:3:
> > ./inlines.h: In function ‘m68k_do_rts’:
> > ./inlines.h:82:20: error: implicit declaration of function
> > ‘m68k_read_memory_32’ [-Werror=implicit-function-declaration]
> >82 | m68k_setpc(m68k_read_memory_32(m68k_areg(regs, 7)));
> > |^~~
> > ./inlines.h: In function ‘m68k_do_bsr’:
> > ./inlines.h:89:9: error: implicit declaration of function
> > ‘m68k_write_memory_32’ [-Werror=implicit-function-declaration]
> >89 | m68k_write_memory_32(m68k_areg(regs, 7), oldpc);
> > | ^~~~
> > ./inlines.h: In function ‘get_ibyte_prefetch’:
> > ./inlines.h:111:25: error: implicit declaration of function
> > ‘m68k_read_memory_8’ [-Werror=implicit-function-declaration]
> > 111 | #define get_ibyte(o)m68k_read_memory_8(regs.pc + (o) + 1)
> > | ^~
> > ./inlines.h:158:16: note: in expansion of macro ‘get_ibyte’
> > 158 | return get_ibyte(o);
> > |^
> > ./inlines.h: In function ‘get_iword_prefetch’:
> > ./inlines.h:112:25: error: implicit declaration of function
> > ‘m68k_read_memory_16’ [-Werror=implicit-function-declaration]
> > 112 | #define get_iword(o)m68k_read_memory_16(regs.pc + (o))
> > | ^~~
> > ./inlines.h:183:16: note: in expansion of macro ‘get_iword’
> > 183 | return get_iword(o);
> > |^
> > cc1: some warnings being treated as errors
> > make[2]: *** [Makefile:58: obj/cpustbl.o] Error 1
Thanks for the bug report! The attached patch fixes the problem for me. I'm
going to upload
an updated packages soon which will also include fixes for #1038585 [1].
Adrian
> [1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1038585
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer
`. `' Physicist
`-GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
From d0c699e0c6a0781a6dd2f89492b38f9a1d50fa9c Mon Sep 17 00:00:00 2001
From: John Paul Adrian Glaubitz
Date: Sat, 13 Apr 2024 11:18:38 +0200
Subject: [PATCH] Fix missing inclusion of m68kinterface.h in
src/m68000/inlines.h
---
src/m68000/inlines.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/m68000/inlines.h b/src/m68000/inlines.h
index 54de932..c037bd9 100644
--- a/src/m68000/inlines.h
+++ b/src/m68000/inlines.h
@@ -11,6 +11,7 @@
#define __INLINES_H__
#include "cpudefs.h"
+#include "m68kinterface.h"
STATIC_INLINE int cctrue(const int cc)
{
--
2.44.0
Bug#1066383: virtualjaguar: FTBFS: ./inlines.h:82:20: error: implicit declaration of function ‘m68k_read_memory_32’ [-Werror=implicit-function-declaration]
Source: virtualjaguar Version: 2.1.3-2 Severity: serious Justification: FTBFS Tags: trixie sid ftbfs User: lu...@debian.org Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef Hi, During a rebuild of all packages in sid, your package failed to build on amd64. This is most likely caused by a change in dpkg 1.22.6, that enabled -Werror=implicit-function-declaration. For more information, see https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration Relevant part (hopefully): > gcc -MMD -g -O2 -Werror=implicit-function-declaration > -ffile-prefix-map=/<>=. -fstack-protector-strong > -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -I. > -I./obj `sdl-config --cflags` -c obj/cpustbl.c -o obj/cpustbl.o > In file included from obj/cpustbl.c:3: > ./inlines.h: In function ‘m68k_do_rts’: > ./inlines.h:82:20: error: implicit declaration of function > ‘m68k_read_memory_32’ [-Werror=implicit-function-declaration] >82 | m68k_setpc(m68k_read_memory_32(m68k_areg(regs, 7))); > |^~~ > ./inlines.h: In function ‘m68k_do_bsr’: > ./inlines.h:89:9: error: implicit declaration of function > ‘m68k_write_memory_32’ [-Werror=implicit-function-declaration] >89 | m68k_write_memory_32(m68k_areg(regs, 7), oldpc); > | ^~~~ > ./inlines.h: In function ‘get_ibyte_prefetch’: > ./inlines.h:111:25: error: implicit declaration of function > ‘m68k_read_memory_8’ [-Werror=implicit-function-declaration] > 111 | #define get_ibyte(o)m68k_read_memory_8(regs.pc + (o) + 1) > | ^~ > ./inlines.h:158:16: note: in expansion of macro ‘get_ibyte’ > 158 | return get_ibyte(o); > |^ > ./inlines.h: In function ‘get_iword_prefetch’: > ./inlines.h:112:25: error: implicit declaration of function > ‘m68k_read_memory_16’ [-Werror=implicit-function-declaration] > 112 | #define get_iword(o)m68k_read_memory_16(regs.pc + (o)) > | ^~~ > ./inlines.h:183:16: note: in expansion of macro ‘get_iword’ > 183 | return get_iword(o); > |^ > cc1: some warnings being treated as errors > make[2]: *** [Makefile:58: obj/cpustbl.o] Error 1 The full build log is available from: http://qa-logs.debian.net/2024/03/13/virtualjaguar_2.1.3-2_unstable.log All bugs filed during this archive rebuild are listed at: https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lu...@debian.org or: https://udd.debian.org/bugs/?release=na=ign=7=7=only=ftbfs-20240313=lu...@debian.org=1=1=1=1#results A list of current common problems and possible solutions is available at http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute! If you reassign this bug to another package, please mark it as 'affects'-ing this package. See https://www.debian.org/Bugs/server-control#affects If you fail to reproduce this, please provide a build log and diff it with mine so that we can identify if something relevant changed in the meantime.
