Bug#1066658: sup: FTBFS: scm.c:316:9: error: implicit declaration of function ‘setproctitle’ [-Werror=implicit-function-declaration]
Tags: patch
Hi,
,On Wed, Mar 13, 2024 at 12:57:21PM +0100, Lucas Nussbaum wrote:
scm.c: In function ‘service’:
scm.c:316:9: error: implicit declaration of function ‘setproctitle’
[-Werror=implicit-function-declaration]
316 | setproctitle("Serving %s", remotehost());
| ^~~~
scm.c: In function ‘request’:
scm.c:448:16: warning: ignoring return value of ‘write’ declared with attribute
‘warn_unused_result’ [-Wunused-result]
448 | (void) write(netfile, , sizeof(int));
|^~~
scmio.c: In function ‘readfile’:
I have uploaded it to mentor to wait for sponsoring[0]. But there is one
debdiff if you can review it.
[0]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1068814
Thanks.
--
Regards,
--
Bo YU
diff -Nru sup-20100519/debian/changelog sup-20100519/debian/changelog
--- sup-20100519/debian/changelog 2020-08-05 19:53:16.0 +0800
+++ sup-20100519/debian/changelog 2024-04-11 16:41:22.0 +0800
@@ -1,3 +1,12 @@
+sup (20100519-4) unstable; urgency=medium
+
+ * QA upload.
+ * set std-ver to 4.7.0.
+ * Add 07_fix-implicit-function-declaration.patch to fix ftbfs issue.
+(Closes: #1066658)
+
+ -- Bo YU Thu, 11 Apr 2024 16:41:22 +0800
+
sup (20100519-3) unstable; urgency=medium
* QA upload.
diff -Nru sup-20100519/debian/control sup-20100519/debian/control
--- sup-20100519/debian/control 2020-08-05 19:48:03.0 +0800
+++ sup-20100519/debian/control 2024-04-11 16:03:18.0 +0800
@@ -3,7 +3,7 @@
Priority: optional
Build-Depends: debhelper-compat (= 13), libwrap0-dev
Maintainer: Debian QA Group
-Standards-Version: 4.5.0
+Standards-Version: 4.7.0
Package: sup
Architecture: any
diff -Nru
sup-20100519/debian/patches/07_fix-implicit-function-declaration.patch
sup-20100519/debian/patches/07_fix-implicit-function-declaration.patch
--- sup-20100519/debian/patches/07_fix-implicit-function-declaration.patch
1970-01-01 07:30:00.0 +0730
+++ sup-20100519/debian/patches/07_fix-implicit-function-declaration.patch
2024-04-11 15:59:50.0 +0800
@@ -0,0 +1,17 @@
+Description: fix implicit-function-declaration issue
+Author: Bo YU
+Bug: https://bugs.debian.org/1066658
+Last-Update: 2024-04-11
+---
+This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
+--- a/scm.c
b/scm.c
+@@ -195,6 +195,8 @@
+ #define INADDR_LOOPBACK (u_long)0x7f01 /* 127.0.0.1 */
+ #endif
+
++void setproctitle(const char *fmt, ...);
++
+ char scmversion[] = "4.3 BSD";
+ extern int silent;
+
diff -Nru sup-20100519/debian/patches/series sup-20100519/debian/patches/series
--- sup-20100519/debian/patches/series 2020-08-05 19:43:02.0 +0800
+++ sup-20100519/debian/patches/series 2024-04-11 15:01:34.0 +0800
@@ -4,3 +4,4 @@
04_fix_man.patch
05_unconst.patch
06_fix_ftbfs.patch
+07_fix-implicit-function-declaration.patch
signature.asc
Description: PGP signature
Bug#1066658: sup: FTBFS: scm.c:316:9: error: implicit declaration of function ‘setproctitle’ [-Werror=implicit-function-declaration]
Source: sup
Version: 20100519-3
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lu...@debian.org
Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef
Hi,
During a rebuild of all packages in sid, your package failed to build
on amd64.
This is most likely caused by a change in dpkg 1.22.6, that enabled
-Werror=implicit-function-declaration. For more information, see
https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration
Relevant part (hopefully):
> cc -UCMUCS -UCMU -UMACH -DVAR_TMP -DHAS_DAEMON -DHAS_POSIX_DIR
> -DNEED_SETPROCTITLE -DLIBWRAP -I. -g -O2
> -Werror=implicit-function-declaration -ffile-prefix-map=/<>=.
> -fstack-protector-strong -fstack-clash-protection -Wformat
> -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 -c
> -o stree.o stree.c
> scm.c: In function ‘service’:
> scm.c:316:9: error: implicit declaration of function ‘setproctitle’
> [-Werror=implicit-function-declaration]
> 316 | setproctitle("Serving %s", remotehost());
> | ^~~~
> scm.c: In function ‘request’:
> scm.c:448:16: warning: ignoring return value of ‘write’ declared with
> attribute ‘warn_unused_result’ [-Wunused-result]
> 448 | (void) write(netfile, , sizeof(int));
> |^~~
> scmio.c: In function ‘readfile’:
> scmio.c:670:32: warning: ignoring return value of ‘write’ declared with
> attribute ‘warn_unused_result’ [-Wunused-result]
> 670 | (void) write(f, buf, (size_t)XFERSIZE(count));
> |^~
> scmio.c: In function ‘crosspatch’:
> scmio.c:743:40: warning: ignoring return value of ‘write’ declared with
> attribute ‘warn_unused_result’ [-Wunused-result]
> 743 | (void) write(1, buf, (size_t)c);
> |^~~~
> scmio.c:753:40: warning: ignoring return value of ‘write’ declared with
> attribute ‘warn_unused_result’ [-Wunused-result]
> 753 | (void) write(netfile, buf, (size_t)c);
> |^~
> supcmeat.c: In function ‘setup’:
> supcmeat.c:321:24: warning: ignoring return value of ‘chdir’ declared with
> attribute ‘warn_unused_result’ [-Wunused-result]
> 321 | (void) chdir(thisC->Cbase);
> |^~~
> supcmeat.c: In function ‘listfiles’:
> supcmeat.c:522:24: warning: ignoring return value of ‘chdir’ declared with
> attribute ‘warn_unused_result’ [-Wunused-result]
> 522 | (void) chdir(thisC->Cprefix);
> |^
> supcmeat.c: In function ‘recvdir’:
> supcmeat.c:889:24: warning: ignoring return value of ‘chown’ declared with
> attribute ‘warn_unused_result’ [-Wunused-result]
> 889 | (void) chown(t->Tname, t->Tuid, t->Tgid);
> |^
> supcmeat.c: In function ‘recvreg’:
> supcmeat.c:968:32: warning: ignoring return value of ‘chown’ declared with
> attribute ‘warn_unused_result’ [-Wunused-result]
> 968 | (void) chown(t->Tname, t->Tuid, t->Tgid);
> |^
> supcmeat.c:1030:24: warning: ignoring return value of ‘chown’ declared with
> attribute ‘warn_unused_result’ [-Wunused-result]
> 1030 | (void) chown(t->Tname, t->Tuid, t->Tgid);
> |^
> supcmeat.c: In function ‘copyfile’:
> supcmeat.c:1152:32: warning: ignoring return value of ‘chdir’ declared with
> attribute ‘warn_unused_result’ [-Wunused-result]
> 1152 | (void) chdir(thisC->Cbase);
> |^~~
> supcmeat.c:1157:40: warning: ignoring return value of ‘chdir’ declared with
> attribute ‘warn_unused_result’ [-Wunused-result]
> 1157 | (void) chdir(thisC->Cprefix);
> |^
> supcmeat.c:1164:32: warning: ignoring return value of ‘chdir’ declared with
> attribute ‘warn_unused_result’ [-Wunused-result]
> 1164 | (void) chdir(thisC->Cprefix);
> |^
> supcmeat.c: In function ‘finishup’:
> supcmeat.c:1397:24: warning: ignoring return value of ‘chdir’ declared with
> attribute ‘warn_unused_result’ [-Wunused-result]
> 1397 | (void) chdir(thisC->Cbase);
> |^~~
> supcmain.c: In function ‘init’:
> supcmain.c:734:47: warning: ‘%s’ directive writing up to 1999 bytes into a
> region of size 1995 [-Wformat-overflow=]
> 734 | (void)
