Bug#1067542: setcd: please consider upgrading to 3.0 source format

2024-06-01 Thread Bastian Germann

I am uploading a NMU to DELAYED/10 in order to fix this.
Please find the debdiff attached.diff -Nru setcd-1.5/debian/changelog setcd-1.5/debian/changelog
--- setcd-1.5/debian/changelog  2024-06-01 13:00:32.0 +
+++ setcd-1.5/debian/changelog  2024-06-01 12:56:28.0 +
@@ -1,3 +1,10 @@
+setcd (1.5-6.2) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Convert to source format 3.0. (closes: #1067542)
+
+ -- Bastian Germann   Sat, 01 Jun 2024 12:56:28 +
+
 setcd (1.5-6.1) unstable; urgency=medium
 
   * Non-maintainer upload.
diff -Nru setcd-1.5/debian/patches/debian.patch 
setcd-1.5/debian/patches/debian.patch
--- setcd-1.5/debian/patches/debian.patch   1970-01-01 00:00:00.0 
+
+++ setcd-1.5/debian/patches/debian.patch   2024-06-01 12:56:28.0 
+
@@ -0,0 +1,128 @@
+--- setcd-1.5.orig/setcd.1
 setcd-1.5/setcd.1
+@@ -22,7 +22,8 @@ is a program that allows you to control
+ cdrom device.  There are a number of ways you can control the
+ behaviour of your cdrom drive: should it try to close the tray upon
+ mounting a cdrom when your happened to have left the tray open, or
+-should it eject the tray upon unmounting the cdrom? Should it lock the
++should it eject the tray (or caddy)
++upon unmounting the cdrom? Should it lock the
+ door when some process uses the cdrom or not? Should the kernel try to
+ ensure that there actually is a cd in the drive, and that it is of the
+ right type (i.e., a data cd in case of a mount, or an audio cd in case
+@@ -171,13 +172,11 @@ times real-time audio playback. The spec
+ .I 0
+ is interpreted as auto-selection: data cd's are read at maximum
+ head-rate, while audio cd's are played at normal speed.  There are a
+-few reasons for having the speed to be selectable. Badly pressed
+-cdroms may benefit from less-than-maximum head rate. Modern cdrom
+-drives can obtain very high head rates (up to 16 times audio speed is
+-common), but these drives tend to make an annoyingly loud noise. A
+-lower speed may reduce this. Finally, although the audio low-pass
+-filters probably aren't designed for it, more than real-time playback
+-of audio might be used for high-speed copying of audio tracks.
++few reasons for having the speed to be selectable.  Badly pressed
++cdroms may benefit from less-than-maximum head rate.  Modern cdrom
++drives can obtain very high head rates, 
++but these drives tend to make an annoyingly loud noise. A
++lower speed may reduce this. 
+ 
+ .SH HISTORY
+ Traditionally, up to the 2.0 Linux kernel line, the behaviour of the
+@@ -197,13 +196,13 @@ the behaviour of Linux cdrom drives is t
+ The new cdrom interface level was actually inspired after writing a
+ volume daemon that automatically mounts a cdrom at the location 
+ .RI /cdrom/ volume
+-upon insertion of the disc. I then found out that there was a need for
++upon insertion of the disc.  I then found out that there was a need for
+ finding out the status of the drive without trying to read data, and
+ that the uniformity of cdrom drivers was a mess. The volume daemon has
+ not been finished yet, but progress has been made in convincing the
+ Linux cdrom driver community to comply to the proposed standard. 
+ 
+-.SH DIGNOSTICS
++.SH DIAGNOSTICS
+ Setting or clearing an option will result in a message indicating the
+ new status of that option. Operations not supported by the underlying
+ hardware, e.g., disc selection, will result in an error
+@@ -261,7 +260,7 @@ Write texinfo documentation.
+ 
+ .SH AUTHOR
+ .B Setcd
+-is written by David A. van Leeuwen , the author of
++is written by David A. van Leeuwen , the author of
+ the earlier mentioned new cdrom interface and the cm206 cdrom driver.
+ 
+ .SH "SEE ALSO"
+--- setcd-1.5.orig/setcd.c
 setcd-1.5/setcd.c
+@@ -1,5 +1,6 @@
+ /* Setcd.c: Set various flags to control the behaviour of your cdrom device.
+(c) 1997 David A. van Leeuwen
++   (c) 2004 Thomas Fritzsche 
+ 
+$Id: setcd.c,v 1.4 1999/08/24 19:07:34 david Exp $
+ 
+@@ -23,8 +24,9 @@
+ #include 
+ #include /* tolower */
+ #include/* lseek, read */
+-#include/* strncmp */
++#include/* strncmp, memset */
+ #include /* ioctl */
++#include/* INT_MAX */
+ #include 
+ #ifndef CDC_CLOSE_TRAY/* moved into cdrom.h... */
+ #include 
+@@ -248,7 +250,50 @@ int main(int ac, char ** av)
+ if (set || clear || status)
+  print_options(flags, set | clear | ~0 * status);
+ if (speed>=0) {
+- if (ioctl(fd, CDROM_SELECT_SPEED, speed)<0) {
++ // patch to use SET STREAMING command
++ struct cdrom_generic_command cgc;
++ struct request_sense sense;
++ unsigned char buffer[28];
++ unsigned long rw_size;
++ memset(&cgc, 0, sizeof(cgc));
++ memset(&sense, 0, sizeof(sense));
++ memset(&buffer, 0, sizeof(buffer));
++   

Bug#1067542: setcd: please consider upgrading to 3.0 source format

2024-03-23 Thread Bastian Germann

Source: setcd
Version: 1.5-6
Severity: wishlist

This package is among the few that still use source format 1.0.
Please upgrade it to source format 3.0, as (1) this format has many
advantages, as documented in https://wiki.debian.org/Projects/DebSrc3.0 ; (2)
this contributes to standardization of packaging practices.