Bug#1072438: notcurses: FTBFS with ffmpeg 7.0: ffmpeg.c:523:46: error: ‘struct AVFrame’ has no member named ‘pkt_duration’; did you mean ‘duration’?

2024-06-02 Thread nick black
confirmed. this is a known issue with a fix present on the
notcurses main. i need to cut a new release ASAP including that
fix. until then, i can patch the debian package. there's
actually a fedora patch for the same problem:

 
https://src.fedoraproject.org/rpms/notcurses/c/70d807ff48579d92e580c7eb8c7e9cad4c26d79b?branch=rawhide

i'll try to get a debian patch up today or tomorrow. thanks for
the report!



Bug#1072438: notcurses: FTBFS with ffmpeg 7.0: ffmpeg.c:523:46: error: ‘struct AVFrame’ has no member named ‘pkt_duration’; did you mean ‘duration’?

2024-06-02 Thread Sebastian Ramacher
Source: notcurses
Version: 3.0.7+dfsg.1-1
Severity: important
Tags: trixie sid ftbfs
Usertags: ffmpeg-7.0

Hi,

during a rebuild of the reverse dependencies for the transition to
ffmpeg 7.0, your package failed to build


Relevant part (hopefully):
> /usr/bin/cc -D_DEFAULT_SOURCE -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE 
> -D_XOPEN_SOURCE=700 -I/<>/include -I/<>/src 
> -I/<> -I/<>/obj-aarch64-linux-gnu/include -g -O2 
> -Werror=implicit-function-declaration -ffile-prefix-map=/<>=. 
> -fstack-protector-strong -fstack-clash-protection -Wformat 
> -Werror=format-security -mbranch-protection=standard 
> -ffile-prefix-map=/<>=. -Wdate-time -D_FORTIFY_SOURCE=2 
> -std=gnu11 -fvisibility=hidden -Wformat -Werror=format-security -Wall -Wextra 
> -W -Wshadow -Wvla -fno-signed-zeros -fno-trapping-math -fassociative-math 
> -fno-math-errno -freciprocal-math -funsafe-math-optimizations -fexceptions 
> -fstrict-aliasing -fPIE -MD -MT 
> CMakeFiles/notcurses-static.dir/src/media/ffmpeg.c.o -MF 
> CMakeFiles/notcurses-static.dir/src/media/ffmpeg.c.o.d -o 
> CMakeFiles/notcurses-static.dir/src/media/ffmpeg.c.o -c 
> /<>/src/media/ffmpeg.c
> /<>/src/media/ffmpeg.c: In function ‘ffmpeg_stream’:
> /<>/src/media/ffmpeg.c:523:46: error: ‘struct AVFrame’ has no 
> member named ‘pkt_duration’; did you mean ‘duration’?
>   523 | uint64_t duration = ncv->details->frame->pkt_duration * tbase * 
> NANOSECS_IN_SEC;
>   |  ^~~~
>   |  duration
> /<>/src/media/ffmpeg.c: In function ‘ffmpeg_details_destroy’:
> /<>/src/media/ffmpeg.c:709:3: warning: ‘avcodec_close’ is 
> deprecated [-Wdeprecated-declarations]
>   709 |   avcodec_close(deets->codecctx);
>   |   ^
> In file included from /<>/src/media/ffmpeg.c:8:
> /usr/include/aarch64-linux-gnu/libavcodec/avcodec.h:2387:5: note: declared 
> here
>  2387 | int avcodec_close(AVCodecContext *avctx);
>   | ^
> make[4]: *** [CMakeFiles/notcurses.dir/build.make:79: 
> CMakeFiles/notcurses.dir/src/media/ffmpeg.c.o] Error 1


The full build log is available from:
https://people.debian.org/~sramacher/ffmpeg-7.0/notcurses_arm64.build

ffmpeg 7.0 is available in experimental.

Cheers

-- 
Sebastian Ramacher