Bug#1073927: autopkgtest: --shell and --shell-fail are broken

2024-06-21 Thread Paul Gevers

Hi,

On 21-06-2024 11:21 a.m., Paride Legovini wrote:

qemu doesn't try to directly open a shell, it gives the following output
and those methods normally work for me:


Right, I probably experienced this with qemu when I was working on my 
commands-via-ssh implementation and thought it was due to that.


Paul


OpenPGP_signature.asc
Description: OpenPGP digital signature


Bug#1073927: autopkgtest: --shell and --shell-fail are broken

2024-06-21 Thread Paride Legovini
On 2024-06-20 21:49, Paul Gevers wrote:
> Hi
> 
> On 20-06-2024 1:34 p.m., Paride Legovini wrote:
>> I can confirm this behavior, which I encountered when fixing LxcRunner
>> tests, however I only hit it when the lxc virt server. I did not use
>> a-virt-lxc that much until recently, so I can't tell when it stopped
>> working.
> 
> So you're saying it doesn't happen with qemu? I recall I had it there
> too, but I might be misremembering.

qemu doesn't try to directly open a shell, it gives the following output
and those methods normally work for me:

[...]
autopkgtest [10:35:51]:  - - - - - - - - - - running shell - - - - - - - - - -
You can now log into the VM through the serial terminal.
Depending on which terminal program you have installed, you can use one of

ssh -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no -p 10022 
user@localhost
minicom -D unix#/tmp/autopkgtest-qemu._eh9zmf4/ttyS0
nc -U /tmp/autopkgtest-qemu._eh9zmf4/ttyS0
socat - UNIX-CONNECT:/tmp/autopkgtest-qemu._eh9zmf4/ttyS0

The tested source package is in /tmp/autopkgtest.yg4J9u/build.ZDI/real-tree

Press Enter to resume running tests.



Bug#1073927: autopkgtest: --shell and --shell-fail are broken

2024-06-20 Thread Paul Gevers

Hi

On 20-06-2024 1:34 p.m., Paride Legovini wrote:

I can confirm this behavior, which I encountered when fixing LxcRunner
tests, however I only hit it when the lxc virt server. I did not use
a-virt-lxc that much until recently, so I can't tell when it stopped
working.


So you're saying it doesn't happen with qemu? I recall I had it there 
too, but I might be misremembering.


Paul


OpenPGP_signature.asc
Description: OpenPGP digital signature


Bug#1073927: autopkgtest: --shell and --shell-fail are broken

2024-06-20 Thread Paride Legovini
On 2024-06-20 13:12, Paul Gevers wrote:
> Package: autopkgtest
> Version: 5.35
> Severity: normal
> 
> Some time ago, I already experienced on my own laptop that --shell and
> --shell-fail didn't work anymore like they used to, but I feared I
> messed to much while developing autopkgtest. However, today I ran
> autopkgtest on one of the ci.d.n hosts to provide a testbed for
> debugging to someone, but the shell I got with --shell-fail didn't work.
> The shell gives a prompt, but doesn't do anything with the input. I
> stopped the shell in the end with Ctrl-C. 

I can confirm this behavior, which I encountered when fixing LxcRunner
tests, however I only hit it when the lxc virt server. I did not use
a-virt-lxc that much until recently, so I can't tell when it stopped
working.

I worked around the issue by manually running `lxc-attach containername`
to jump into the container.

--
Paride



Bug#1073927: autopkgtest: --shell and --shell-fail are broken

2024-06-20 Thread Paul Gevers

Package: autopkgtest
Version: 5.35
Severity: normal

Hi,

Some time ago, I already experienced on my own laptop that --shell and 
--shell-fail didn't work anymore like they used to, but I feared I 
messed to much while developing autopkgtest. However, today I ran 
autopkgtest on one of the ci.d.n hosts to provide a testbed for 
debugging to someone, but the shell I got with --shell-fail didn't work. 
The shell gives a prompt, but doesn't do anything with the input. I 
stopped the shell in the end with Ctrl-C. I could reproduce with 
src:hello and debugging info on my system too, see the attached log.


Paul

autopkgtest [09:54:00]: test unit-tests-server:  - - - - - - - - - - 
results - - - - - - - - - -

unit-tests-serverFAIL non-zero exit status 1
autopkgtest [09:54:00]:  - - - - - - - - - - running shell - - - - - - - 
- - -
root@elbrus:/tmp/autopkgtest-lxc.iolc4ahc/downtmp/build.tDD/src# apt 
install tmate





^CTraceback (most recent call last):
  File "/usr/bin/autopkgtest", line 911, in 
main()
  File "/usr/bin/autopkgtest", line 899, in main
process_actions()
  File "/usr/bin/autopkgtest", line 854, in process_actions
run_tests(tests, tests_tree)
  File "/usr/bin/autopkgtest", line 199, in run_tests
testbed.run_test(tree, t, opts.env, opts.shell_fail, opts.shell,
  File "/usr/share/autopkgtest/lib/adt_testbed.py", line 1406, in run_test
self.run_shell(tree.tb, ['AUTOPKGTEST_ARTIFACTS="%s"' % test_artifacts,
  File "/usr/share/autopkgtest/lib/adt_testbed.py", line 1145, in run_shell
self.command('shell', [cwd or '/'] + extra_env)
  File "/usr/share/autopkgtest/lib/adt_testbed.py", line 705, in command
ll = self.expect('ok', nresults)
 ^^^
  File "/usr/share/autopkgtest/lib/adt_testbed.py", line 668, in expect
line = self.sp.stdout.readline()
   ^
KeyboardInterrupt



-- System Information:
Debian Release: trixie/sid
  APT prefers testing
  APT policy: (990, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 6.7.12-amd64 (SMP w/4 CPU threads; PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_US:en

Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages autopkgtest depends on:
ii  apt-utils   2.9.5
ii  libdpkg-perl1.22.6
ii  mawk1.3.4.20240123-1
ii  procps  2:4.0.4-4
ii  python3 3.11.8-1
ii  python3-debian  0.1.49

Versions of packages autopkgtest recommends:
ii  autodep8  0.28
ii  fakeroot  1.33-1

Versions of packages autopkgtest suggests:
ii  docker.io20.10.25+dfsg1-3
pn  fakemachine  
ii  genisoimage  9:1.1.11-3.5
pn  incus
ii  lxc  1:6.0.0a-1
pn  lxd  
ii  ovmf 2024.05-1
pn  ovmf-ia32
ii  podman   4.9.4+ds1-1
ii  python3-distro-info  1.7
pn  qemu-efi-aarch64 
pn  qemu-efi-arm 
pn  qemu-efi-riscv64 
pn  qemu-system  
ii  qemu-utils   1:8.2.4+ds-1
ii  schroot  1.6.13-3+b3
ii  util-linux   2.40.1-8.1
ii  vmdb20.40-1
ii  zerofree 1.1.1-1+b1

-- no debconf information
paul@mulciber ~ $ autopkgtest -ddd hello --test-name=upstream-tests --shell -- lxc -ddd --sudo autopkgtest-unstable-amd64
autopkgtest: DBG: autopkgtest options: Namespace(override_control=None, only_tests=['upstream-tests'], skip_tests=None, built_binaries=True, packages=['hello'], output_dir=None, logfile=None, summary=None, verbosity=2, setup_commands=[], setup_commands_boot=[], add_apt_sources=[], add_apt_releases=[], pin_packages=[], apt_pocket=[], apt_default_release=None, enable_apt_fallback=True, copy=[], env=[], ignore_restrictions=[], user=None, gainroot=None, shell_fail=False, shell=True, timeout=0, timeout_short=None, timeout_copy=None, timeout_install=None, timeout_test=None, timeout_build=None, timeout_factor=1.0, set_lang=None, auto_control=True, build_parallel=None, needs_internet='run', validate=False)
autopkgtest: DBG: virt-runner arguments: ['lxc', '-ddd', '--sudo', 'autopkgtest-unstable-amd64']
autopkgtest: DBG: actions: [('apt-source', 'hello', False)]
autopkgtest: DBG: build binaries: True
autopkgtest: DBG: testbed init
autopkgtest [13:01:12]: starting date and time: 2024-06-20 13:01:12+0200
autopkgtest [13:01:12]: version 5.35
autopkgtest [13:01:12]: host mulciber; command line: /usr/bin/autopkgtest -ddd hello --test-name=upstream-tests --shell -- lxc -ddd --sudo autopkgtest-unstable-amd64
autopkgtest: DBG: got reply from testbed: ok
autopkgtest: DBG: testbed open, scratch=None
autopkgtest: DBG: sending command to testbed: open
autopkgtest-virt-lxc: DBG: executing open
autopkgtest-virt-lxc: DBG: execute-timeout: sudo lxc-ls
autopkgtest-virt-lxc: DBG: using container name autopkgtest-lxc-dkykgc
autopkgtest-virt-lxc: DBG: execute-timeout: timeout 300 sudo lxc-copy --name